From 452b9bacbaafdeff559ce49f31d661b24f491156 Mon Sep 17 00:00:00 2001 From: jean-pierre charras Date: Mon, 8 Nov 2021 17:14:48 +0100 Subject: [PATCH] DIALOG_MANAGE_REPOSITORIES: fix crash on exit: A event handler was pushed but not pop-ed. Fixes #9551 https://gitlab.com/kicad/code/kicad/issues/9551 --- kicad/pcm/dialogs/dialog_manage_repositories.cpp | 7 +++++++ kicad/pcm/dialogs/dialog_manage_repositories.h | 1 + 2 files changed, 8 insertions(+) diff --git a/kicad/pcm/dialogs/dialog_manage_repositories.cpp b/kicad/pcm/dialogs/dialog_manage_repositories.cpp index f28d1dbe70..ee81162afe 100644 --- a/kicad/pcm/dialogs/dialog_manage_repositories.cpp +++ b/kicad/pcm/dialogs/dialog_manage_repositories.cpp @@ -51,6 +51,13 @@ DIALOG_MANAGE_REPOSITORIES::DIALOG_MANAGE_REPOSITORIES( } +DIALOG_MANAGE_REPOSITORIES::~DIALOG_MANAGE_REPOSITORIES() +{ + // Delete the GRID_TRICKS. + m_grid->PopEventHandler( true ); +} + + void DIALOG_MANAGE_REPOSITORIES::setColumnWidths() { for( int col = 0; col < m_grid->GetNumberCols(); col++ ) diff --git a/kicad/pcm/dialogs/dialog_manage_repositories.h b/kicad/pcm/dialogs/dialog_manage_repositories.h index 88759c8e92..efb8983f83 100644 --- a/kicad/pcm/dialogs/dialog_manage_repositories.h +++ b/kicad/pcm/dialogs/dialog_manage_repositories.h @@ -42,6 +42,7 @@ protected: public: /** Constructor */ DIALOG_MANAGE_REPOSITORIES( wxWindow* parent, std::shared_ptr aPcm ); + ~DIALOG_MANAGE_REPOSITORIES(); void SetData( const STRING_PAIR_LIST& aData ); STRING_PAIR_LIST GetData();