From 47e4ebb32a1366d60649879381eac819f7c7131d Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Wed, 22 May 2024 10:34:49 -0700 Subject: [PATCH] Re-enable moving of all footprint text in board Seems like a lot of people really like to be able to modify the text positions/content of their footprints Fixes https://gitlab.com/kicad/code/kicad/-/issues/18024 --- pcbnew/tools/pcb_selection_tool.cpp | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/pcbnew/tools/pcb_selection_tool.cpp b/pcbnew/tools/pcb_selection_tool.cpp index 6ff2ec5cc3..715ac4d167 100644 --- a/pcbnew/tools/pcb_selection_tool.cpp +++ b/pcbnew/tools/pcb_selection_tool.cpp @@ -2857,19 +2857,8 @@ bool PCB_SELECTION_TOOL::Selectable( const BOARD_ITEM* aItem, bool checkVisibili // Most footprint children can only be selected in the footprint editor. if( aItem->GetParentFootprint() && !m_isFootprintEditor && !checkVisibilityOnly ) { - if( aItem->Type() == PCB_TEXT_T ) - { - text = static_cast( aItem ); - - // Special case for version 8 until we have a consistent way to convert these text - // to fields - if( !text->GetText().Contains( wxT( "${REFERENCE}" ) ) - && !text->GetText().Contains( wxT( "${VALUE}" ) ) ) - { - return false; - } - } - else if( aItem->Type() != PCB_FIELD_T && aItem->Type() != PCB_PAD_T ) + if( aItem->Type() != PCB_FIELD_T && aItem->Type() != PCB_PAD_T + && aItem->Type() != PCB_TEXT_T ) { return false; }