From 5114d3b8c3d52bbb66b126037a5d5702a4d35925 Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Thu, 25 May 2023 14:33:39 +0100 Subject: [PATCH] Don't use GetValueFieldText from within text var resolution. (It resets the recursion checker.) Fixes https://gitlab.com/kicad/code/kicad/-/issues/14815 --- eeschema/sch_symbol.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/eeschema/sch_symbol.cpp b/eeschema/sch_symbol.cpp index 56b6d41d28..8f55d924e5 100644 --- a/eeschema/sch_symbol.cpp +++ b/eeschema/sch_symbol.cpp @@ -1250,10 +1250,6 @@ bool SCH_SYMBOL::ResolveTextVar( const SCH_SHEET_PATH* aPath, wxString* token, i { if( i == REFERENCE_FIELD ) *token = GetRef( aPath, true ); - else if( i == VALUE_FIELD ) - *token = GetValueFieldText( true, aPath, false ); - else if( i == FOOTPRINT_FIELD ) - *token = GetFootprintFieldText( true, aPath, false ); else *token = m_fields[ i ].GetShownText( aPath, false, aDepth + 1 );