From 5bfafa5e4cb497a162050df3c0e4d770c3cc4641 Mon Sep 17 00:00:00 2001
From: Jon Evans <jon@craftyjon.com>
Date: Thu, 12 Aug 2021 20:17:04 -0400
Subject: [PATCH] Add rounding epsilon to convert tool polygon search

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8927
---
 pcbnew/tools/convert_tool.cpp | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/pcbnew/tools/convert_tool.cpp b/pcbnew/tools/convert_tool.cpp
index 1ff31f454d..235859318e 100644
--- a/pcbnew/tools/convert_tool.cpp
+++ b/pcbnew/tools/convert_tool.cpp
@@ -249,6 +249,11 @@ int CONVERT_TOOL::CreatePolys( const TOOL_EVENT& aEvent )
 
 SHAPE_POLY_SET CONVERT_TOOL::makePolysFromSegs( const std::deque<EDA_ITEM*>& aItems )
 {
+    // TODO: This code has a somewhat-similar purpose to ConvertOutlineToPolygon but is slightly
+    // different, so this remains a separate algorithm.  It might be nice to analyze the dfiferences
+    // in requirements and refactor this.
+    const int chainingEpsilon = Millimeter2iu( 0.02 );
+
     SHAPE_POLY_SET poly;
 
     // Stores pairs of (anchor, item) where anchor == 0 -> SEG.A, anchor == 1 -> SEG.B
@@ -256,13 +261,31 @@ SHAPE_POLY_SET CONVERT_TOOL::makePolysFromSegs( const std::deque<EDA_ITEM*>& aIt
     std::set<EDA_ITEM*> used;
     std::deque<EDA_ITEM*> toCheck;
 
+    auto closeEnough =
+            []( VECTOR2I aLeft, VECTOR2I aRight, unsigned aLimit )
+            {
+                return ( aLeft - aRight ).SquaredEuclideanNorm() <= SEG::Square( aLimit );
+            };
+
+    auto findInsertionPoint =
+            [&]( VECTOR2I aPoint ) -> VECTOR2I
+            {
+                for( const auto& candidatePair : connections )
+                {
+                    if( closeEnough( aPoint, candidatePair.first, chainingEpsilon ) )
+                        return candidatePair.first;
+                }
+
+                return aPoint;
+            };
+
     for( EDA_ITEM* item : aItems )
     {
         if( OPT<SEG> seg = getStartEndPoints( item, nullptr ) )
         {
             toCheck.push_back( item );
-            connections[seg->A].emplace_back( std::make_pair( 0, item ) );
-            connections[seg->B].emplace_back( std::make_pair( 1, item ) );
+            connections[findInsertionPoint( seg->A )].emplace_back( std::make_pair( 0, item ) );
+            connections[findInsertionPoint( seg->B )].emplace_back( std::make_pair( 1, item ) );
         }
     }