From 65821f747d4f65ed69a3c9d88df25d8eb1ac3c8d Mon Sep 17 00:00:00 2001
From: Jeff Young <jeff@rokeby.ie>
Date: Sat, 22 Jun 2019 20:56:57 +0100
Subject: [PATCH] Bring 3D viewer in line with Pcbnew's solder mask rendering.

---
 3d-viewer/3d_canvas/cinfo3d_visu.h            |  4 --
 .../3d_canvas/create_3Dgraphic_brd_items.cpp  | 45 +------------------
 2 files changed, 1 insertion(+), 48 deletions(-)

diff --git a/3d-viewer/3d_canvas/cinfo3d_visu.h b/3d-viewer/3d_canvas/cinfo3d_visu.h
index d47693e8bd..dac5556af7 100644
--- a/3d-viewer/3d_canvas/cinfo3d_visu.h
+++ b/3d-viewer/3d_canvas/cinfo3d_visu.h
@@ -425,10 +425,6 @@ class CINFO3D_VISU
     // Helper functions to create the board
     COBJECT2D *createNewTrack( const TRACK* aTrack , int aClearanceValue ) const;
 
-    void createNewPad( const D_PAD* aPad,
-                       CGENERICCONTAINER2D *aDstContainer,
-                       wxSize aInflateValue ) const;
-
     void createNewPadWithClearance( const D_PAD *aPad,
                                     CGENERICCONTAINER2D *aDstContainer,
                                     wxSize aClearanceValue ) const;
diff --git a/3d-viewer/3d_canvas/create_3Dgraphic_brd_items.cpp b/3d-viewer/3d_canvas/create_3Dgraphic_brd_items.cpp
index 2dc77a3645..737297ef07 100644
--- a/3d-viewer/3d_canvas/create_3Dgraphic_brd_items.cpp
+++ b/3d-viewer/3d_canvas/create_3Dgraphic_brd_items.cpp
@@ -572,49 +572,6 @@ COBJECT2D *CINFO3D_VISU::createNewPadDrill( const D_PAD* aPad, int aInflateValue
 }
 
 
-// This function pretends to be like the
-// void D_PAD::BuildPadShapePolygon(
-// board_items_to_polygon_shape_transform.cpp
-void CINFO3D_VISU::createNewPad( const D_PAD* aPad,
-                                       CGENERICCONTAINER2D *aDstContainer,
-                                       wxSize aInflateValue ) const
-{
-    switch( aPad->GetShape() )
-    {
-    case PAD_SHAPE_CIRCLE:
-    case PAD_SHAPE_OVAL:
-    case PAD_SHAPE_ROUNDRECT:
-    case PAD_SHAPE_CHAMFERED_RECT:
-    case PAD_SHAPE_CUSTOM:
-        createNewPadWithClearance( aPad, aDstContainer, aInflateValue );
-        break;
-
-    case PAD_SHAPE_TRAPEZOID:
-    case PAD_SHAPE_RECT:
-        wxPoint corners[4];
-        aPad->BuildPadPolygon( corners, aInflateValue, aPad->GetOrientation() );
-
-        // Note: for pad having a shape offset,
-        // the pad position is NOT the shape position
-        for( unsigned int ii = 0; ii < 4; ++ii )
-            corners[ii] += aPad->ShapePos(); // Shift origin to position
-
-        aDstContainer->Add( new CPOLYGON4PTS2D(
-                                SFVEC2F( corners[0].x * m_biuTo3Dunits,
-                                        -corners[0].y * m_biuTo3Dunits ),
-                                SFVEC2F( corners[1].x * m_biuTo3Dunits,
-                                        -corners[1].y * m_biuTo3Dunits ),
-                                SFVEC2F( corners[2].x * m_biuTo3Dunits,
-                                        -corners[2].y * m_biuTo3Dunits ),
-                                SFVEC2F( corners[3].x * m_biuTo3Dunits,
-                                        -corners[3].y * m_biuTo3Dunits ),
-                                *aPad ) );
-
-        break;
-    }
-}
-
-
 void CINFO3D_VISU::AddPadsShapesWithClearanceToContainer( const MODULE* aModule,
                                                           CGENERICCONTAINER2D *aDstContainer,
                                                           PCB_LAYER_ID aLayerId,
@@ -672,7 +629,7 @@ void CINFO3D_VISU::AddPadsShapesWithClearanceToContainer( const MODULE* aModule,
             break;
         }
 
-        createNewPad( pad, aDstContainer, margin );
+        createNewPadWithClearance( pad, aDstContainer, margin );
     }
 }