haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

eagle: Prevent 0-width lines in modules 

It is very difficult to select 0-width lines and they aren't physical on
the board.  Items with this setting in Eagle should revert to the
default in KiCad.

Fixes: lp:1808584
* https://bugs.launchpad.net/kicad/+bug/1808584
This commit is contained in:
Seth Hillbrand 2019-01-05 14:12:48 -08:00
parent 5e705347bb
commit 69fc301bf3
1 changed files with 47 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
pcbnew/eagle_plugin.cpp
View File

@ -1393,6 +1393,26 @@ void EAGLE_PLUGIN::packageWire( MODULE* aModule, wxXmlNode* aTree ) const
wxPoint end( kicad_x( w.x2 ), kicad_y( w.y2 ) ); wxPoint end( kicad_x( w.x2 ), kicad_y( w.y2 ) );
int width = w.width.ToPcbUnits(); int width = w.width.ToPcbUnits();
if( width <= 0 )
{
switch( layer )
{
case Edge_Cuts:
width = DEFAULT_EDGE_WIDTH;
break;
case F_SilkS:
case B_SilkS:
width = DEFAULT_SILK_LINE_WIDTH;
break;
case F_CrtYd:
case B_CrtYd:
width = DEFAULT_COURTYARD_WIDTH;
break;
default:
width = DEFAULT_LINE_WIDTH;
}
}
// FIXME: the cap attribute is ignored because kicad can't create lines // FIXME: the cap attribute is ignored because kicad can't create lines
// with flat ends. // with flat ends.
EDGE_MODULE* dwg; EDGE_MODULE* dwg;
@ -1718,20 +1738,38 @@ void EAGLE_PLUGIN::packageCircle( MODULE* aModule, wxXmlNode* aTree ) const
ECIRCLE e( aTree ); ECIRCLE e( aTree );
PCB_LAYER_ID layer = kicad_layer( e.layer ); PCB_LAYER_ID layer = kicad_layer( e.layer );
EDGE_MODULE* gr = new EDGE_MODULE( aModule, S_CIRCLE ); EDGE_MODULE* gr = new EDGE_MODULE( aModule, S_CIRCLE );
int width = e.width.ToPcbUnits();
if( width <= 0 )
{
switch( layer )
{
case Edge_Cuts:
width = DEFAULT_EDGE_WIDTH;
break;
case F_SilkS:
case B_SilkS:
width = DEFAULT_SILK_LINE_WIDTH;
break;
case F_CrtYd:
case B_CrtYd:
width = DEFAULT_COURTYARD_WIDTH;
break;
default:
width = DEFAULT_LINE_WIDTH;
}
}
aModule->GraphicalItemsList().PushBack( gr ); aModule->GraphicalItemsList().PushBack( gr );
gr->SetWidth( width );
gr->SetWidth( e.width.ToPcbUnits() ); switch ( (int) layer )
switch( (int) layer )
{ {
case UNDEFINED_LAYER: layer = Cmts_User; break; case UNDEFINED_LAYER:
/* layer = Cmts_User;
case Eco1_User: layer = F_SilkS; break; break;
case Eco2_User: layer = B_SilkS; break;
*/
default: default:
break; break;
} }
gr->SetLayer( layer ); gr->SetLayer( layer );