From 6a8519dfd902b51023319a085b3ddd162ed695a8 Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Tue, 28 Jun 2022 15:02:36 -0700 Subject: [PATCH] Fix ERC error missing on stacked pins Stacked pins are not connected, so they should be flagged as such. This checks for stacked pins that are not part of different symbols Fixes https://gitlab.com/kicad/code/kicad/issues/11926 (cherry picked from commit 90ef84b9583d462d63528dd5c5b151d0fd49960f) --- eeschema/connection_graph.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/eeschema/connection_graph.cpp b/eeschema/connection_graph.cpp index f5a311d86f..f91803110d 100644 --- a/eeschema/connection_graph.cpp +++ b/eeschema/connection_graph.cpp @@ -2666,7 +2666,8 @@ bool CONNECTION_GRAPH::ercCheckNoConnects( const CONNECTION_SUBGRAPH* aSubgraph { case SCH_PIN_T: { - if( !pins.empty() ) + // Only consider a connection to be between pins on different symbols + if( !pins.empty() && ( item->GetParent() != pins.front()->GetParent() ) ) has_other_connections = true; pins.emplace_back( static_cast( item ) );