From 6b99a937d8c4dacac6d10208f3670e72123edcf5 Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Thu, 31 Mar 2022 22:09:35 +0100 Subject: [PATCH] Look for sheet pins inside sheets. Fixes https://gitlab.com/kicad/code/kicad/issues/11297 --- .../dialogs/dialog_global_edit_text_and_graphics.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/eeschema/dialogs/dialog_global_edit_text_and_graphics.cpp b/eeschema/dialogs/dialog_global_edit_text_and_graphics.cpp index 88e8a33055..ef10db4971 100644 --- a/eeschema/dialogs/dialog_global_edit_text_and_graphics.cpp +++ b/eeschema/dialogs/dialog_global_edit_text_and_graphics.cpp @@ -31,6 +31,7 @@ #include #include #include +#include #include #include #include @@ -446,6 +447,12 @@ void DIALOG_GLOBAL_EDIT_TEXT_AND_GRAPHICS::visitItem( const SCH_SHEET_PATH& aShe if( m_setFillColor->GetValue() ) sheet->SetBackgroundColor( m_fillColorSwatch->GetSwatchColor() ); } + + if( m_sheetPins->GetValue() ) + { + for( SCH_SHEET_PIN* pin : sheet->GetPins() ) + processItem( aSheetPath, pin ); + } } else if( aItem->Type() == SCH_JUNCTION_T ) { @@ -473,8 +480,6 @@ void DIALOG_GLOBAL_EDIT_TEXT_AND_GRAPHICS::visitItem( const SCH_SHEET_PATH& aShe processItem( aSheetPath, aItem ); else if( m_hierLabels->GetValue() && aItem->Type() == SCH_HIER_LABEL_T ) processItem( aSheetPath, aItem ); - else if( m_sheetPins->GetValue() && aItem->Type() == SCH_SHEET_PIN_T ) - processItem( aSheetPath, aItem ); else if( m_schTextAndGraphics->GetValue() && aItem->IsType( schTextAndGraphics ) ) processItem( aSheetPath, aItem ); }