From 6d11c85cad5178a4a79869f255df161abb952fb1 Mon Sep 17 00:00:00 2001
From: Jeff Young <jeff@rokeby.ie>
Date: Fri, 19 Apr 2024 10:26:03 +0100
Subject: [PATCH] Initialize all member variables.

---
 eeschema/symbol.h | 40 +++++++++++++++++-----------------------
 1 file changed, 17 insertions(+), 23 deletions(-)

diff --git a/eeschema/symbol.h b/eeschema/symbol.h
index 3ae5c7bd00..98a474d988 100644
--- a/eeschema/symbol.h
+++ b/eeschema/symbol.h
@@ -33,28 +33,20 @@
 class SYMBOL : public SCH_ITEM
 {
 public:
-    void init()
-    {
-        m_pinNameOffset = 0;
-        m_showPinNames = true;
-        m_showPinNumbers = true;
-        m_excludedFromSim = false;
-        m_excludedFromBOM = false;
-        m_excludedFromBoard = false;
-        m_DNP = false;
-    };
-
     SYMBOL( KICAD_T idType ) :
-            SCH_ITEM( nullptr, idType )
-    {
-        init();
-    };
+            SYMBOL( nullptr, idType )
+    { }
 
     SYMBOL( EDA_ITEM* aParent, KICAD_T idType ) :
-            SCH_ITEM( aParent, idType )
-    {
-        init();
-    };
+            SCH_ITEM( aParent, idType ),
+            m_pinNameOffset( 0 ),
+            m_showPinNames( true ),
+            m_showPinNumbers( true ),
+            m_excludedFromSim( false ),
+            m_excludedFromBOM( false ),
+            m_excludedFromBoard( false ),
+            m_DNP( false )
+    { }
 
     SYMBOL( const SYMBOL& base ) :
             SCH_ITEM( base ),
@@ -63,25 +55,27 @@ public:
             m_showPinNumbers( base.m_showPinNumbers ),
             m_excludedFromSim( base.m_excludedFromSim ),
             m_excludedFromBOM( base.m_excludedFromBOM ),
-            m_excludedFromBoard( base.m_excludedFromBoard )
-    { };
+            m_excludedFromBoard( base.m_excludedFromBoard ),
+            m_DNP( base.m_DNP )
+    { }
 
     SYMBOL& operator=( const SYMBOL& aItem )
     {
         SCH_ITEM::operator=( aItem );
 
-        m_pinNameOffset    = aItem.m_pinNameOffset;
+        m_pinNameOffset     = aItem.m_pinNameOffset;
         m_showPinNames      = aItem.m_showPinNames;
         m_showPinNumbers    = aItem.m_showPinNumbers;
 
         m_excludedFromSim   = aItem.m_excludedFromSim;
         m_excludedFromBOM   = aItem.m_excludedFromBOM;
         m_excludedFromBoard = aItem.m_excludedFromBoard;
+        m_DNP               = aItem.m_DNP;
 
         return *this;
     };
 
-    virtual ~SYMBOL() { };
+    ~SYMBOL() override { };
 
     virtual const LIB_ID& GetLibId() const = 0;
     virtual wxString GetDescription() const = 0;