From 73053a2177b4b200e8dbcd1cdfce51a29e72b192 Mon Sep 17 00:00:00 2001 From: Jon Evans Date: Thu, 8 Feb 2024 18:46:30 -0500 Subject: [PATCH] Disable flaky ngspice tests These need to be re-done in a way that is more tolerant of the inherent instability/noise in the simulated circuits (or more ideally, changed to test a particular thing that can be more well-defined rather than just simulating a circuit and seeing if the numbers come out a certain way) (cherry picked from commit e427099cff04128bef7594445d8d4d97590b91ff) --- qa/unittests/eeschema/sim/test_sim_regressions.cpp | 4 ++++ qa/unittests/eeschema/test_netlist_exporter_spice.cpp | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/qa/unittests/eeschema/sim/test_sim_regressions.cpp b/qa/unittests/eeschema/sim/test_sim_regressions.cpp index 3fb07662fd..efca7124a1 100644 --- a/qa/unittests/eeschema/sim/test_sim_regressions.cpp +++ b/qa/unittests/eeschema/sim/test_sim_regressions.cpp @@ -109,6 +109,9 @@ BOOST_FIXTURE_TEST_CASE( ImmediateSBCKT, TEST_SIM_REGRESSIONS_FIXTURE ) } +// This test is flaky and fails on ngspice-42 / Linux. +// Please replace it with something that is more stable +#if 0 BOOST_FIXTURE_TEST_CASE( LegacyFixups, TEST_SIM_REGRESSIONS_FIXTURE ) { LOCALE_IO dummy; @@ -120,6 +123,7 @@ BOOST_FIXTURE_TEST_CASE( LegacyFixups, TEST_SIM_REGRESSIONS_FIXTURE ) TestTranPoint( 0.01, { { "V(out)", -0.060 } } ); TestTranPoint( 0.02, { { "V(out)", 0.856 } } ); } +#endif BOOST_FIXTURE_TEST_CASE( DualNMOSAmp, TEST_SIM_REGRESSIONS_FIXTURE ) diff --git a/qa/unittests/eeschema/test_netlist_exporter_spice.cpp b/qa/unittests/eeschema/test_netlist_exporter_spice.cpp index b7bbf28946..9f712b6548 100644 --- a/qa/unittests/eeschema/test_netlist_exporter_spice.cpp +++ b/qa/unittests/eeschema/test_netlist_exporter_spice.cpp @@ -197,6 +197,9 @@ BOOST_AUTO_TEST_CASE( Directives ) #endif +// This test is flaky and fails on ngspice-42 / Linux. +// Please replace it with something that is more stable +#if 0 BOOST_AUTO_TEST_CASE( LegacyLaserDriver ) { LOCALE_IO dummy; @@ -213,6 +216,7 @@ BOOST_AUTO_TEST_CASE( LegacyLaserDriver ) // Test D1 current after the pulse TestTranPoint( 150e-9, { { "I(D1)", 0 } } ); } +#endif BOOST_AUTO_TEST_CASE( LegacyPotentiometer )