From 75190370dd92fc15921ff0a2989e29317054a3be Mon Sep 17 00:00:00 2001 From: Jon Evans Date: Mon, 19 Jul 2021 18:45:33 -0400 Subject: [PATCH] Convert -> Create from Selection Fixes https://gitlab.com/kicad/code/kicad/-/issues/8818 --- pcbnew/tools/convert_tool.cpp | 2 +- pcbnew/tools/pcb_actions.cpp | 13 ++++++------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/pcbnew/tools/convert_tool.cpp b/pcbnew/tools/convert_tool.cpp index 7bb265db79..a1737329a6 100644 --- a/pcbnew/tools/convert_tool.cpp +++ b/pcbnew/tools/convert_tool.cpp @@ -72,7 +72,7 @@ bool CONVERT_TOOL::Init() // Create a context menu and make it available through selection tool m_menu = new CONDITIONAL_MENU( this ); m_menu->SetIcon( BITMAPS::convert ); - m_menu->SetTitle( _( "Convert" ) ); + m_menu->SetTitle( _( "Create from Selection" ) ); static KICAD_T convertibleTracks[] = { PCB_TRACE_T, PCB_ARC_T, EOT }; static KICAD_T zones[] = { PCB_ZONE_T, PCB_FP_ZONE_T, EOT }; diff --git a/pcbnew/tools/pcb_actions.cpp b/pcbnew/tools/pcb_actions.cpp index afd2ae3613..deee1937f4 100644 --- a/pcbnew/tools/pcb_actions.cpp +++ b/pcbnew/tools/pcb_actions.cpp @@ -33,7 +33,6 @@ #include #include - // Actions, being statically-defined, require specialized I18N handling. We continue to // use the _() macro so that string harvesting by the I18N framework doesn't have to be // specialized, but we don't translate on initialization and instead do it in the getters. @@ -46,32 +45,32 @@ // TOOL_ACTION PCB_ACTIONS::convertToPoly( "pcbnew.Convert.convertToPoly", AS_GLOBAL, 0, "", - _( "Convert to Polygon" ), _( "Creates a graphic polygon from the selection" ), + _( "Create Polygon from Selection" ), _( "Creates a graphic polygon from the selection" ), BITMAPS::add_graphical_polygon ); TOOL_ACTION PCB_ACTIONS::convertToZone( "pcbnew.Convert.convertToZone", AS_GLOBAL, 0, "", - _( "Convert to Zone" ), _( "Creates a copper zone from the selection" ), + _( "Create Zone from Selection" ), _( "Creates a copper zone from the selection" ), BITMAPS::add_zone ); TOOL_ACTION PCB_ACTIONS::convertToKeepout( "pcbnew.Convert.convertToKeepout", AS_GLOBAL, 0, "", - _( "Convert to Rule Area" ), _( "Creates a rule area from the selection" ), + _( "Create Rule Area from Selection" ), _( "Creates a rule area from the selection" ), BITMAPS::add_keepout_area ); TOOL_ACTION PCB_ACTIONS::convertToLines( "pcbnew.Convert.convertToLines", AS_GLOBAL, 0, "", - _( "Convert to Lines" ), _( "Creates graphic lines from the selection" ), + _( "Create Lines from Selection" ), _( "Creates graphic lines from the selection" ), BITMAPS::add_line ); TOOL_ACTION PCB_ACTIONS::convertToArc( "pcbnew.Convert.convertToArc", AS_GLOBAL, 0, "", - _( "Convert to Arc" ), _( "Converts selected line segment to an arc" ), + _( "Create Arc from Selection" ), _( "Creates an arc from the selected line segment" ), BITMAPS::add_arc ); TOOL_ACTION PCB_ACTIONS::convertToTracks( "pcbnew.Convert.convertToTracks", AS_GLOBAL, 0, "", - _( "Convert to Tracks" ), _( "Converts selected graphic lines to tracks" ), + _( "Create Tracks from Selection" ), _( "Creates tracks from the selected graphic lines" ), BITMAPS::add_tracks );