From 79e7a27492563b4ee49440dcf80008a8c77464eb Mon Sep 17 00:00:00 2001
From: jean-pierre charras <jp.charras@wanadoo.fr>
Date: Sun, 2 Feb 2020 08:55:24 +0100
Subject: [PATCH] Fix a few Coverity warnings.

---
 common/gal/opengl/opengl_gal.cpp |  4 ++++
 thirdparty/clipper/clipper.cpp   | 24 +++++++++++++++++++++++-
 2 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/common/gal/opengl/opengl_gal.cpp b/common/gal/opengl/opengl_gal.cpp
index 4176d1e984..ac93e8ace4 100644
--- a/common/gal/opengl/opengl_gal.cpp
+++ b/common/gal/opengl/opengl_gal.cpp
@@ -1806,6 +1806,10 @@ int OPENGL_GAL::drawBitmapChar( unsigned long aChar )
     {
         const FONT_GLYPH_TYPE* g = LookupGlyph( 'x' );
         wxASSERT( g );
+
+        if( !g )    // Should not happen.
+            return 0;
+
         Translate( VECTOR2D( g->advance, 0 ) );
         return g->advance;
     }
diff --git a/thirdparty/clipper/clipper.cpp b/thirdparty/clipper/clipper.cpp
index ab7e6e6679..b0656ec2dc 100644
--- a/thirdparty/clipper/clipper.cpp
+++ b/thirdparty/clipper/clipper.cpp
@@ -201,7 +201,8 @@ int PolyTree::Total() const
 // PolyNode methods ...
 // ------------------------------------------------------------------------------
 
-PolyNode::PolyNode() : Parent( 0 ), Index( 0 ), m_IsOpen( false )
+PolyNode::PolyNode() : Parent( 0 ), Index( 0 ), m_IsOpen( false ),
+        m_jointype( jtSquare ), m_endtype( etClosedPolygon )
 {
 }
 
@@ -1131,6 +1132,11 @@ ClipperBase::ClipperBase()              // constructor
 {
     m_CurrentLM = m_MinimaList.begin(); // begin() == end() here
     m_UseFullRange = false;
+
+    // Avoid uninitialized vars:
+    m_PreserveCollinear = false;
+    m_HasOpenPaths = false;
+    m_ActiveEdges = nullptr;
 }
 
 
@@ -1950,6 +1956,13 @@ Clipper::Clipper( int initOptions ) : ClipperBase()    // constructor
     m_StrictSimple  = ( (initOptions & ioStrictlySimple) != 0 );
     m_PreserveCollinear = ( (initOptions & ioPreserveCollinear) != 0 );
     m_HasOpenPaths = false;
+
+    // Avoid uninitialized vars
+    m_ClipType = ctIntersection;
+    m_SortedEdges = nullptr;
+    m_ClipFillType = pftEvenOdd;
+    m_SubjFillType = pftEvenOdd;
+    m_UsingPolyTree = false;
 #ifdef use_xyz
     m_ZFill = 0;
 #endif
@@ -4902,6 +4915,15 @@ ClipperOffset::ClipperOffset( double miterLimit, double arcTolerance )
     this->MiterLimit = miterLimit;
     this->ArcTolerance = arcTolerance;
     m_lowest.X = -1;
+
+    //Avoid uninitialized vars:
+    MiterFallback = jtSquare;
+    m_delta = 1.0;
+    m_sinA = 0.0;
+    m_sin = 0.0;
+    m_cos = 0.0;
+    m_miterLim = 1.0;
+    m_StepsPerRad = 1.0;
 }