From 7d25675e2bbfef8c7828788420f82d331103c8c0 Mon Sep 17 00:00:00 2001
From: Jon Evans <jon@craftyjon.com>
Date: Tue, 26 Dec 2023 14:08:39 -0500
Subject: [PATCH] Fix handling of dimensions in footprint updater

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16448
---
 pcbnew/pcb_edit_frame.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/pcbnew/pcb_edit_frame.cpp b/pcbnew/pcb_edit_frame.cpp
index 2f778e16ef..535338ab92 100644
--- a/pcbnew/pcb_edit_frame.cpp
+++ b/pcbnew/pcb_edit_frame.cpp
@@ -2284,6 +2284,10 @@ void PCB_EDIT_FRAME::ExchangeFootprint( FOOTPRINT* aExisting, FOOTPRINT* aNew,
 
         if( srcItem )
         {
+            // Dimensions have PCB_TEXT base but are not treated like texts in the updater
+            if( dynamic_cast<PCB_DIMENSION_BASE*>( srcItem ) )
+                continue;
+
             PCB_TEXT* destItem = getMatchingTextItem( srcItem, aNew );
 
             if( destItem )
@@ -2293,7 +2297,7 @@ void PCB_EDIT_FRAME::ExchangeFootprint( FOOTPRINT* aExisting, FOOTPRINT* aNew,
             }
             else if( !deleteExtraTexts )
             {
-                aNew->Add( new PCB_TEXT( *srcItem ) );
+                aNew->Add( static_cast<BOARD_ITEM*>( srcItem->Clone() ) );
             }
         }
     }