From 7df05ade4cafc467bd503b82cf8e276918bdf972 Mon Sep 17 00:00:00 2001 From: jean-pierre charras Date: Thu, 25 Jul 2019 17:37:25 +0200 Subject: [PATCH] Pcbnew: Fix bug in MODULE::FindPadByName( const wxString& aPadName ). This method was using a case insensitive comparison to find the pad matching aPadName. But in netlist we are using case sensitive comparisons to attribute a net to a pad. So if in the netlist there is a pad name that does not match any footprint pad name using case sensitive comparison but if it matches some pads using case insensitive comparison, the net is not set, but the test to detect non existing pads fails. --- pcbnew/class_module.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pcbnew/class_module.cpp b/pcbnew/class_module.cpp index 1da87ca3de..928c7d92b5 100644 --- a/pcbnew/class_module.cpp +++ b/pcbnew/class_module.cpp @@ -680,7 +680,7 @@ D_PAD* MODULE::FindPadByName( const wxString& aPadName ) const { for( D_PAD* pad = m_Pads; pad; pad = pad->Next() ) { - if( pad->GetName().CmpNoCase( aPadName ) == 0 ) // why case insensitive? + if( pad->GetName() == aPadName ) return pad; }