From 7e8070b7006df89ec9e732d89861316e3966bcb4 Mon Sep 17 00:00:00 2001 From: jean-pierre charras Date: Mon, 26 Jun 2023 11:27:06 +0200 Subject: [PATCH] pcb_parser: fix incorrect handling of rotation of PCB_TEXTs in footprints. Fixes #15054 https://gitlab.com/kicad/code/kicad/-/issues/15054 --- pcbnew/plugins/kicad/pcb_parser.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pcbnew/plugins/kicad/pcb_parser.cpp b/pcbnew/plugins/kicad/pcb_parser.cpp index aabaebdecf..b61e74ca3f 100644 --- a/pcbnew/plugins/kicad/pcb_parser.cpp +++ b/pcbnew/plugins/kicad/pcb_parser.cpp @@ -3135,6 +3135,11 @@ void PCB_PARSER::parsePCB_TEXT_effects( PCB_TEXT* aText ) if( parentFP ) { + // make PCB_TEXT rotation relative to the parent footprint. + // It was read as absolute rotation from file + aText->SetTextAngle( aText->GetTextAngle() - parentFP->GetOrientation() ); + + // Move and rotate the text to its board coordinates aText->Rotate( { 0, 0 }, parentFP->GetOrientation() ); aText->Move( parentFP->GetPosition() ); } @@ -4022,7 +4027,6 @@ FOOTPRINT* PCB_PARSER::parseFOOTPRINT_unchecked( wxArrayString* aInitialComments case T_fp_text: { PCB_TEXT* text = parsePCB_TEXT( footprint.get() ); - text->SetTextAngle( text->GetTextAngle() - footprint->GetOrientation()); if( PCB_FIELD* field = dynamic_cast( text ) ) {