From 833146cf501232c5cd0d92c019319cb7ef257811 Mon Sep 17 00:00:00 2001 From: Mikolaj Wielgus Date: Tue, 22 Nov 2022 21:18:01 +0100 Subject: [PATCH] Sim QA: Fix QA errors Let's not allow units in fields for now. (is 1m one meter or one milli?) --- .../fliege_filter/fliege_filter.kicad_sch | 9 ++++--- .../potentiometers/potentiometers.kicad_sch | 18 +++++++++----- .../eeschema/spice_netlists/rlc/rlc.kicad_sch | 24 +++++++++---------- 3 files changed, 30 insertions(+), 21 deletions(-) diff --git a/qa/data/eeschema/spice_netlists/fliege_filter/fliege_filter.kicad_sch b/qa/data/eeschema/spice_netlists/fliege_filter/fliege_filter.kicad_sch index e6c088ac51..66f378ae31 100644 --- a/qa/data/eeschema/spice_netlists/fliege_filter/fliege_filter.kicad_sch +++ b/qa/data/eeschema/spice_netlists/fliege_filter/fliege_filter.kicad_sch @@ -850,12 +850,12 @@ ) (symbol (lib_id "Simulation_SPICE:VSIN") (at 114.3 95.25 0) (unit 1) - (in_bom yes) (on_board yes) (dnp no) (fields_autoplaced) + (in_bom yes) (on_board yes) (dnp no) (uuid 88021970-b98d-4b3b-8504-80e76499ab7b) (property "Reference" "V1" (at 118.11 93.345 0) (effects (font (size 1.27 1.27)) (justify left)) ) - (property "Value" "ac=1" (at 118.11 95.885 0) + (property "Value" "V" (at 118.11 95.885 0) (effects (font (size 1.27 1.27)) (justify left)) ) (property "Footprint" "" (at 114.3 95.25 0) @@ -867,12 +867,15 @@ (property "Sim.Device" "V" (at 114.3 95.25 0) (effects (font (size 1.27 1.27)) hide) ) + (property "Sim.Params" "ac=1" (at 120.65 97.79 0) + (effects (font (size 1.27 1.27))) + ) (pin "1" (uuid d18a7be3-befb-4f82-9812-85b576c6ba5e)) (pin "2" (uuid 9a1a9ed4-ff64-4de9-9d48-d4c40f1612a0)) (instances (project "fliege_filter" (path "/1bb7f68e-09b1-4448-8403-97b70f8d3680" - (reference "V1") (unit 1) (value "ac=1") (footprint "") + (reference "V1") (unit 1) (value "V") (footprint "") ) ) ) diff --git a/qa/data/eeschema/spice_netlists/potentiometers/potentiometers.kicad_sch b/qa/data/eeschema/spice_netlists/potentiometers/potentiometers.kicad_sch index 9fff6a388e..ae4b2be552 100644 --- a/qa/data/eeschema/spice_netlists/potentiometers/potentiometers.kicad_sch +++ b/qa/data/eeschema/spice_netlists/potentiometers/potentiometers.kicad_sch @@ -318,12 +318,12 @@ ) (symbol (lib_id "Device:R_Potentiometer") (at 152.4 133.35 0) (unit 1) - (in_bom yes) (on_board yes) (dnp no) (fields_autoplaced) + (in_bom yes) (on_board yes) (dnp no) (uuid 7d86509c-cffd-4987-9581-6c934a4e33c5) (property "Reference" "RV3" (at 149.86 132.715 0) (effects (font (size 1.27 1.27)) (justify right)) ) - (property "Value" "1kΩ 10% pos=0.1" (at 149.86 135.255 0) + (property "Value" "1k" (at 149.86 135.255 0) (effects (font (size 1.27 1.27)) (justify right)) ) (property "Footprint" "" (at 152.4 133.35 0) @@ -338,13 +338,16 @@ (property "Sim.Type" "POT" (at 152.4 133.35 0) (effects (font (size 1.27 1.27)) hide) ) + (property "Sim.Params" "pos=0.1" (at 146.05 137.16 0) + (effects (font (size 1.27 1.27))) + ) (pin "1" (uuid c77da26e-2c80-4310-84bf-e1a90dc2094f)) (pin "2" (uuid 03dbec1f-269e-4720-a4dd-2cbbc854fa89)) (pin "3" (uuid f76a306b-9f82-41eb-a2bd-27e1b85e66b9)) (instances (project "potentiometers" (path "/1982c87f-95a1-4a40-9669-f13cd3c28543" - (reference "RV3") (unit 1) (value "1kΩ 10% pos=0.1") (footprint "") + (reference "RV3") (unit 1) (value "1k") (footprint "") ) ) ) @@ -463,12 +466,12 @@ ) (symbol (lib_id "Device:R_Potentiometer") (at 152.4 95.25 0) (unit 1) - (in_bom yes) (on_board yes) (dnp no) (fields_autoplaced) + (in_bom yes) (on_board yes) (dnp no) (uuid e2f6f1d9-7fa5-40e4-8062-077093991555) (property "Reference" "RV2" (at 149.86 94.615 0) (effects (font (size 1.27 1.27)) (justify right)) ) - (property "Value" "1k pos=0.3" (at 149.86 97.155 0) + (property "Value" "1k" (at 149.86 97.155 0) (effects (font (size 1.27 1.27)) (justify right)) ) (property "Footprint" "" (at 152.4 95.25 0) @@ -483,13 +486,16 @@ (property "Sim.Type" "POT" (at 152.4 95.25 0) (effects (font (size 1.27 1.27)) hide) ) + (property "Sim.Params" "pos=0.3" (at 146.05 99.06 0) + (effects (font (size 1.27 1.27))) + ) (pin "1" (uuid 506d640e-0a3d-4ba3-a5f0-80d908fad32d)) (pin "2" (uuid dc9b9c37-5353-4880-87bb-8fc37017c528)) (pin "3" (uuid db81ec35-ea18-4bf8-aefc-34db5616ae22)) (instances (project "potentiometers" (path "/1982c87f-95a1-4a40-9669-f13cd3c28543" - (reference "RV2") (unit 1) (value "1k pos=0.3") (footprint "") + (reference "RV2") (unit 1) (value "1k") (footprint "") ) ) ) diff --git a/qa/data/eeschema/spice_netlists/rlc/rlc.kicad_sch b/qa/data/eeschema/spice_netlists/rlc/rlc.kicad_sch index 2473d463f3..49700ef5d1 100644 --- a/qa/data/eeschema/spice_netlists/rlc/rlc.kicad_sch +++ b/qa/data/eeschema/spice_netlists/rlc/rlc.kicad_sch @@ -430,7 +430,7 @@ (property "Reference" "Cs1" (at 130.81 107.315 0) (effects (font (size 1.27 1.27)) (justify left)) ) - (property "Value" "100uF" (at 130.81 109.855 0) + (property "Value" "100u" (at 130.81 109.855 0) (effects (font (size 1.27 1.27)) (justify left)) ) (property "Footprint" "" (at 127.9652 111.76 0) @@ -447,7 +447,7 @@ (instances (project "rlc" (path "/b0197b4d-36ea-4821-991f-20bf73bcc80c" - (reference "Cs1") (unit 1) (value "100uF") (footprint "") + (reference "Cs1") (unit 1) (value "100u") (footprint "") ) ) ) @@ -459,7 +459,7 @@ (property "Reference" "Rp1" (at 193.04 94.615 0) (effects (font (size 1.27 1.27)) (justify left)) ) - (property "Value" "1KΩ" (at 193.04 97.155 0) + (property "Value" "1K" (at 193.04 97.155 0) (effects (font (size 1.27 1.27)) (justify left)) ) (property "Footprint" "" (at 188.722 95.25 90) @@ -476,7 +476,7 @@ (instances (project "rlc" (path "/b0197b4d-36ea-4821-991f-20bf73bcc80c" - (reference "Rp1") (unit 1) (value "1KΩ") (footprint "") + (reference "Rp1") (unit 1) (value "1K") (footprint "") ) ) ) @@ -488,7 +488,7 @@ (property "Reference" "Lp1" (at 204.47 94.615 0) (effects (font (size 1.27 1.27)) (justify left)) ) - (property "Value" "100uH" (at 204.47 97.155 0) + (property "Value" "100u" (at 204.47 97.155 0) (effects (font (size 1.27 1.27)) (justify left)) ) (property "Footprint" "" (at 203.2 95.25 0) @@ -505,7 +505,7 @@ (instances (project "rlc" (path "/b0197b4d-36ea-4821-991f-20bf73bcc80c" - (reference "Lp1") (unit 1) (value "100uH") (footprint "") + (reference "Lp1") (unit 1) (value "100u") (footprint "") ) ) ) @@ -517,7 +517,7 @@ (property "Reference" "Rs1" (at 129.54 81.915 0) (effects (font (size 1.27 1.27)) (justify left)) ) - (property "Value" "1mΩ" (at 129.54 84.455 0) + (property "Value" "1m" (at 129.54 84.455 0) (effects (font (size 1.27 1.27)) (justify left)) ) (property "Footprint" "" (at 125.222 82.55 90) @@ -534,7 +534,7 @@ (instances (project "rlc" (path "/b0197b4d-36ea-4821-991f-20bf73bcc80c" - (reference "Rs1") (unit 1) (value "1mΩ") (footprint "") + (reference "Rs1") (unit 1) (value "1m") (footprint "") ) ) ) @@ -646,7 +646,7 @@ (property "Reference" "Cp1" (at 219.71 94.615 0) (effects (font (size 1.27 1.27)) (justify left)) ) - (property "Value" "100uF" (at 219.71 97.155 0) + (property "Value" "100u" (at 219.71 97.155 0) (effects (font (size 1.27 1.27)) (justify left)) ) (property "Footprint" "" (at 216.8652 99.06 0) @@ -663,7 +663,7 @@ (instances (project "rlc" (path "/b0197b4d-36ea-4821-991f-20bf73bcc80c" - (reference "Cp1") (unit 1) (value "100uF") (footprint "") + (reference "Cp1") (unit 1) (value "100u") (footprint "") ) ) ) @@ -745,7 +745,7 @@ (property "Reference" "Ls1" (at 128.27 94.615 0) (effects (font (size 1.27 1.27)) (justify left)) ) - (property "Value" "100uH" (at 128.27 97.155 0) + (property "Value" "100u" (at 128.27 97.155 0) (effects (font (size 1.27 1.27)) (justify left)) ) (property "Footprint" "" (at 127 95.25 0) @@ -762,7 +762,7 @@ (instances (project "rlc" (path "/b0197b4d-36ea-4821-991f-20bf73bcc80c" - (reference "Ls1") (unit 1) (value "100uH") (footprint "") + (reference "Ls1") (unit 1) (value "100u") (footprint "") ) ) )