From 91446c15154f8aef67a166ad96d9190e4c25cd4d Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Sun, 4 Aug 2019 09:02:31 -0700 Subject: [PATCH] eeschema: Fix list invalidation When removing a junction, we need to keep the next pointer for deleted item, marking them with a flag until committed. Fixes: lp:1837398 * https://bugs.launchpad.net/kicad/+bug/1837398 (cherry picked from commit 4363e6a2136ff4af2693a4ac5686ae6e8cd90086) --- eeschema/bus-wire-junction.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/eeschema/bus-wire-junction.cpp b/eeschema/bus-wire-junction.cpp index 4bdba2fe9a..462de62ef2 100644 --- a/eeschema/bus-wire-junction.cpp +++ b/eeschema/bus-wire-junction.cpp @@ -336,7 +336,6 @@ void SCH_EDIT_FRAME::DeleteJunction( SCH_ITEM* aJunction, bool aAppend ) { aItem->SetFlags( STRUCT_DELETED ); itemList.PushItem( ITEM_PICKER( aItem, UR_DELETED ) ); - RemoveFromScreen( aItem ); }; remove_item( aJunction );