From 9864337914eb7c166c1ff068dbe216301cd6b4ac Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Thu, 6 Jan 2022 12:31:59 -0800 Subject: [PATCH] Do not call SafeYield on close wxSafeYield() is not "safe". Pending actions may include deletion of the currently active class. This will cause crashes when exiting. If needed for specific behaviors, we should use wxSafeYieldFor( flag ) with the appropriate events specified rather than a general yield which can cause more problems --- kicad/kicad_manager_frame.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/kicad/kicad_manager_frame.cpp b/kicad/kicad_manager_frame.cpp index 246abed524..e3a0046a4e 100644 --- a/kicad/kicad_manager_frame.cpp +++ b/kicad/kicad_manager_frame.cpp @@ -415,9 +415,6 @@ bool KICAD_MANAGER_FRAME::CloseProject( bool aSave ) if( !Kiway().PlayersClose( false ) ) return false; - // Give a timeslice for the save-changes? dialog (and for the project to actually close) - wxSafeYield(); - // Save the project file for the currently loaded project. if( m_active_project ) {