From 99bfa2fea21cda876cdd33396507c7623572c3b8 Mon Sep 17 00:00:00 2001 From: Chris Pavlina Date: Fri, 13 Jan 2017 21:31:35 -0500 Subject: [PATCH] Revert "Fixed a VIEW_ITEM memory leak" This reverts commit 9bc2bb26513dae023246e29ce62782de09140f74. Fixes: lp:1656481 (pcbnew segfault in KIGFX::VIEW_ITEM_DATA::getGroup) https://bugs.launchpad.net/kicad/+bug/1656481 --- common/view/view.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/common/view/view.cpp b/common/view/view.cpp index ad64f83e31..3508e5617e 100644 --- a/common/view/view.cpp +++ b/common/view/view.cpp @@ -360,8 +360,6 @@ void VIEW::Remove( VIEW_ITEM* aItem ) } viewData->deleteGroups(); - - delete aItem->m_viewPrivData; aItem->m_viewPrivData = nullptr; } @@ -908,14 +906,12 @@ void VIEW::draw( VIEW_ITEM* aItem, bool aImmediate ) } } - void VIEW::draw( VIEW_GROUP* aGroup, bool aImmediate ) { for( unsigned int i = 0; i < aGroup->GetSize(); i++) draw( aGroup->GetItem(i), aImmediate ); } - struct VIEW::unlinkItem { bool operator()( VIEW_ITEM* aItem )