From 9a4a68fb5eb5d0340431661059503f550ec26010 Mon Sep 17 00:00:00 2001
From: Jeff Young <jeff@rokeby.ie>
Date: Thu, 15 Sep 2022 23:22:59 +0100
Subject: [PATCH] Hide search button on MSW.

Fixes https://gitlab.com/kicad/code/kicad/issues/11743
---
 common/widgets/lib_tree.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/common/widgets/lib_tree.cpp b/common/widgets/lib_tree.cpp
index d1507be4ff..db549d9746 100644
--- a/common/widgets/lib_tree.cpp
+++ b/common/widgets/lib_tree.cpp
@@ -257,6 +257,12 @@ wxString LIB_TREE::GetSearchString() const
 
 void LIB_TREE::updateRecentSearchMenu()
 {
+#ifdef __WXMSW__
+    // Sadly there's a bug somewhere (presumably in wxWidgets, although possibly in the way we
+    // interact with wxWidgets) that causes the search button and drop-down menu to OK the dialog
+// on MSW, resulting in very unexpected behaviour.  #11743
+    m_query_ctrl->ShowSearchButton( false );
+#else
     wxString newEntry = GetSearchString();
 
     std::vector<wxString>& recents = g_recentSearches[ m_recentSearchesKey ];
@@ -281,6 +287,7 @@ void LIB_TREE::updateRecentSearchMenu()
         menu->Append( wxID_ANY, _( "recent searches" ) );
 
     m_query_ctrl->SetMenu( menu );
+#endif
 }