From 9c5aa82d2ca1faff7378b63db6a05ca7e541cdb0 Mon Sep 17 00:00:00 2001 From: jean-pierre charras Date: Sun, 23 Jul 2023 16:01:01 +0200 Subject: [PATCH] QA test: disable a DRC test that generate a wxWidgets exception, and is useless in this QA test --- qa/tests/pcbnew/drc/test_drc_regressions.cpp | 3 ++- qa/tests/pcbnew/test_tracks_cleaner.cpp | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/qa/tests/pcbnew/drc/test_drc_regressions.cpp b/qa/tests/pcbnew/drc/test_drc_regressions.cpp index 791086ec99..7996ca2f58 100644 --- a/qa/tests/pcbnew/drc/test_drc_regressions.cpp +++ b/qa/tests/pcbnew/drc/test_drc_regressions.cpp @@ -109,7 +109,8 @@ BOOST_FIXTURE_TEST_CASE( DRCFalsePositiveRegressions, DRC_REGRESSION_TEST_FIXTUR itemMap ) ); } - BOOST_ERROR( wxString::Format( "DRC regression: %s, failed", relPath ) ); + BOOST_ERROR( wxString::Format( "DRC regression: %s, failed (err: expected 0 found %d", + relPath, (int)violations.size() ) ); } } } diff --git a/qa/tests/pcbnew/test_tracks_cleaner.cpp b/qa/tests/pcbnew/test_tracks_cleaner.cpp index e6e0f08246..c378b3edf4 100644 --- a/qa/tests/pcbnew/test_tracks_cleaner.cpp +++ b/qa/tests/pcbnew/test_tracks_cleaner.cpp @@ -1,7 +1,7 @@ /* * This program source code file is part of KiCad, a free EDA CAD application. * - * Copyright (C) 2021-2022 KiCad Developers, see AUTHORS.txt for contributors. + * Copyright (C) 2021-2023 KiCad Developers, see AUTHORS.txt for contributors. * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -187,6 +187,9 @@ BOOST_FIXTURE_TEST_CASE( TrackCleanerRegressionTests, TRACK_CLEANER_TEST_FIXTURE bds.m_DRCSeverities[ DRCE_LIB_FOOTPRINT_MISMATCH ] = SEVERITY::RPT_SEVERITY_IGNORE; bds.m_DRCSeverities[ DRCE_COPPER_SLIVER ] = SEVERITY::RPT_SEVERITY_IGNORE; bds.m_DRCSeverities[ DRCE_STARVED_THERMAL ] = SEVERITY::RPT_SEVERITY_IGNORE; + // Also disable this test: for some reason it generate an exception inside this QA + // test ans it is useless + bds.m_DRCSeverities[ DRCE_SOLDERMASK_BRIDGE ] = SEVERITY::RPT_SEVERITY_IGNORE; bds.m_DRCEngine->SetViolationHandler( [&]( const std::shared_ptr& aItem, VECTOR2I aPos, int aLayer )