From a1ef5401f486befad4ad7ba5112ec01565d131e2 Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Tue, 30 Jan 2018 14:13:34 +0000 Subject: [PATCH] More platform-standard presentation of DRC dialog. Also makes better use of space to significantly increase number of markers shown. Fixes: lp:1748676 * https://bugs.launchpad.net/kicad/+bug/1748676 (cherry picked from commit a1d8097) --- eeschema/dialog_erc_listbox.h | 10 +- eeschema/drc_erc_item.cpp | 77 + include/drc_item.h | 72 +- pcbnew/dialogs/dialog_drc.cpp | 152 +- pcbnew/dialogs/dialog_drc.h | 10 +- pcbnew/dialogs/dialog_drc_base.cpp | 219 +- pcbnew/dialogs/dialog_drc_base.fbp | 4850 +++++++---------- pcbnew/dialogs/dialog_drc_base.h | 52 +- .../dialog_exchange_footprints_base.cpp | 2 +- .../dialog_exchange_footprints_base.fbp | 2 +- pcbnew/drc.cpp | 6 +- pcbnew/drc_item.cpp | 71 + 12 files changed, 2351 insertions(+), 3172 deletions(-) diff --git a/eeschema/dialog_erc_listbox.h b/eeschema/dialog_erc_listbox.h index 69b98c30d0..4a8a1e3a62 100644 --- a/eeschema/dialog_erc_listbox.h +++ b/eeschema/dialog_erc_listbox.h @@ -72,20 +72,18 @@ public: { wxString htmlpage; wxColour bgcolor = wxSystemSettings::GetColour( wxSYS_COLOUR_WINDOW ); - wxColour lncolor = wxSystemSettings::GetColour( wxSYS_COLOUR_HOTLIGHT ); wxColour fgcolor = wxSystemSettings::GetColour( wxSYS_COLOUR_WINDOWTEXT ); // for each marker, build a link like: // text to click // The "text to click" is the error name (first line of the full error text). wxString marker_text; + wxString href; for( unsigned ii = 0; ii < m_MarkerListReferences.size(); ii++ ) { - marker_text.Printf( wxT( "%s" ), - lncolor.GetAsString( wxC2S_HTML_SYNTAX ), - ii, - m_MarkerListReferences[ii]->GetReporter().ShowHtml() ); - marker_text.Replace( wxT( "