From a3a2f43f6c6b97d733cbefa34f180fdf05ea08ac Mon Sep 17 00:00:00 2001 From: jean-pierre charras Date: Tue, 21 Nov 2023 10:27:21 +0100 Subject: [PATCH] eeschema, DIALOG_PLOT_SCHEMATIC: disable PDF option when format is not PDF Fixes #16129 https://gitlab.com/kicad/code/kicad/-/issues/16129 --- eeschema/dialogs/dialog_plot_schematic.cpp | 1 + eeschema/dialogs/dialog_plot_schematic_base.cpp | 3 +-- eeschema/dialogs/dialog_plot_schematic_base.fbp | 2 +- eeschema/dialogs/dialog_plot_schematic_base.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/eeschema/dialogs/dialog_plot_schematic.cpp b/eeschema/dialogs/dialog_plot_schematic.cpp index 7c21f97a2b..c9659b8f99 100644 --- a/eeschema/dialogs/dialog_plot_schematic.cpp +++ b/eeschema/dialogs/dialog_plot_schematic.cpp @@ -268,6 +268,7 @@ void DIALOG_PLOT_SCHEMATIC::OnUpdateUI( wxUpdateUIEvent& event ) } m_openFileAfterPlot->Enable( fmt == PLOT_FORMAT::PDF ); + m_plotPDFPropertyPopups->Enable( fmt == PLOT_FORMAT::PDF ); m_paperSizeOption->Set( paperSizes ); m_paperSizeOption->SetSelection( selection ); diff --git a/eeschema/dialogs/dialog_plot_schematic_base.cpp b/eeschema/dialogs/dialog_plot_schematic_base.cpp index 96ea2dba15..88c51237be 100644 --- a/eeschema/dialogs/dialog_plot_schematic_base.cpp +++ b/eeschema/dialogs/dialog_plot_schematic_base.cpp @@ -1,5 +1,5 @@ /////////////////////////////////////////////////////////////////////////// -// C++ code generated with wxFormBuilder (version 3.10.1-0-g8feb16b) +// C++ code generated with wxFormBuilder (version 3.10.0-39-g3487c3cb) // http://www.wxformbuilder.org/ // // PLEASE DO *NOT* EDIT THIS FILE! @@ -170,7 +170,6 @@ DIALOG_PLOT_SCHEMATIC_BASE::DIALOG_PLOT_SCHEMATIC_BASE( wxWindow* parent, wxWind m_otherOptions = new wxStaticBoxSizer( new wxStaticBox( this, wxID_ANY, _("Other options") ), wxVERTICAL ); m_openFileAfterPlot = new wxCheckBox( m_otherOptions->GetStaticBox(), wxID_ANY, _("Open file after plot"), wxDefaultPosition, wxDefaultSize, 0 ); - m_openFileAfterPlot->Enable( false ); m_openFileAfterPlot->SetToolTip( _("Open output file with associated application after successful plot") ); m_otherOptions->Add( m_openFileAfterPlot, 0, wxBOTTOM|wxRIGHT|wxLEFT, 5 ); diff --git a/eeschema/dialogs/dialog_plot_schematic_base.fbp b/eeschema/dialogs/dialog_plot_schematic_base.fbp index 48efd5dda4..78dd49ec34 100644 --- a/eeschema/dialogs/dialog_plot_schematic_base.fbp +++ b/eeschema/dialogs/dialog_plot_schematic_base.fbp @@ -1585,7 +1585,7 @@ Dock 0 Left - 0 + 1 1 diff --git a/eeschema/dialogs/dialog_plot_schematic_base.h b/eeschema/dialogs/dialog_plot_schematic_base.h index 75e629b12e..7d01b0606b 100644 --- a/eeschema/dialogs/dialog_plot_schematic_base.h +++ b/eeschema/dialogs/dialog_plot_schematic_base.h @@ -1,5 +1,5 @@ /////////////////////////////////////////////////////////////////////////// -// C++ code generated with wxFormBuilder (version 3.10.1-0-g8feb16b) +// C++ code generated with wxFormBuilder (version 3.10.0-39-g3487c3cb) // http://www.wxformbuilder.org/ // // PLEASE DO *NOT* EDIT THIS FILE!