From b558366a4e8538d879728e75b8b2ba40e339bc8c Mon Sep 17 00:00:00 2001 From: jean-pierre charras Date: Sun, 17 Mar 2019 08:31:00 +0100 Subject: [PATCH] Pcbnew: disable commit 3692c511 on non Windows platforms A zone refill display progress bar is shown when deselecting the zone after geometry changes. However, on Linux, there are some artifact between the progress bar refresh and the board view refresh: the filled areas are incorrectly shown: the insulated islands remain displayed, although they are removed from the actual filled areas list So it is disabled until a fix is found. --- pcbnew/tools/point_editor.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pcbnew/tools/point_editor.cpp b/pcbnew/tools/point_editor.cpp index 63e532d54e..9411cf1dd2 100644 --- a/pcbnew/tools/point_editor.cpp +++ b/pcbnew/tools/point_editor.cpp @@ -644,8 +644,17 @@ void POINT_EDITOR::finishItem() if( zone->IsFilled() && m_refill && zone->NeedRefill() ) { ZONE_FILLER filler( board() ); + // A progress reporter can be usefull. However it works fine only on Windows + // so enable it only on Windows. + // On Linux, the filled areas are incorrectly shown: the insulated islands + // remain displayed, although they are removed from the actual filled areas list + // + // Fix me: try to make it working on Linux. + // + #ifdef __WINDOWS__ WX_PROGRESS_REPORTER reporter( getEditFrame(), _( "Refill Zones" ), 4 ); filler.SetProgressReporter( &reporter ); + #endif filler.Fill( { zone } ); } }