From ba6979a27484eb295381fca07b94050532da3bbf Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Tue, 16 Jan 2024 16:35:07 -0800 Subject: [PATCH] Fix pin check to allow for globals Don't short-circuit adding global labels to the pins vector or we won't search all subnets --- eeschema/connection_graph.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/eeschema/connection_graph.cpp b/eeschema/connection_graph.cpp index 48545d492f..31a85ae6b9 100644 --- a/eeschema/connection_graph.cpp +++ b/eeschema/connection_graph.cpp @@ -3388,11 +3388,8 @@ bool CONNECTION_GRAPH::ercCheckNoConnects( const CONNECTION_SUBGRAPH* aSubgraph { SCH_PIN* test_pin = static_cast( item ); - if( test_pin->GetParentSymbol()->IsPower() ) - continue; - // Stacked pins do not count as other connections but non-stacked pins do - if( !has_other_connections && !pins.empty() ) + if( !has_other_connections && !pins.empty() && !test_pin->GetParentSymbol()->IsPower() ) { for( SCH_PIN* other_pin : pins ) {