From c52fb23d4f1c44385f8a6efcf084dc6235a7dd1d Mon Sep 17 00:00:00 2001 From: Ian McInerney Date: Fri, 16 Jun 2023 00:07:54 +0100 Subject: [PATCH] PCM: Fix use of variable after it was moved into the cache --- kicad/pcm/pcm.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/kicad/pcm/pcm.cpp b/kicad/pcm/pcm.cpp index c14a250fd8..17bf2d9575 100644 --- a/kicad/pcm/pcm.cpp +++ b/kicad/pcm/pcm.cpp @@ -428,8 +428,9 @@ bool PLUGIN_CONTENT_MANAGER::CacheRepository( const wxString& aRepositoryId ) wxString url = std::get<2>( *repository_tuple ); - nlohmann::json js; - PCM_REPOSITORY current_repo; + nlohmann::json js; + PCM_REPOSITORY current_repo; + PCM_REPOSITORY& current_repo_ref = current_repo; std::shared_ptr reporter; @@ -522,12 +523,13 @@ bool PLUGIN_CONTENT_MANAGER::CacheRepository( const wxString& aRepositoryId ) packages_cache_stream << std::setw( 4 ) << js << std::endl; m_repository_cache[aRepositoryId] = std::move( current_repo ); + current_repo_ref = m_repository_cache[aRepositoryId]; } - if( current_repo.resources ) + if( current_repo_ref.resources ) { // Check resources file date, redownload if needed - PCM_RESOURCE_REFERENCE& resources = *current_repo.resources; + PCM_RESOURCE_REFERENCE& resources = *current_repo_ref.resources; wxFileName resource_file( repo_cache.GetPath(), wxT( "resources.zip" ) );