From ca5d95a62b393b9e170a682c623092d8d3e3437b Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Sat, 3 Sep 2022 21:47:52 +0100 Subject: [PATCH] Don't filter pins for conversion or unit. Symbol datastructure is used for all instances, and some instances may have different conversion and/or units than others. --- eeschema/sch_symbol.cpp | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/eeschema/sch_symbol.cpp b/eeschema/sch_symbol.cpp index 025eca9a25..0187008235 100644 --- a/eeschema/sch_symbol.cpp +++ b/eeschema/sch_symbol.cpp @@ -358,11 +358,8 @@ void SCH_SYMBOL::UpdatePins() { wxASSERT( libPin->Type() == LIB_PIN_T ); - //if( libPin->GetConvert() && m_convert && m_convert != libPin->GetConvert() ) - // continue; - - if( libPin->GetUnit() && m_unit && m_unit != libPin->GetUnit() ) - continue; + // NW: Don't filter by conversion or unit: this data-structure is used for all instances, + // some if which might have different conversions and/or units. m_pins.push_back( std::make_unique( libPin, this ) ); @@ -395,13 +392,7 @@ void SCH_SYMBOL::SetUnit( int aUnit ) void SCH_SYMBOL::UpdateUnit( int aUnit ) { - if( m_unit != aUnit ) - { - m_unit = aUnit; - - // The unit may have a different pins so the update the pin map. - UpdatePins(); - } + m_unit = aUnit; }