From d0fe2e06aa2837c556d7404d77bab4537ea3561a Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Thu, 11 Apr 2024 09:39:05 -0700 Subject: [PATCH] Do not set optional defaults In the file format, the 'mirror' tag is optional (not written unless on) so we cannot default the new text to 'mirror' on just because the footprint is on the back layer as it won't be turned off by the footprint loader. Fixes https://gitlab.com/kicad/code/kicad/-/issues/17546 --- pcbnew/pcb_text.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pcbnew/pcb_text.cpp b/pcbnew/pcb_text.cpp index c4347eaeb4..6c5d734f7c 100644 --- a/pcbnew/pcb_text.cpp +++ b/pcbnew/pcb_text.cpp @@ -69,11 +69,11 @@ PCB_TEXT::PCB_TEXT( FOOTPRINT* aParent, KICAD_T idtype) : { SetTextPos( aParent->GetPosition() ); + // N.B. Do not automatically set text effects + // These are optional in the file format and so need to be defaulted + // to off. if( IsBackLayer( aParent->GetLayer() ) ) - { SetLayer( B_SilkS ); - SetMirrored( true ); - } } }