From d25017dd5b1717608190909ca693b6d900a9ce35 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20W=C5=82ostowski?= Date: Thu, 1 Jun 2023 22:44:24 +0200 Subject: [PATCH] router: can't add a clone of a VIA's hole when adding the via to INDEX - this will result in bogus colliding objects This commit partially reverts deb3cbf8. VIA and SOLID operator='s introduced in it do a good job but the cloning of holes in addHole() causes bogus collisions. --- pcbnew/router/pns_node.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/pcbnew/router/pns_node.cpp b/pcbnew/router/pns_node.cpp index 3787210175..b7cdbafe4a 100644 --- a/pcbnew/router/pns_node.cpp +++ b/pcbnew/router/pns_node.cpp @@ -525,11 +525,8 @@ void NODE::addHole( HOLE* aHole ) // do we need holes in the connection graph? //linkJoint( aHole->Pos(), aHole->Layers(), aHole->Net(), aHole ); - HOLE* hole = new HOLE( aHole->Shape()->Clone() ); - hole->SetLayers( aHole->Layers() ); - - hole->SetOwner( this ); - m_index->Add( hole ); + aHole->SetOwner( this ); + m_index->Add( aHole ); }