From d738c91dd705c4b77b152f9584ed2f0c9a6fd5fe Mon Sep 17 00:00:00 2001 From: jean-pierre charras Date: Wed, 10 Feb 2021 12:47:11 +0100 Subject: [PATCH] minor fix in DIALOG_SYMBOL_PROPERTIES: make m_cbPreservePads ON the default Keep Through Hole pads on external layers should be ON by default, because such a pad does not allow soldering/unsoldering, if this option this option is OFF Also rename dialog_enum_pads.fbp as dialog_enum_pads_base.fbp, as usual --- pcbnew/dialogs/dialog_enum_pads_base.fbp | 710 +++++++++--------- pcbnew/dialogs/dialog_unused_pad_layers.cpp | 5 + ....fbp => dialog_unused_pad_layers_base.fbp} | 0 3 files changed, 360 insertions(+), 355 deletions(-) rename pcbnew/dialogs/{dialog_unused_pad_layers.fbp => dialog_unused_pad_layers_base.fbp} (100%) diff --git a/pcbnew/dialogs/dialog_enum_pads_base.fbp b/pcbnew/dialogs/dialog_enum_pads_base.fbp index faa0edb758..9233c4ac81 100644 --- a/pcbnew/dialogs/dialog_enum_pads_base.fbp +++ b/pcbnew/dialogs/dialog_enum_pads_base.fbp @@ -1,8 +1,8 @@ - + - + C++ 1 source_name @@ -16,9 +16,9 @@ none 1 DIALOG_ENUM_PADS_BASE - + . - + 1 1 1 @@ -29,67 +29,67 @@ 0 wxAUI_MGR_DEFAULT - + wxBOTH - + 1 1 impl_virtual - - - + + + 0 wxID_ANY - - + + DIALOG_ENUM_PADS_BASE - + -1,-1 wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER DIALOG_SHIM; dialog_shim.h Pad Enumeration Settings - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + bMainSizer wxVERTICAL none @@ -102,78 +102,78 @@ 1 1 1 - - - - - - - + + + + + + + 1 0 1 - + 1 0 Dock 0 Left 1 - + 1 - + 0 0 wxID_ANY Pad names are restricted to 4 characters (including number). - + 0 - - + + 0 - + 1 m_lblInfo 1 - - + + protected 1 - + Resizable 1 - - - + + + 0 - - - - + + + + -1 - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + @@ -194,9 +194,9 @@ 2 wxBOTH 1 - + 0 - + fgSizer wxFLEX_GROWMODE_SPECIFIED none @@ -211,78 +211,78 @@ 1 1 1 - - - - - - - + + + + + + + 1 0 1 - + 1 0 Dock 0 Left 1 - + 1 - + 0 0 wxID_ANY Pad name prefix: - + 0 - - + + 0 - + 1 m_lblPadPrefix 1 - - + + protected 1 - + Resizable 1 - - - + + + 0 - - - - + + + + -1 - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + @@ -294,86 +294,86 @@ 1 1 1 - - - - - - - + + + + + + + 1 0 1 - + 1 0 Dock 0 Left 1 - + 1 - + 0 0 wxID_ANY - + 0 - + 4 - + 0 - + 1 m_padPrefix 1 - - + + protected 1 - + Resizable 1 - - - + + + 0 - - + + wxFILTER_NONE wxDefaultValidator - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -385,78 +385,78 @@ 1 1 1 - - - - - - - + + + + + + + 1 0 1 - + 1 0 Dock 0 Left 1 - + 1 - + 0 0 wxID_ANY First pad number: - + 0 - - + + 0 - + 1 m_lblPadStartNum 1 - - + + protected 1 - + Resizable 1 - - - + + + 0 - - - - + + + + -1 - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + @@ -468,83 +468,83 @@ 1 1 1 - - - - - - - + + + + + + + 1 0 1 - + 1 0 Dock 0 Left 1 - + 1 - + 0 0 wxID_ANY 1 999 - + 0 - + 0 - + 0 - + 1 m_padStartNum 1 - - + + protected 1 - + Resizable 1 - + wxSP_ARROW_KEYS - + 0 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -558,76 +558,76 @@ 1 1 1 - - - - - - - + + + + + + + 1 0 1 - + 1 0 Dock 0 Left 1 - + 1 - + 0 0 wxID_ANY - + 0 - - + + 0 - + 1 m_staticline1 1 - - + + protected 1 - + Resizable 1 - + wxLI_HORIZONTAL - + 0 - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -643,17 +643,17 @@ 1 0 0 - + m_stdButtons protected - - - - - - - - + + + + + + + + diff --git a/pcbnew/dialogs/dialog_unused_pad_layers.cpp b/pcbnew/dialogs/dialog_unused_pad_layers.cpp index 1611f9365e..92d52c795a 100644 --- a/pcbnew/dialogs/dialog_unused_pad_layers.cpp +++ b/pcbnew/dialogs/dialog_unused_pad_layers.cpp @@ -56,6 +56,11 @@ DIALOG_UNUSED_PAD_LAYERS::DIALOG_UNUSED_PAD_LAYERS( PCB_BASE_FRAME* aParent, m_StdButtonsOK->SetDefault(); m_image->SetBitmap( KiBitmap( pads_remove_unused_xpm ) ); + // Set keep Through Hole pads on external layers ON by default. + // Because such a pad does not allow soldering/unsoldering, disable this option + // is probably not frequent + m_cbPreservePads->SetValue( true ); + // Now all widgets have the size fixed, call FinishDialogSettings finishDialogSettings(); } diff --git a/pcbnew/dialogs/dialog_unused_pad_layers.fbp b/pcbnew/dialogs/dialog_unused_pad_layers_base.fbp similarity index 100% rename from pcbnew/dialogs/dialog_unused_pad_layers.fbp rename to pcbnew/dialogs/dialog_unused_pad_layers_base.fbp