From d7f3a38510f5044e6b07e004644391a01ccfb1d3 Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Tue, 9 Jul 2019 13:06:20 +0100 Subject: [PATCH] If we're plotting small drill marks then we need to plot the pad even if the hole is the same size. Fixes: lp:1835617 * https://bugs.launchpad.net/kicad/+bug/1835617 --- pcbnew/plot_board_layers.cpp | 1 + pcbnew/plot_brditems_plotter.cpp | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pcbnew/plot_board_layers.cpp b/pcbnew/plot_board_layers.cpp index 2dafbb5208..2862b99a90 100644 --- a/pcbnew/plot_board_layers.cpp +++ b/pcbnew/plot_board_layers.cpp @@ -422,6 +422,7 @@ void PlotStandardLayer( BOARD *aBoard, PLOTTER* aPlotter, pad->SetSize( padPlotsSize ); if( aPlotOpt.GetSkipPlotNPTH_Pads() && + ( aPlotOpt.GetDrillMarksType() == PCB_PLOT_PARAMS::NO_DRILL_SHAPE ) && ( pad->GetSize() == pad->GetDrillSize() ) && ( pad->GetAttribute() == PAD_ATTRIB_HOLE_NOT_PLATED ) ) break; diff --git a/pcbnew/plot_brditems_plotter.cpp b/pcbnew/plot_brditems_plotter.cpp index 30daecd9bf..950614c255 100644 --- a/pcbnew/plot_brditems_plotter.cpp +++ b/pcbnew/plot_brditems_plotter.cpp @@ -86,8 +86,7 @@ void BRDITEMS_PLOTTER::PlotPad( D_PAD* aPad, COLOR4D aColor, EDA_DRAW_MODE_T aPl // Some pads are mechanical pads ( through hole or smd ) // when this is the case, they have no pad name and/or are not plated. // In this case gerber files have slightly different attributes. - if( aPad->GetAttribute() == PAD_ATTRIB_HOLE_NOT_PLATED || - aPad->GetName().IsEmpty() ) + if( aPad->GetAttribute() == PAD_ATTRIB_HOLE_NOT_PLATED || aPad->GetName().IsEmpty() ) gbr_metadata.m_NetlistMetadata.m_NotInNet = true; if( !isOnExternalCopperLayer || !isPadOnBoardTechLayers )