From df8eb5985488d15b1caee4b385b5f1723856acf7 Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Mon, 19 Dec 2022 11:03:00 +0000 Subject: [PATCH] Don't use SPICE_MODEL_SUBCKT::CreatePins to crate a default pinMap. (It creates a fully-unconnected map on the premise that it's easier to add a pinMap than to edit one. This is probably no longer true now that you don't have to un-assign a pin before re-assigning it.) --- eeschema/sim/sim_model.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/eeschema/sim/sim_model.cpp b/eeschema/sim/sim_model.cpp index 408ae16efe..d3742a17ae 100644 --- a/eeschema/sim/sim_model.cpp +++ b/eeschema/sim/sim_model.cpp @@ -1437,7 +1437,7 @@ void SIM_MODEL::MigrateSimModel( T_symbol& aSymbol, const PROJECT* aProject ) if( pinMap.IsEmpty() ) { // Generate a default pin map - model.model.CreatePins( sourcePins ); + model.model.SIM_MODEL::CreatePins( sourcePins ); pinMap = wxString( model.model.Serde().GeneratePins() ); } } @@ -1592,9 +1592,12 @@ void SIM_MODEL::MigrateSimModel( T_symbol& aSymbol, const PROJECT* aProject ) } } - T_field pinsField( &aSymbol, -1, SIM_MODEL::PINS_FIELD ); - pinsField.SetText( pinMap ); - aSymbol.AddField( pinsField ); + if( !pinMap.IsEmpty() ) + { + T_field pinsField( &aSymbol, -1, SIM_MODEL::PINS_FIELD ); + pinsField.SetText( pinMap ); + aSymbol.AddField( pinsField ); + } }