From e427099cff04128bef7594445d8d4d97590b91ff Mon Sep 17 00:00:00 2001 From: Jon Evans Date: Thu, 8 Feb 2024 18:46:30 -0500 Subject: [PATCH] Disable flaky ngspice tests These need to be re-done in a way that is more tolerant of the inherent instability/noise in the simulated circuits (or more ideally, changed to test a particular thing that can be more well-defined rather than just simulating a circuit and seeing if the numbers come out a certain way) --- qa/tests/eeschema/test_netlist_exporter_spice.cpp | 4 ++++ qa/tests/spice/test_netlist_exporter_spice.cpp | 4 ++++ qa/tests/spice/test_sim_regressions.cpp | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/qa/tests/eeschema/test_netlist_exporter_spice.cpp b/qa/tests/eeschema/test_netlist_exporter_spice.cpp index df508f24df..9acfca8439 100644 --- a/qa/tests/eeschema/test_netlist_exporter_spice.cpp +++ b/qa/tests/eeschema/test_netlist_exporter_spice.cpp @@ -195,6 +195,9 @@ BOOST_AUTO_TEST_CASE( Directives ) #endif +// This test is flaky and fails on ngspice-42 / Linux. +// Please replace it with something that is more stable +#if 0 BOOST_AUTO_TEST_CASE( LegacyLaserDriver ) { LOCALE_IO dummy; @@ -211,6 +214,7 @@ BOOST_AUTO_TEST_CASE( LegacyLaserDriver ) // Test D1 current after the pulse TestTranPoint( 150e-9, { { "I(D1)", 0 } } ); } +#endif BOOST_AUTO_TEST_CASE( LegacyPotentiometer ) diff --git a/qa/tests/spice/test_netlist_exporter_spice.cpp b/qa/tests/spice/test_netlist_exporter_spice.cpp index c11d1a73b1..3409734830 100644 --- a/qa/tests/spice/test_netlist_exporter_spice.cpp +++ b/qa/tests/spice/test_netlist_exporter_spice.cpp @@ -195,6 +195,9 @@ BOOST_AUTO_TEST_CASE( Directives ) #endif +// This test is flaky and fails on ngspice-42 / Linux. +// Please replace it with something that is more stable +#if 0 BOOST_AUTO_TEST_CASE( LegacyLaserDriver ) { LOCALE_IO dummy; @@ -211,6 +214,7 @@ BOOST_AUTO_TEST_CASE( LegacyLaserDriver ) // Test D1 current after the pulse TestTranPoint( 150e-9, { { "I(D1)", 0 } } ); } +#endif BOOST_AUTO_TEST_CASE( LegacyPspice ) diff --git a/qa/tests/spice/test_sim_regressions.cpp b/qa/tests/spice/test_sim_regressions.cpp index 03e95c41a8..f6646c93c7 100644 --- a/qa/tests/spice/test_sim_regressions.cpp +++ b/qa/tests/spice/test_sim_regressions.cpp @@ -111,6 +111,9 @@ BOOST_FIXTURE_TEST_CASE( ImmediateSBCKT, TEST_SIM_REGRESSIONS_FIXTURE ) } +// This test is flaky and fails on ngspice-42 / Linux. +// Please replace it with something that is more stable +#if 0 BOOST_FIXTURE_TEST_CASE( LegacyFixups, TEST_SIM_REGRESSIONS_FIXTURE ) { LOCALE_IO dummy; @@ -122,6 +125,7 @@ BOOST_FIXTURE_TEST_CASE( LegacyFixups, TEST_SIM_REGRESSIONS_FIXTURE ) TestTranPoint( 0.01, { { "V(out)", -0.060 } } ); TestTranPoint( 0.02, { { "V(out)", 0.856 } } ); } +#endif BOOST_FIXTURE_TEST_CASE( DualNMOSAmp, TEST_SIM_REGRESSIONS_FIXTURE )