From e85eec2e6b120f23cfdce3add99a04b4f30b9ea5 Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Sat, 14 Oct 2023 18:23:35 +0100 Subject: [PATCH] Don't leave deleted items in a group. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15797 (cherry picked from commit 14d5a404b2b0a3f3f4daaed75d32d3de51416f36) --- pcbnew/footprint_libraries_utils.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pcbnew/footprint_libraries_utils.cpp b/pcbnew/footprint_libraries_utils.cpp index 04c4459538..05160e883d 100644 --- a/pcbnew/footprint_libraries_utils.cpp +++ b/pcbnew/footprint_libraries_utils.cpp @@ -38,6 +38,7 @@ #include #include #include +#include #include #include #include @@ -764,7 +765,8 @@ void PCB_EDIT_FRAME::ExportFootprintsToLibrary( bool aStoreInNewLib, const wxStr pi->FootprintSave( libPath, fpCopy ); // Remove reference to the group before deleting - fpCopy->SetParentGroup( nullptr ); + if( PCB_GROUP* parentGroup = fpCopy->GetParentGroup() ) + parentGroup->RemoveItem( fpCopy ); delete fpCopy; }