From ec3158d03ab6c0b53da3557f27b52df89447b874 Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Sun, 23 Jun 2019 17:25:47 -0700 Subject: [PATCH] pcbnew: Don't clear module flags on revert The RebuildSelection routine now handles updating the selection based on flags. Fixes: lp:1831881 * https://bugs.launchpad.net/kicad/+bug/1831881 --- pcbnew/board_commit.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/pcbnew/board_commit.cpp b/pcbnew/board_commit.cpp index 52a08dfd7c..8d142796ce 100644 --- a/pcbnew/board_commit.cpp +++ b/pcbnew/board_commit.cpp @@ -357,14 +357,6 @@ void BOARD_COMMIT::Revert() item->SwapData( copy ); - // Update all pads/drawings/texts, as they become invalid - // for the VIEW after SwapData() called for modules - if( item->Type() == PCB_MODULE_T ) - { - MODULE* newModule = static_cast( item ); - newModule->RunOnChildren( std::bind( &EDA_ITEM::ClearFlags, _1, SELECTED ) ); - } - view->Add( item ); connectivity->Add( item ); delete copy;