From ec9e7eed9035445ea20ab7fccc0347581a8dd0f9 Mon Sep 17 00:00:00 2001
From: Seth Hillbrand <seth@kipro-pcb.com>
Date: Wed, 25 Jan 2023 13:53:21 -0800
Subject: [PATCH] Don't link DNP with Exclude from Pos files

Exclude from Pos file property follows the footprint but may be
different from the DNP property

Fixes https://gitlab.com/kicad/code/kicad/issues/13616
---
 .../netlist_reader/board_netlist_updater.cpp  | 40 -------------------
 1 file changed, 40 deletions(-)

diff --git a/pcbnew/netlist_reader/board_netlist_updater.cpp b/pcbnew/netlist_reader/board_netlist_updater.cpp
index c6154f2e1d..0b11981bf0 100644
--- a/pcbnew/netlist_reader/board_netlist_updater.cpp
+++ b/pcbnew/netlist_reader/board_netlist_updater.cpp
@@ -402,46 +402,6 @@ bool BOARD_NETLIST_UPDATER::updateFootprintParameters( FOOTPRINT* aPcbFootprint,
         m_reporter->Report( msg, RPT_SEVERITY_ACTION );
     }
 
-    if( ( aNetlistComponent->GetProperties().count( wxT( "dnp" ) ) > 0 )
-            != ( ( aPcbFootprint->GetAttributes() & FP_EXCLUDE_FROM_POS_FILES ) > 0 ) )
-    {
-        if( m_isDryRun )
-        {
-            if( aNetlistComponent->GetProperties().count( wxT( "dnp" ) ) )
-            {
-                msg.Printf( _( "Add %s 'exclude from position files' fabrication attribute." ),
-                            aPcbFootprint->GetReference() );
-            }
-            else
-            {
-                msg.Printf( _( "Remove %s 'exclude from position files' fabrication attribute." ),
-                            aPcbFootprint->GetReference() );
-            }
-        }
-        else
-        {
-            int attributes = aPcbFootprint->GetAttributes();
-
-            if( aNetlistComponent->GetProperties().count( wxT( "dnp" ) ) )
-            {
-                attributes |= FP_EXCLUDE_FROM_POS_FILES;
-                msg.Printf( _( "Added %s 'exclude from position files' fabrication attribute." ),
-                            aPcbFootprint->GetReference() );
-            }
-            else
-            {
-                attributes &= ~FP_EXCLUDE_FROM_POS_FILES;
-                msg.Printf( _( "Removed %s 'exclude from position files' fabrication attribute." ),
-                            aPcbFootprint->GetReference() );
-            }
-
-            changed = true;
-            aPcbFootprint->SetAttributes( attributes );
-        }
-
-        m_reporter->Report( msg, RPT_SEVERITY_ACTION );
-    }
-
     if( changed && copy )
         m_commit.Modified( aPcbFootprint, copy );
     else if( copy )