From eccadd92fb722de5226ad4ac16964e128766a517 Mon Sep 17 00:00:00 2001 From: John Beard Date: Sat, 27 Apr 2019 13:50:21 +0100 Subject: [PATCH] Eeschema: fix resizing of pin table and edit symbol dialog These dialogs had logic to avoid a table re-adjustment unless the width changed. This was done to avoid spurious resizing calls under GTK+3. This was commit 13249b723b5f3ef109b87f03dc07a6a3133ccd15, fixing bug lp:1817810. However, by only calling event.Skip() when the width changed, redraws were inhibited when only the height changed. Placing the Skip() outside the width-change check fixes this, and does not re-introduce the lp:1817810 bug (it is the column adjust call that causes that). Fixes: lp:1826615 * https://bugs.launchpad.net/kicad/+bug/1826615 --- eeschema/dialogs/dialog_edit_component_in_schematic.cpp | 4 +++- eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/eeschema/dialogs/dialog_edit_component_in_schematic.cpp b/eeschema/dialogs/dialog_edit_component_in_schematic.cpp index fc54dc3b86..6588eb3b88 100644 --- a/eeschema/dialogs/dialog_edit_component_in_schematic.cpp +++ b/eeschema/dialogs/dialog_edit_component_in_schematic.cpp @@ -725,8 +725,10 @@ void DIALOG_EDIT_COMPONENT_IN_SCHEMATIC::OnSizeGrid( wxSizeEvent& event ) if( m_width != new_size ) { AdjustGridColumns( new_size ); - event.Skip(); } + + // Always propagate for a grid repaint (needed if the height changes, as well as width) + event.Skip(); } diff --git a/eeschema/dialogs/dialog_lib_edit_pin_table.cpp b/eeschema/dialogs/dialog_lib_edit_pin_table.cpp index 175797f2d9..4ff5567cfb 100644 --- a/eeschema/dialogs/dialog_lib_edit_pin_table.cpp +++ b/eeschema/dialogs/dialog_lib_edit_pin_table.cpp @@ -650,8 +650,10 @@ void DIALOG_LIB_EDIT_PIN_TABLE::OnSize( wxSizeEvent& event ) if( m_initialized && m_width != new_size ) { adjustGridColumns( new_size ); - event.Skip(); } + + // Always propagate for a grid repaint (needed if the height changes, as well as width) + event.Skip(); }