From f6e33450ff807c5f90ca1f1484260c69399a38e4 Mon Sep 17 00:00:00 2001 From: jean-pierre charras Date: Wed, 11 Dec 2019 08:52:31 +0100 Subject: [PATCH] Gerber object attribute: avoid trying to guess if a SMD pad is a BGA pad. Previously, if a SMD pad was round, itb was seen as BGA pad. But this is not always true. so use always SMD PAD attribute, until an explicit BGA pad attribute is added in Pcbnew --- pcbnew/plot_brditems_plotter.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pcbnew/plot_brditems_plotter.cpp b/pcbnew/plot_brditems_plotter.cpp index e02211d109..c9bd6c1096 100644 --- a/pcbnew/plot_brditems_plotter.cpp +++ b/pcbnew/plot_brditems_plotter.cpp @@ -141,9 +141,11 @@ void BRDITEMS_PLOTTER::PlotPad( D_PAD* aPad, COLOR4D aColor, EDA_DRAW_MODE_T aPl break; case PAD_ATTRIB_SMD: // SMD pads (One external copper layer only) with solder paste - if( aPad->GetShape() == PAD_SHAPE_CIRCLE ) // perhaps a BGA pad - gbr_metadata.SetApertureAttrib( GBR_APERTURE_METADATA::GBR_APERTURE_ATTRIB_BGAPAD_CUDEF ); - else + // If round shape, perhaps a BGA pad but not sure: so use currently SMDPAD attribute, + // until an explicit BGA pad attribute is added in Pcbnew +// if( aPad->GetShape() == PAD_SHAPE_CIRCLE ) +// gbr_metadata.SetApertureAttrib( GBR_APERTURE_METADATA::GBR_APERTURE_ATTRIB_BGAPAD_CUDEF ); +// else gbr_metadata.SetApertureAttrib( GBR_APERTURE_METADATA::GBR_APERTURE_ATTRIB_SMDPAD_CUDEF ); break; }