From f846bc833be4359d1ea2d7f23e7ee0c6f7667c2d Mon Sep 17 00:00:00 2001
From: Jeff Young <jeff@rokeby.ie>
Date: Thu, 10 Nov 2022 13:46:50 +0000
Subject: [PATCH] Don't error out when enumeration of footprints fails.

We still want to load the ones that did enumerate.

Fixes https://gitlab.com/kicad/code/kicad/issues/12864
---
 pcbnew/footprint_info_impl.cpp | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/pcbnew/footprint_info_impl.cpp b/pcbnew/footprint_info_impl.cpp
index 3bf88e40fc..46decfd589 100644
--- a/pcbnew/footprint_info_impl.cpp
+++ b/pcbnew/footprint_info_impl.cpp
@@ -233,13 +233,11 @@ void FOOTPRINT_LIST_IMPL::loadFootprints()
 
                 wxArrayString fpnames;
 
-                if( !CatchErrors( [&]()
-                                  {
-                                      m_lib_table->FootprintEnumerate( fpnames, nickname, false );
-                                  } ) )
-                {
-                    return 0;
-                }
+                CatchErrors(
+                        [&]()
+                        {
+                            m_lib_table->FootprintEnumerate( fpnames, nickname, false );
+                        } );
 
                 for( wxString fpname : fpnames )
                 {
@@ -248,7 +246,7 @@ void FOOTPRINT_LIST_IMPL::loadFootprints()
                             {
                                 auto* fpinfo = new FOOTPRINT_INFO_IMPL( this, nickname, fpname );
                                 queue_parsed.move_push( std::unique_ptr<FOOTPRINT_INFO>( fpinfo ) );
-                            });
+                            } );
 
                     if( m_cancelled )
                         return 0;