From f9c83dbc44d5bc3cf00890ce1f1b51e6029b1cb4 Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Thu, 7 Oct 2021 11:29:51 -0700 Subject: [PATCH] Fix footprint type memory The flags don't map quite right, so we keep the memory of the drop-down and translate to flags. This protects against flag values changing --- pcbnew/footprint_libraries_utils.cpp | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/pcbnew/footprint_libraries_utils.cpp b/pcbnew/footprint_libraries_utils.cpp index c68b4d2718..df9ad8eb43 100644 --- a/pcbnew/footprint_libraries_utils.cpp +++ b/pcbnew/footprint_libraries_utils.cpp @@ -1127,6 +1127,7 @@ FOOTPRINT* PCB_BASE_FRAME::CreateNewFootprint( const wxString& aFootprintName, b // Static to store user preference for a session static int footprintType = 1; + int footprintTranslated = FP_SMD; // Ask for the new footprint name if( footprintName.IsEmpty() && !aQuiet ) @@ -1139,16 +1140,18 @@ FOOTPRINT* PCB_BASE_FRAME::CreateNewFootprint( const wxString& aFootprintName, b if( dlg.ShowModal() != wxID_OK ) return nullptr; //Aborted by user - switch( dlg.GetChoice() ) + footprintType = dlg.GetChoice(); + + switch( footprintType ) { case 0: - footprintType = FP_THROUGH_HOLE; + footprintTranslated = FP_THROUGH_HOLE; break; case 1: - footprintType = FP_SMD; + footprintTranslated = FP_SMD; break; default: - footprintType = 0; + footprintTranslated = 0; } } @@ -1172,7 +1175,7 @@ FOOTPRINT* PCB_BASE_FRAME::CreateNewFootprint( const wxString& aFootprintName, b // Update its name in lib footprint->SetFPID( LIB_ID( wxEmptyString, footprintName ) ); - footprint->SetAttributes( footprintType ); + footprint->SetAttributes( footprintTranslated ); PCB_LAYER_ID txt_layer; wxPoint default_pos;