From fb798a415060a620c187f26a7c67f4fd2b548ae8 Mon Sep 17 00:00:00 2001
From: Seth Hillbrand <seth@kipro-pcb.com>
Date: Tue, 28 Feb 2023 12:01:01 -0800
Subject: [PATCH] Export footprint pad holes to STEP regardless

Footprint pad holes form a part of the board outline regardless of
whether the footprint is in the BOM or not

Fixes https://gitlab.com/kicad/code/kicad/issues/14013

(cherry picked from commit daf70f9b6a7dec84b72cf027f8260763f19a61d5)
---
 pcbnew/exporters/step/exporter_step.cpp | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/pcbnew/exporters/step/exporter_step.cpp b/pcbnew/exporters/step/exporter_step.cpp
index e4e0631fb9..7da90374c0 100644
--- a/pcbnew/exporters/step/exporter_step.cpp
+++ b/pcbnew/exporters/step/exporter_step.cpp
@@ -138,6 +138,13 @@ bool EXPORTER_STEP::composePCB( FOOTPRINT* aFootprint, VECTOR2D aOrigin )
 {
     bool hasdata = false;
 
+    // Dump the pad holes into the PCB
+    for( PAD* pad : aFootprint->Pads() )
+    {
+        if( m_pcbModel->AddPadHole( pad, aOrigin ) )
+            hasdata = true;
+    }
+
     if( ( aFootprint->GetAttributes() & FP_EXCLUDE_FROM_BOM ) && !m_params.m_includeExcludedBom )
     {
         return hasdata;
@@ -168,13 +175,6 @@ bool EXPORTER_STEP::composePCB( FOOTPRINT* aFootprint, VECTOR2D aOrigin )
         }
     }
 
-    // Dump the pad holes into the PCB
-    for( PAD* pad : aFootprint->Pads() )
-    {
-        if( m_pcbModel->AddPadHole( pad, aOrigin ) )
-            hasdata = true;
-    }
-
     // Exit early if we don't want to include footprint models
     if( m_params.m_boardOnly )
     {
@@ -389,4 +389,4 @@ bool EXPORTER_STEP::Export()
     }
 
     return true;
-}
\ No newline at end of file
+}