From fb8dc75108d2eb2a997418657f1d0e82b5156026 Mon Sep 17 00:00:00 2001 From: Marek Roszko Date: Sun, 21 Jan 2024 19:53:35 -0500 Subject: [PATCH] Fix broken conditional check while walking global power connected items Per the if statement and logic, we want to walk into looking up connections if we are a pin on a chip. IsGlobalPower is a test for it's in a power symbol, so we want it false not true. Fixes https://gitlab.com/kicad/code/kicad/-/issues/16699 --- eeschema/connection_graph.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eeschema/connection_graph.cpp b/eeschema/connection_graph.cpp index 31a85ae6b9..28776e93c1 100644 --- a/eeschema/connection_graph.cpp +++ b/eeschema/connection_graph.cpp @@ -3432,7 +3432,7 @@ bool CONNECTION_GRAPH::ercCheckNoConnects( const CONNECTION_SUBGRAPH* aSubgraph // We want to throw unconnected errors for power symbols even if they are connected to other // net items by name, because usually failing to connect them graphically is a mistake if( pin && !has_other_connections - && pin->IsGlobalPower() + && !pin->IsGlobalPower() && !pin->GetLibPin()->GetParent()->IsPower() ) { wxString name = pin->Connection( &sheet )->Name();