From ffc28f23e5b3c5365c1454b47065df76cc14fc91 Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Tue, 19 Apr 2022 19:19:47 +0100 Subject: [PATCH] Repair GetFullRef() and use it when running Symbol Fields Table filtering. (Previously GetFullRef() failed to add the number between the prefix letter and the unit designator.) Fixes https://gitlab.com/kicad/code/kicad/issues/11419 --- eeschema/dialogs/dialog_symbol_fields_table.cpp | 2 +- eeschema/sch_reference_list.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/eeschema/dialogs/dialog_symbol_fields_table.cpp b/eeschema/dialogs/dialog_symbol_fields_table.cpp index e1418f8542..3b07bd016e 100644 --- a/eeschema/dialogs/dialog_symbol_fields_table.cpp +++ b/eeschema/dialogs/dialog_symbol_fields_table.cpp @@ -490,7 +490,7 @@ public: SCH_REFERENCE ref = m_symbolsList[ i ]; if( !aFilter->GetValue().IsEmpty() - && !WildCompareString( aFilter->GetValue(), ref.GetRef(), false ) ) + && !WildCompareString( aFilter->GetValue(), ref.GetFullRef(), false ) ) { continue; } diff --git a/eeschema/sch_reference_list.h b/eeschema/sch_reference_list.h index 873fa737a8..c6cfacdbb6 100644 --- a/eeschema/sch_reference_list.h +++ b/eeschema/sch_reference_list.h @@ -107,9 +107,9 @@ public: wxString GetFullRef() const { if( GetSymbol()->GetUnitCount() > 1 ) - return GetRef() + LIB_SYMBOL::SubReference( GetUnit() ); + return GetRef() + GetRefNumber() + LIB_SYMBOL::SubReference( GetUnit() ); else - return GetRef(); + return GetRef() + GetRefNumber(); } wxString GetRefNumber() const