Jeff Young
eae85742cc
Don't report reasonable solder mask bridges in a net-tie footprint.
2024-06-15 15:57:13 +01:00
Jon Evans
fa235116f7
Import Altium via tenting settings
2024-06-15 09:36:25 -04:00
jean-pierre charras
16e708a0e7
Fix minor compil and Coverity warnings.
2024-06-15 11:20:21 +02:00
Seth Hillbrand
7ea013b96c
Altium: Handle footprint vias
...
These are treated as pads in KiCad
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18194
2024-06-14 16:49:56 -07:00
Seth Hillbrand
021f251efd
Tented usually means that there is no soldermask
...
Probably was a typo
2024-06-14 16:49:56 -07:00
Seth Hillbrand
d21eba4021
Unselected tree before syncing
...
On GTK, the selected item is checked for its parent when being
unselected. This breaks if the parent has been removed by the Sync()
call, so we need to ensure that the unselect all call happens prior
2024-06-14 16:49:56 -07:00
Jeff Young
db9f0a0358
Report footprint parent of shape when in board editor.
...
While the user can't select these, we do report them
in DRC messages and the like, where it's handy to
know what they're from.
2024-06-14 23:19:26 +01:00
Jeff Young
8cddd40fc9
Check mask apertures on the mask layer.
...
(Otherwise testing A:B and B:A will add items to the
m_maskApertureNetMap cache on different layers.)
2024-06-14 22:55:40 +01:00
Jeff Young
b2588e0bbf
Footprint Editor doesn't have nets.
...
(Copper shapes, on the other hand, can. Since we use
GetItemDescription() to report DRC errors and the like,
it's better to have it report the net even when it's
<no net>.)
2024-06-14 22:46:29 +01:00
Jeff Young
7fef6e8d83
Use view's RTree for redrawing netnames.
2024-06-14 00:20:37 +01:00
Jeff Young
c9ddcd618d
Make sure to reset the cached viewport.
2024-06-12 23:35:06 +01:00
Jon Evans
ccc76aad2f
Fix typo loading legacy tenting setting
2024-06-12 17:42:44 -04:00
Alex Shvartzkop
44a33eedf4
Update only visible track segments in redrawNetnames.
...
RequestRefresh doesn't seem to be needed.
2024-06-13 00:28:37 +03:00
Alex Shvartzkop
f0e9f9f15a
Optimize PAD LoD calculation.
2024-06-12 23:05:33 +03:00
Alex Shvartzkop
52daf14c78
Optimize VIA LoD calculation.
2024-06-12 23:05:33 +03:00
Jeff Young
0ca7a81181
Deferred redraw for netnames.
2024-06-12 17:20:20 +01:00
Jeff Young
b7161181e8
Hidden footprint libraries are not yet supported.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18183
2024-06-12 16:59:20 +01:00
Jeff Young
694a7db457
Performance improvements.
...
Don't construct a wxString or a LSEQ when you don't
have to. They're both more expensive than you might
think.
2024-06-12 11:06:10 +01:00
Jon Evans
63cd110720
Make verbiage more clear
2024-06-11 22:19:33 -04:00
Jon Evans
896f56772f
Fix warnings
2024-06-11 22:01:06 -04:00
Jon Evans
5fc0f1f51e
ADDED: Independent control of front/back via tenting
2024-06-11 21:50:25 -04:00
Jon Evans
4aab9f59aa
ADDED: Support tenting control of individual vias
...
REMOVED: Tenting option from plot dialog (tenting is now
controlled from Board Setup and via properties)
See https://gitlab.com/kicad/code/kicad/-/issues/2402
2024-06-11 21:25:02 -04:00
Jeff Young
d865bda4f2
Cache display netnames.
...
Also changes the redraw behaviour to not try and redraw
only when things entered the view (this didn't work
because it may be the netname that's entering the view,
not the whole track). Instead we only process a finite
number of tracks on each idle event (in order to avoid
#12436 ).
Note that we don't need the timer at all anymore as the
netnames are in fixed locations on the track and never
make the track look like it's being dragged.
Also improves performance by avoiding sqrt.
2024-06-11 16:30:52 +01:00
jean-pierre charras
9bf0b479ed
fix a compil issue on msys2
2024-06-11 10:58:21 +02:00
Alex Shvartzkop
44fd13af47
Slight optimization for PCB_PAINTER when drawing vias/tracks.
2024-06-11 05:30:02 +03:00
Wayne Stambaugh
012d3f098f
Fix build error caused by commit 82c2bda52b
.
2024-06-10 10:56:02 -04:00
Alex Shvartzkop
0d2838518b
Altium PCB import: don't add thickness to Solid style fills.
...
(cherry picked from commit b34dbf58c5
)
2024-06-10 17:33:26 +03:00
Alex Shvartzkop
82c2bda52b
Altium PCB import: make sure Polygon fill is contained within the outline.
2024-06-10 17:21:41 +03:00
Alex Shvartzkop
43dab2a8b5
Altium PCB import: avoid integer overflows when rotating rectangular fills.
...
Fixes artifacts seen in https://gitlab.com/kicad/code/kicad/-/issues/18156
(cherry picked from commit 3ea314cb9f
)
2024-06-10 01:01:32 +03:00
Jeff Young
ca54eb422b
Don't default KeepUpright to true in Eagle importer.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18175
2024-06-09 22:19:26 +01:00
Alex Shvartzkop
80b7f5fcbf
Revert "Pcbnew, Altium import: Fix issues with hatched zones."
...
This removed the hatch fill import functionality,
and is no longer needed now that the root cause was found.
This reverts commit 616510aca2
.
2024-06-09 20:04:27 +03:00
jean-pierre charras
fb3730a9c0
STEP export: fix missing zones (they were added too late in code)
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18177
2024-06-09 17:32:34 +02:00
Jon Evans
3bb7b3722c
Fix MSVC not understanding operator== anymore
2024-06-08 17:27:34 -04:00
Jon Evans
f5e7c705db
Move custom shapes to PADSTACK; support in API
2024-06-08 14:26:36 -04:00
Jeff Young
ed0869aa0c
Share more library tree code.
2024-06-08 19:06:10 +01:00
Jeff Young
90652a741d
Don't generate thermal reliefs for pads that don't intersect zone.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18174
2024-06-07 23:08:15 +01:00
Seth Hillbrand
ff188450e6
Handle degenerate arcs
...
Arcs with their centers too far away are effectively straight lines, so
draw them as such
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18170
2024-06-07 11:28:34 -07:00
jean-pierre charras
616510aca2
Pcbnew, Altium import: Fix issues with hatched zones.
...
- Filled zones using the hatch pattern cannot use the primitives from Altium.
the filled shapes must be rebuilt.
_ Filled zones using the hatch pattern with a very small gap are now converted
to a polygon pattern. Otherwise the calculation time can be very big.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18156
2024-06-06 16:37:28 +02:00
Jeff Young
9b8f1109e6
Formatting.
2024-06-06 11:41:37 +01:00
Mike Williams
f3d2f4af01
PCB: add fields checkbox to Edit Text and Graphics
...
Also add missing saves for dimensions checkboxes.
2024-06-05 11:50:17 -04:00
Jeff Young
9fb07d886e
PCB_GENERATOR_Ts are PCB_GROUP_Ts too.
...
Also, an item must already be in a commit to add it to a group.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17595
2024-06-05 10:51:24 +01:00
Marek Roszko
944835eefc
Add PCB_VIA equality operator overload
2024-06-04 21:34:14 -04:00
Jon Evans
0b0a37aaf7
Move padstack serialization to PADSTACK
...
Also move a few more things from pad/via
2024-06-04 09:28:24 -04:00
Jeff Young
855c972156
Add regression test and example rule.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18142
2024-06-04 10:58:52 +01:00
dsa-t
bc3ae8ca51
Don't construct an arc if we won't need it in pcbnew gfx importer.
...
(cherry picked from commit d34df3e951
)
Co-authored-by: Alex Shvartzkop <dudesuchamazing@gmail.com>
2024-06-04 04:21:06 +00:00
Jeff Young
18e33a0957
Check drilled holes against other holes, even if laser burned.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18142
2024-06-03 21:53:37 +01:00
Frank Muenstermann
63d828d5ff
kicad-cli: The --precision parameter was not recognized, if unit was inch, the export crashed
2024-06-03 09:03:57 +00:00
Jeff Young
efd3cb115b
Update Zone Manager for look & feel and coding stds.
2024-06-02 17:41:54 +01:00
Jeff Young
86d7cf5d96
Formatting.
2024-06-02 10:52:18 +01:00
Sven Pauli
c7ad5efbed
Implemented flip for tuning patterns.
2024-06-02 09:49:41 +00:00
Jeff Young
dc8fd0996d
Don't attempt to plot rule areas.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18133
2024-06-01 19:17:05 +01:00
Jeff Young
53ec5d2c19
Retain UUIDs where possible when updating footprints.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17451
2024-06-01 13:45:15 +01:00
Seth Hillbrand
ae232054f7
Revert "Remove unneeded != operator"
...
MSVC errors when we don't keep this operator.
This reverts commit c6499cf5db
.
2024-05-31 17:38:45 -07:00
Seth Hillbrand
e8c96a8a20
Fixups for a9ae86ee
...
Correcting a couple mistakes and clarifying rounding
2024-05-31 17:31:50 -07:00
Marek Roszko
8b4253cda4
Drop the first point of an arc when building an outline when there's a previous point that's being changed
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18125
2024-05-31 18:40:16 -04:00
Jeff Young
5d62345cbd
ADDED checkbox to turn Margin layer on/off.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12493
2024-05-31 22:08:40 +01:00
Seth Hillbrand
c6499cf5db
Remove unneeded != operator
...
C++20 defines these implicitly
2024-05-31 13:29:34 -07:00
Seth Hillbrand
a9ae86eefd
Cleanup geometry functions
...
Added Distance(VECTOR2) function that returns a double. Removed
superfluous EuclideanNorm, GetLineLength, integer constructor for
EDA_ANGLE (this promotes to double in the CTOR), DistanceLinePoint and
HitTestPoints
Also extended the size for arc calculations that get distances to center
points to avoid overflow
2024-05-31 12:26:37 -07:00
Jeff Young
931de12072
Use wxWidgets to track DPI.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17981
2024-05-31 17:08:43 +01:00
Jeff Young
e3f77cd410
Handle DPI_CHANGED events for 3D canvases.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17981
2024-05-31 17:08:43 +01:00
Jeff Young
3cc653b6ff
Revert DPI-change fix.
...
(Jon has a better one coming.)
2024-05-31 15:46:01 +01:00
Jeff Young
f907b58d17
Handle DPI-change for footprint 3D-previews in Footprint Chooser.
2024-05-31 13:48:44 +01:00
Jeff Young
f3d5d4afdd
Formatting.
2024-05-31 12:35:17 +01:00
Jeff Young
3be6d5c5de
Setup 3D canvas for Footprint Chooser previews.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17910
2024-05-31 12:33:32 +01:00
Jeff Young
6f0a1ade01
Don't add things to the selection that aren't in the commit.
...
Don't process line-pairs when one has already been deleted.
Clean up created line segments when operation is cancelled.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18122
2024-05-31 11:49:24 +01:00
Jeff Young
b567e4d521
Silently interpret 0 as cancel.
...
No need to interrupt the user's workflow.
2024-05-31 10:54:07 +01:00
Jeff Young
c60796aa4f
Formatting.
2024-05-31 10:46:34 +01:00
Jeff Young
7151f9a131
Formatting.
2024-05-31 10:36:51 +01:00
Jeff Young
1eb26b439a
REMOVED new footprint dialog.
...
We now just create an "Untitled" footprint.
Also fixes a bug where the preview of new footprints
would zoom in too far.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17573
2024-05-31 10:36:51 +01:00
Seth Hillbrand
015b93b474
Fixup arc check in dp coupled
...
Handle arcs starting at candidate end point.
Fix total arc size
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17967
2024-05-30 22:45:33 -07:00
Seth Hillbrand
75ab3d9e8b
Handle arcs dp coupling
...
Calculate coupled arcs and spacing
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17967
2024-05-30 16:11:12 -07:00
Seth Hillbrand
bffbdad9c0
Cleanup track comps
2024-05-30 14:21:51 -07:00
jean-pierre charras
1c9e96c89a
do not flag an empty string as translatable.
2024-05-30 15:50:32 +02:00
Jeff Young
652c1d4006
Formatting.
2024-05-30 13:12:53 +01:00
Jeff Young
c0635f222d
Apply ExportPdf fix to remaining jobs.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17863
2024-05-30 09:19:23 +01:00
Jeff Young
3cf424d929
Make sure var overrides get synced to board properties.
...
Also allow the board properties to override title-block properties.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17863
2024-05-30 00:09:43 +01:00
Jeff Young
15d4e114e0
Move pad checking to Footprint Checker.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18102
2024-05-29 15:25:49 +01:00
Mike Williams
a8daa38e83
pcb: grab unconnected needs to ignore same-footprint ratsnets items
2024-05-28 16:46:53 -04:00
jean-pierre charras
8165ec66e9
FOOTPRINT::CheckPads(): better check for hole in PHT pad.
...
Hole not fully inside the pad copper area is now tested.
2024-05-28 20:00:08 +02:00
Jeff Young
f7b971ecb7
Setup Footprint-Editor-specific severities.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18102
2024-05-28 18:11:25 +01:00
Alex Shvartzkop
139d356065
Fix scale factors of layer box selectors.
2024-05-28 18:52:03 +03:00
Jeff Young
bab97f91cc
Tidy up string find API usages.
2024-05-28 15:30:29 +01:00
Jeff Young
11b72c294b
ADDED: expose plot-pad-numbers in plot dialog.
2024-05-28 15:30:29 +01:00
jean-pierre charras
68fa45dea0
Pcbnew, plot drill marks: fix incorrect plot drill mark in some cases.
...
If a non copper layers is added to a copper layer for plot with drill marks,
the drill mark was not visible (covered by shapes plotted from non copper layer).
Now copper layers are plotted after the non copper layers.
2024-05-28 09:52:30 +02:00
Jeff Young
b88d3b13ac
ADDED: sketch-pads-on-fab-layers to CLI PDF & SVG export.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18091
2024-05-27 20:59:11 +01:00
Seth Hillbrand
54efd32f7a
Ensure nets are referenced to main board
...
We set new elements to the temporary board's netlist. These need to be
updated when moving the fooprint to the main board
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17242
2024-05-27 11:30:43 -07:00
Jeff Young
4901ffd935
Formatting.
2024-05-27 17:06:09 +01:00
Seth Hillbrand
9c24a39156
Handle 2581 knockout text with multiple outlines
...
Previous commit removed the handling of multiple outlines. This
restores Jeff's initial, correct handling, only minus the "UserSpecial"
nest
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18042
2024-05-27 07:29:52 -07:00
Jeff Young
f3b57c20af
Trim trailing punctionation from doc URLs.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18089
2024-05-27 14:17:13 +01:00
Jeff Young
bc14a841cb
Check for drilled hole errors in Footprint Checker.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18093
2024-05-27 13:51:21 +01:00
Jeff Young
2925d63c44
Formatting.
2024-05-27 13:04:20 +01:00
Alex Shvartzkop
d451d2f548
Make board stackup page usable on hidpi.
2024-05-27 01:44:42 +03:00
Alex Shvartzkop
284cda1fca
Improve copper zone dialog layer list checkbox alignment on hidpi.
2024-05-27 01:02:12 +03:00
Alex Shvartzkop
07470efc0b
Autosize bitmap buttons in wxFB.
2024-05-27 00:12:55 +03:00
Jeff Young
e400d49af6
Trim covered region to bounding hull.
...
Otherwise a long track crossing a footprint will look
like it covers most of it.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17299
2024-05-26 18:45:58 +01:00
Seth Hillbrand
becc0232b4
Fixup IPC2581 knockout text
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18042
2024-05-26 08:04:06 -07:00
Jeff Young
aeadec40b7
Select starting track items before expanding selection.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17432
2024-05-26 15:23:31 +01:00
Jeff Young
30b5adde17
Fix spacing/scaling of indicators on MacOS.
...
Also pushes indicator scaling improvements to GerbView.
2024-05-26 14:37:05 +01:00
Alex Shvartzkop
e55da55e04
Remove debugging code from STEP exporter.
2024-05-26 08:05:25 +03:00
Alex Shvartzkop
1ae9749429
Use bitmap bundle for auto track width button.
2024-05-26 03:56:58 +03:00