haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
42,498 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

702 Commits

Author SHA1 Message Date
JamesJ f8434b1c07 Fix deletion of items in pcbnew 
Ensures the fallthrough generic deletion code path increments
the deleted items counter.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/17798
 2024-04-18 23:37:37 +01:00
Jeff Young a4073c2ace Provide some user hints on editing fields. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17781
 2024-04-17 18:30:37 +01:00
JamesJ 79a3dd71e4 Only delete grouped / generated BOARD_ITEMS from the root item 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17527

This is required as during an undo / redo operation, rebuilding
the previous selection can result in a group / generator being
selected as well as all of their contained items. This prunes
the contained items to remove the possibility of a double-delete.
 2024-03-30 14:20:06 +00:00
Jeff Young 63b06095e6 Table selections for PCBNew. 2024-03-09 22:18:19 +00:00
Jeff Young 20efeef5ae Apply anti-walk algorithm only to textboxes. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16481
 2024-03-06 13:51:27 +00:00
Seth Hillbrand 6a8d2a7eb3 Store group id rather than group 
We only need the group storage id for lookup.  Storing the KIID instead
of a copy of the group avoids unneeded overhead

Fixes https://gitlab.com/kicad/code/kicad/-/issues/17175

(cherry picked from commit 7d1adff071)
 2024-02-28 13:27:38 -08:00
Jeff Young fa0ead98d8 Split out table editing and table cell editing. 2024-02-24 20:05:51 +00:00
Jeff Young e445249720 ADDED: PCB tables. 2024-02-24 20:05:51 +00:00
Jeff Young 4a9df1e18e ADDED: actions for left-, center-, and right-justifying text items. 
(For both PCBNew and EESchema.)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12375
 2024-02-24 20:05:50 +00:00
Jeff Young e68cd04d48 Don't modify reference point if already moving. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16524

(cherry picked from commit 08da9a4494)
 2024-02-23 16:53:32 +01:00
Alex Shvartzkop ed712faf41 Disallow duplicating tuning patterns alone. 2024-02-20 03:20:08 +00:00
Jeff Young 97cb15dd47 Make sub menus conditional on them having child items. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16631
 2024-01-18 00:21:15 +00:00
jean-pierre charras 76bd892f93 Fix not working Duplicate command in FP editor 
Fixes #16594
https://gitlab.com/kicad/code/kicad/-/issues/16594
 2024-01-16 16:30:55 +01:00
Jeff Young cd83dfa831 Stage/add/delete group members when adding/deleting group. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16540
 2024-01-07 13:39:13 +00:00
Jeff Young 0b526cca15 Delete tracks when deleting tuning pattern as part of sel. 2024-01-02 18:00:25 +00:00
Jeff Young 3f73bbcc4f Don't run keepUpright when not rotating. 
For that matter, don't do anything at all for a rotation
of 0 (or a move vector of {0,0}).

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16402
 2023-12-22 21:22:36 +00:00
Jon Evans b1695add9e Fix warnings 2023-12-19 22:38:34 -05:00
Jeff Young 1b0cc82c56 Move a couple of stragglers to BOARD_COMMIT. 2023-12-17 21:01:31 +00:00
Ian McInerney 3c0566d318 Don't allow copying markers 
Fixes KICAD-5FQ
 2023-12-11 22:22:19 +00:00
Jeff Young 6e245d5eb4 Remove special cases for footprint editor. BOARD_COMMIT handles them. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16236
 2023-12-02 20:06:57 +00:00
Jon Evans 1cb1fd3516 Partial revert "Fix commit/view handling when dragging arcs" 
Revert unintended formatting changes

This reverts commit f0988c3c5d.
 2023-11-25 15:16:57 -05:00
Jon Evans f0988c3c5d Fix commit/view handling when dragging arcs 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16145
 2023-11-25 14:55:47 -05:00
Jeff Young 7e46e85c7d Update copyrights. 2023-11-11 15:29:34 +00:00
Jeff Young 3e58425671 Flip rotation angle when board view is flipped. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15954
 2023-11-10 22:30:06 +00:00
Jeff Young cc721c4907 Improve encapsulation of group internals. 
(It's still leaking into BOARD_COMMIT and some other places, but at
least it no longer leaks into all the edit tools.)

Also fixes some bugs when moving/copying/pasting multiple selections
containing length-tuning patterns.
 2023-11-09 14:05:35 +00:00
Jeff Young 7788c8f21c Fix textbox mirroring and rotation (again). 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15576

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14159

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14912

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14178
 2023-11-06 14:03:58 +00:00
Jeff Young fc0017fc95 Normalize rects higher up. 
We don't want to normalize footprint children to their board-relative
coordinates.
 2023-10-29 11:45:16 +00:00
Jeff Young 791aa64950 Functionally it's a "reference image". 
The implementation happens to be a "bitmap".

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15932
 2023-10-24 15:44:21 +01:00
Jeff Young ad676e22b8 Don't push a commit we don't own. 2023-10-22 20:35:14 +01:00
Jeff Young 68a5753c80 Repair Rotate on PCB_GENERATOR items. 2023-10-19 23:34:52 +01:00
Alex Shvartzkop be1008cbd8 ADDED: Heal Shapes; Fix discontinuities in gfx import and Cleanup dialog. 2023-10-17 10:29:43 +03:00
Jeff Young 2bc273f8bc Don't fire event-parameter asserts when looking for a click event. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/KICAD-2CK
 2023-10-13 20:31:01 +01:00
Alex Shvartzkop be72e07e61 Introduce PCB_GENERATOR. 2023-10-08 02:41:17 +00:00
John Beard 311f041421 ADDED: Polygon boolean operations in PCB editor 
This allows common operations like merging a pin courtyard
into the body courtyard in the fooprint editor, taking a
"bite" out of a polygon and so on,

For now, this only supports polygons made of straight lines.

There are some wierd cases when the operations result in nothing
(e.g. wen a big polygon is substracted from a smaller one that
it contains entirely). I have tried to do something senisble in
these cases, but there may be more optimal ways to handle it.

Relates-To: https://gitlab.com/kicad/code/kicad/-/issues/13025
 2023-10-01 00:10:10 +01:00
John Beard b6cd7e3b4a Make ITEM_MODIFICATION_ROUTINE status messages more general and easier to call 2023-10-01 00:10:10 +01:00
Alex Shvartzkop 06463fd35a Fixes for Wayland cursor warping: 
- Emulate the mouse position, since no motion events are sent after warp
- Do not call wl_surface_commit to prevent an assert
- Re-organize code a bit
 2023-09-18 12:56:54 +00:00
Jeff Young 899fe8be17 Fix change footprints dialog to use correct selection state. 2023-09-11 22:05:20 +01:00
jean-pierre charras 8aa408f0c9 fix a minor compil warning 
fix a typo in translatable string.
 2023-09-07 20:00:29 +02:00
Jeff Young d3e255a383 Allow context-menu update/change footprint for multiple footprints. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15595
 2023-09-07 17:51:18 +01:00
Josue Huaroto cef0f176d3
Add Unselect all in menu 2023-09-06 23:44:39 +00:00
Jeff Young 9bba8e5956 Don't allow duplication of footprint items outside of footprint editor. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15487
 2023-09-03 22:04:50 +01:00
Jeff Young 624203f2e1 Don't start a router drag when already in an EDIT_TOOL drag or move. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15312
 2023-09-03 14:03:52 +01:00
Jeff Young 0413270012 ADDED: Move Corner To... and Move Midpoint To... 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5012
 2023-08-05 16:43:55 +01:00
John Beard 478df24f36 Fix fillets and chamfers when the original lines become zero-length 
This needs the ITEM_MODIFICATION_ROUTINE to learn to delete items.
Condense the item change handlers into a single injected object
(ITEM_MODIFICATION_ROUTINE::CHANGE_HANDLER) and provide the basic
implementation that just takes some callables.

This simplifies the construction of the routines and also would make
a CHANGE_HANDLER object possible that can be reused between different
tools.
 2023-07-30 15:12:28 +01:00
John Beard da0daffa89 Remove more special-casing for fp-edit commit handling 
In the EDIT_TOOL::ModifyLines method, there was some
remaining special-casing for FP childen commits.

One bit was put back by mistake (in
0b32ae3f4b) because I thought I'd
left it out of the refactor. In fact it was removed slightly later in
1218f61d0a.

THe other bit is omitting Modify commits in the FP-editor (what the
reinstatement of the above code was trying to cause). This shouldn't
be needed any more.

However, something is still incomplete here as the tools still don't
work correctly in the footprint editor. However, I don't think it's
substantially _more_ broken with the special casing removed and at
least it's less confusing.

Related to: https://gitlab.com/kicad/code/kicad/-/issues/15253
 2023-07-30 15:10:30 +01:00
jean-pierre charras a16ab0aae1 Replace SHAPE_T::RECT by SHAPE_T::RECTANGLE: RECT creates a collision name 
issue with a Windows header on msys2.
Change very similar to the commit 9a47b344 about class PAD_SHAPE.
No actual code change
 2023-07-25 09:11:55 +02:00
John Beard 0b32ae3f4b Reinstate fp-editor-specific commit handling in fillet/chamfer tools 
This check was omitted in the refactor of the fillet tool, and
resulted in a bug when undoing the action: the modified lines would
not be un-modified.
 2023-07-23 14:48:31 +01:00
Jeff Young 1218f61d0a Implement undo/redo for footprint children. 
Our special-cases to handle the fact that we didn't do this had far
outgrown the code necessary to actually handle it.
 2023-07-15 17:37:31 +01:00
Jeff Young cf8294b5c2 Remove a bunch of blind (and a few redundant) static_casts. 2023-07-13 14:14:45 +01:00
John Beard a72ab9f351 Put fillet, chamfer and extend in a submenu 2023-07-12 19:21:47 +01:00