4e6cd0d293
Forward and reverse test for point in poly collisions
2024-03-18 15:51:14 -07:00
05cdd44404
Don't assume all glyphs are outline with an outline font.
...
Underline and overbar may be stroke glyphs.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17478
2024-03-18 22:21:01 +00:00
4ed2a0674a
Minor cleanup.
2024-03-18 22:21:01 +00:00
543343b7d1
prettifier: add newlines to golden samples
2024-03-18 16:03:09 -04:00
5318001726
prettifier: add newline to end of file
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/17480
2024-03-18 15:29:43 -04:00
0fab12f367
hotkey selector dialog: accept hotkey using Alt key modifier on Windows.
...
On Windows, Alt key is specific, and the dialog did not accept the modifier
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17453
2024-03-18 18:16:37 +01:00
3b47fd1503
FOOTPRINT_CHOOSER_FRAME: add option to show the 3D in a separate viewer.
...
If a separate viewer frame is selected, the footprint chooser always shows
the footprint and the 3D shape is shown in a 3D viewer frame if the 3D view
is enabled.
2024-03-18 08:42:43 +01:00
72d83cd5de
Revert "Move JSON_SETTINGS and PARAMS to kicommon"
...
This reverts commit 81855aaaa6
2024-03-18 00:08:46 +00:00
2311eed08a
Add new ERC rule to check for global labels with only one entry in the schematic
...
By default this rule is set to ignore to provide continuity for those using
single global labels to name nets (e.g. in simulation)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13212
2024-03-17 23:24:43 +00:00
3f2e3d89e2
Fix selected item count in the properties panel
...
The code for updating selected item count is skipped if the properties
items don't change.
2024-03-17 22:26:31 +00:00
81855aaaa6
Move JSON_SETTINGS and PARAMS to kicommon
2024-03-17 18:11:49 -04:00
37b19c4df7
Handle table layer in undo.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17437
2024-03-17 20:39:46 +00:00
0598ca0f90
Keep BOARD_DESIGN_SETTINGS DRC marker exclusions up-to-date.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17429
2024-03-17 16:29:24 +00:00
797ab998cc
Maintain hierarchy navigator expansion state between edits.
...
Prevent the hierarchy navigator from being rebuilt unless there are actual
sheet changes that would cause a change to the tree.
Save the tree expansion state before rebuilding the tree and then restore
the expansion state to the previous state sans edits.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16635
2024-03-17 09:02:26 -04:00
d317b8da74
Pull modifications to cherry pick forward from 6.0.
2024-03-17 12:42:45 +00:00
44c14b1935
Fix layer swapping for multi-layer items.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17371
2024-03-17 12:14:21 +00:00
383dbd983a
Don't skip transitions from netclass to empty.
2024-03-16 19:46:48 +00:00
a6e8370ddd
Pin names drive netnames.
2024-03-16 19:26:26 +00:00
17a93adb30
Netclasses also must be computed in connectivity updates.
2024-03-16 19:24:25 +00:00
116908c088
Formatting.
2024-03-16 12:00:15 +00:00
a4062ade3d
Report location of FUTURE_FORMAT_ERRORs when reading footprints.
2024-03-16 11:06:12 +00:00
d17151ac1b
Correctly handle locked token for PCB_TEXTBOX and PCB_TABLECELL.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17439
2024-03-15 21:42:47 +00:00
fc11862580
Try out the medium runner for public linux builds
2024-03-15 18:37:34 +00:00
da2610b93b
Add autocomplete accept & cancel to the hotkeys list.
2024-03-15 00:40:17 +00:00
e07b4ce8e4
Fix triangulationValid check race for zone fill
...
The m_triangulationValid flag is used in several places without holding
the mutex, thus it should only ever be set when the triangulation is
guaranteed to be valid.
This can either be done by protecting both data and flag by the same
mutex, or updating the flag only after the triangulation has finished.
Also fix the case when the triangulation actually fails, the flag should
not be set in this case.
While at it, simplify the recalculation check. Only if both the
triangulation is valid, and the data hash is unchanged the recalculation
can be skipped - this is typically the case when two threads try to
update the cache concurrently, the second one will block at the mutex,
and will see the valid data after the first thread has finished.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17180
2024-03-14 22:26:23 +00:00
91b850d8df
pcbnew: The checkbox 'Center on footprint' was not disabled when the actionButton was changed.
2024-03-14 22:24:30 +00:00
cf97432833
Fix Eagle footprint library QA test failure.
...
Unfortunately the KiCad library I/O does not unescape file names so do not
escape them in the Eagle board plugin.
2024-03-14 17:00:27 -04:00
f22f5f47cb
Reset penWidth before stroking.
...
(PlotPoly will have set it to "1".)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17218
2024-03-14 17:40:04 +00:00
e30b6398b7
ADDED: optional PDF metadata from AUTHOR and SUBJECT variables.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17289
2024-03-14 17:40:04 +00:00
34ec57958d
Fix Eagle board import when footprint library versions exist.
...
This was a crude hack that appends the library URN ordinal to the name of
the footprint so that it can be correctly looked up by the "element" node.
The Eagle XML DTD does not make it clear how the URN "ASSET_ID" and
"VERSION" are used to look up the appropriate "ASSET_TYPE" so this is a
best guess and seems to work correctly.
The inferred edge clearance dialog had to be disabled when importing third
party boards because on GTK (and possibly other platforms) the dialog would
completely hang KiCad preventing the imported board and possible schematic
from being saved.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12897
2024-03-14 09:45:05 -04:00
c27eade01e
Symbol Editor: do not allow to select fully invisible pins and fields
...
Of course, invisible pins or fields shown by using option Show invisible
pins or Show invisible fields can be selected.
2024-03-14 10:01:58 +01:00
81cb6d0c3f
Fix race condition in zone fill
...
When checking collisions, the SHAPE_POLY_SET::Collide() routine is not
const because it will regenerate the triangulation cache if it is out of
date (using a const_cast, grrr). This sidesteps the issue by assigning
a mutex to the triangulation caching
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17180
2024-03-13 10:35:40 -07:00
4f4d9be8d1
Symbol Editor do not display bounding box of invisible pins and fields
2024-03-13 17:46:14 +01:00
eddf4883b6
Minor dialog layout improvements.
2024-03-13 11:45:33 -04:00
dac16a02cc
Default is a valid netclass, even if it's not in m_NetClasses.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17388
2024-03-13 15:30:07 +00:00
a091767551
Don't test non-overlapping non-through-hole vias.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17426
2024-03-13 15:19:28 +00:00
91d949f59e
Splitter for 3D model page of Footprint Properties.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15606
2024-03-13 15:03:55 +00:00
33566f88a9
Clean up debugging output accidentally left in previous commit.
2024-03-13 10:48:44 -04:00
0ff8d21459
Fix broken paste special keep existing symbol annotations.
...
This was only broken for symbols on the sheet where the symbols were
copied from. The symbol annotation for all sub-sheets was preserved.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17231
2024-03-13 09:39:41 -04:00
7341d4bf37
Update m_LastLegendPosition after setting dirty bit.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17411
2024-03-13 10:39:03 +00:00
b56ee20e22
Fix a crash in PNS zone sync when there's more outlines than triangulated polygons.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17351
2024-03-13 03:09:21 +03:00
b190f21b6c
Remove close buttons from schematic AUI
...
Harmonizes with PCB editor
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17415
2024-03-12 19:51:27 -04:00
ece8521e68
Add some safety to layer swapping
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17371
2024-03-12 19:32:40 -04:00
4b6a1f4dbd
Remove netclass/custom rule handling from Track & Via Properties.
...
(These should be done in Edit > Edit Track & Via Properties.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17216
2024-03-12 22:29:03 +00:00
1844bf1708
Make Edit Track & Via Sizes "specified sizes" dropdowns clearer.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17216
2024-03-12 22:27:10 +00:00
25e181db5c
Don't allow selection of footprint text in board editor.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17271
2024-03-12 21:30:12 +00:00
628ec858a6
Label netlist exporters.
...
(Particularly useful for those that have no other settings and
otherwise look blank.)
Also replaces "Generator" terminology as it's a bit confusing
(and will only get more confusing with PCBNew Generators).
2024-03-12 17:47:24 +00:00
7ec2a1f09c
Allow Scintilla-created clipboard to be accessed after quit.
2024-03-12 17:09:07 +00:00
2a0ce409e3
Attempt to fix non-MacOS build error.
2024-03-12 15:17:30 +00:00
87121af3c9
Simplify about dialog impl and make it real-time performant.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17213
2024-03-12 14:50:10 +00:00
Seth Hillbrand
Jeff Young
Mike Williams
jean-pierre charras
Mark Roszko
JamesJ
wh201906
Wayne Stambaugh
StefanBruens
Jan Wichmann
Alex Shvartzkop
Jon Evans