jean-pierre charras
c7d636d560
Gerber file generation: fix incorrect aperFunction attribute for graphic items on edge cut layer.
...
Was NonConductor. Must be Profile.
2019-10-09 15:46:35 +02:00
Ian McInerney
58d4a8bb4a
pcbnew: Don't reinitialize the router tool in an action
...
Calling Init() in an action routine will reset the router
settings to the state they were in when first starting pcbnew.
The Init() function is automatically called when the tool is created.
Fixes: lp:1843810
* https://bugs.launchpad.net/kicad/+bug/1843810
2019-10-07 16:07:05 -04:00
Jeff Young
890e1c9ea0
Be more careful about EOF processing when reading netlist.
...
Fixes: lp:1845848
* https://bugs.launchpad.net/kicad/+bug/1845848
2019-10-07 12:53:32 +01:00
jean-pierre charras
0a829c328e
Python scripting: fix a crash with some pythons scripts calling BOARD::ComputeBoundingBox()
...
This function calls Pgm(), but when running from a script (not from kicad) Pgm() uses a nullptr reference.
The nullptr reference is now tested in ComputeBoundingBox()
2019-10-05 10:39:33 +02:00
Ian McInerney
b33c3a5ad8
pcbnew: Clean up extension handling in graphics plugins
...
* Fix wildcard display in the file selector dialog (on GTK
it would show the regex to the user)
* Move the file extension comparison into a common function
2019-10-04 15:43:29 -04:00
Jeff Young
429c7055e9
Some performance enhancements contributed by Oleg Endo.
...
Fixes: lp:1846438
* https://bugs.launchpad.net/kicad/+bug/1846438
2019-10-04 19:41:40 +01:00
Jeff Young
0ad9ddb3a6
Use cached bounding boxes for performance.
...
Fixes: lp:1846438
* https://bugs.launchpad.net/kicad/+bug/1846438
2019-10-04 11:45:08 +01:00
Ian McInerney
0aa5424511
pcbnew: Switch over some drawing tools to use PrimeTool
...
Before, if the tools were activated from the context menu,
they would start drawing where the menu item was selected
instead of where the menu was opened.
2019-10-03 19:04:36 +01:00
Ian McInerney
5862b1559f
Cleanup position handling for TOOL_EVENTs
...
* Make the events generated by the selection of context menu items
have the position where the menu was opened
* Ensure that TC_COMMAND type events have their position set to
be the cursor position where the event originated
2019-10-03 19:04:33 +01:00
jean-pierre charras
9d617502d5
Gerbview: fix missing grid initialization at starting.
2019-10-03 18:33:16 +02:00
Jeff Young
6179dfde37
Default keep upright to false in design settings.
...
The board file only writes out a token if it's true, so the value
must default to false.
Fixes: lp:1845883
* https://bugs.launchpad.net/kicad/+bug/1845883
2019-10-02 10:56:13 +01:00
Jeff Young
2679e80469
Fix bug saving last netlist filepath.
...
Fixes: lp:1845883
* https://bugs.launchpad.net/kicad/+bug/1845883
2019-10-01 17:43:26 +01:00
Jeff Young
9a349065db
Better error messages for router.
2019-10-01 15:02:41 +01:00
Jeff Young
b58df5e777
Flip Start0 etc. when in ModEdit.
...
ModEdit and PCBNew use Start0/End0/etc. differently so care must
be taken when flipping.
Fixes: lp:1845402
* https://bugs.launchpad.net/kicad/+bug/1845402
2019-10-01 11:02:52 +01:00
jean-pierre charras
31e38f2fd4
Fix an issue in DIALOG_NETLIST: if the netlist does not exist, one cannot always modify the entered name.
...
Fix also a wxWidgets alert
2019-09-30 19:41:19 +02:00
Jeff Young
4bf2b6a9f7
Performance enhancements for cross-probing.
...
While found when profiling cross-probing, many of these will also
improve other things.
2019-09-27 19:58:16 +01:00
jean-pierre charras
d3982d0cb2
board stackup manager: a few enhancements in code and make some strings translatable
2019-09-27 17:12:24 +02:00
jean-pierre charras
2e3d781bf2
layer stack manager: fix a crash due to a recent change in code.
2019-09-26 20:48:28 +02:00
jean-pierre charras
3cd12088a3
PANEL_SETUP_BOARD_STACKUP: minor cosmetic enhancement.
2019-09-25 09:27:36 +02:00
Seth Hillbrand
7f54617dab
pcbnew: Clear view prior to terminating
...
On complex boards, the view holds a very large vector of all objects.
The dtor will remove each one, searching for the pointer before
removing. When removing all items, this process is not needed, so we
clear the view when exiting. This also prevents lock-up when closing
the full application as KiCad waits for the dtor to finish
(non-interactively). This will cause Windows to crash and Linux to
offer an option for terminating the non-responsive application.
Fixes: lp:1843092
* https://bugs.launchpad.net/kicad/+bug/1843092
2019-09-24 11:44:33 -07:00
jean-pierre charras
cd6c1c48a4
Board stackup manager: add material selector to solder mask and silkscreen layers.
2019-09-24 16:30:25 +02:00
jean-pierre charras
840c77fa9c
pcbnew/swig/pcbnew_action_plugins.cpp: fix crash due to broken detection of deleted items after running a script.
...
the old way was not compatible with the current management if board item lists.
The crash was probably due to double deletions.
Note also the management of undo command in pcbnew_action_plugins needs serious optimization.
Fixes: lp:1844880
https://bugs.launchpad.net/kicad/+bug/1844880
2019-09-23 14:07:45 +02:00
Seth Hillbrand
bba949c04d
pcbnew: properly close tags when handling bad poly
...
The parenthesis depth is 2 when the polygon isn't closed. This
shouldn't happen but we have the fall-through to handle odd cases
Fixes: lp:1844872
* https://bugs.launchpad.net/kicad/+bug/1844872
(cherry picked from commit d862cdaa72
)
2019-09-21 09:27:01 -07:00
jean-pierre charras
8be9aeac9f
Fix typo
2019-09-21 09:50:01 +02:00
jean-pierre charras
7355ed3bda
Fix Typo
2019-09-20 13:15:06 +02:00
jean-pierre charras
badd0bfa54
Minot fixes in GERBER_JOBFILE_WRITER, due to recent changes in .gbrjob file format.
2019-09-20 13:13:19 +02:00
Seth Hillbrand
4d8949371f
conn: Connect pads to anchor points not geo center
...
Pads may include offsets that allow the user to shift the connection
point of the pad. This is captured by the pad m_Pos but not by
ShapePos(). When testing connectivity, we need to get the offset
position.
2019-09-19 13:49:12 -07:00
Seth Hillbrand
b7128639f8
connectivity: Check all anchors for connection
...
With pads, we should check available anchor points for each connection,
increasing probability of finding connection to match fill algorithm
Fixes: lp:1844661
* https://bugs.launchpad.net/kicad/+bug/1844661
2019-09-19 12:44:40 -07:00
jean-pierre charras
fc6dc81878
Pcbnew, gerber job file: add "name" field in stackup section
2019-09-19 20:29:39 +02:00
jean-pierre charras
115e1e33da
dialog edit footprint: display fp orientation between -180 and + 180 instead of 0 ... 360 deg.
...
Previously, the wxTextCtrl was using 0 ... 360 but the predefined values are -90 to 180 deg.
2019-09-19 20:29:39 +02:00
jean-pierre charras
16f4958430
Pcbnew: avoid crash when closing pcbnew if the DRC dialog is open.
...
Cvpcb: change from commit 9ceca583:
the root class close event that save settings is now seeing the close event.
2019-09-19 09:16:12 +02:00
jean-pierre charras
a1fe8cfa5a
Minor changes: cleanup code and prepare code to add more attributes to Object Attributes (.TO)
2019-09-18 11:48:49 +02:00
jean-pierre charras
a52dc57887
Pcbnew: Fix incorrect footprint angle rotation after flipping around Y axis (left to right)
...
The angle rotation was always negated. But this is incorrect:
The angle rotation must be negated when flipping around X axis
The angle rotation must be 180 - initial rotation when flipping around Y axis
This bug can break position files and footprint updates,
especially when mixing flipping around Y axis and flipping around X axis.
2019-09-17 18:51:27 +02:00
jean-pierre charras
072ea9a33e
Pcbnew: flip command: when flipping only one item, flip it around its anchor instead of its bounding box.
...
This is the behavior of previous 5.1 version.
Using the bounding box has advantages, but unfortunately in many cases the footprint position is moved.
If a lot of flip commands are made on the same footprint, it is moved far from its initial position.
2019-09-17 10:06:39 +02:00
jean-pierre charras
64b5e8bee2
Minor fix and enhancement code.
2019-09-15 11:10:53 +02:00
jean-pierre charras
91c66a05ae
DIALOG_DIELECTRIC_MATERIAL_BASE: Minor fix
2019-09-13 11:35:27 +02:00
jean-pierre charras
c10d30c1c8
PANEL_SETUP_NETCLASSES: fix not working (immediately closed) wxChoice widgets to select a filter
...
This happens with wxWidgets 3.0.4 on Windows and is a side effect of a call to Layout().
The fix just calls Layout() only when needed.
Fixes: lp:1843594
https://bugs.launchpad.net/kicad/+bug/1843594
2019-09-13 11:29:51 +02:00
Jeff Young
f1790c24e5
Fix issue with Arc pad primitive dialog having center and start swapped.
...
Fixes: lp:1842199
* https://bugs.launchpad.net/kicad/+bug/1842199
2019-09-12 21:22:47 +01:00
Jeff Young
aeedbf87dd
Tighten up the Pad Properties dialog a bit.
...
Fixes: lp:1843580
* https://bugs.launchpad.net/kicad/+bug/1843580
2019-09-12 14:45:01 +01:00
Wayne Stambaugh
4bfb8ef457
Pcbnew: fix Eagle footprint library polygon pad sizes.
...
Eagle includes the width of the polygon line when generating polygon pad
sizes where KiCad does not. This simple fix inflates polygon pads half
of the Eagle polygon line width.
Fixes lp:1833687
https://bugs.launchpad.net/kicad/+bug/1833687
2019-09-12 07:35:48 -04:00
jean-pierre charras
f5692584f2
cleanup
2019-09-12 13:25:15 +02:00
jean-pierre charras
271465a644
Stackup manager: Add a dielectric manager to handle more easily user defined dielectric substrates
...
panel_board_stackup.cpp: material selection:
replace wxChoice by a better widget (wxTextCtrl+wxButton) to call the dielectric manager dialog
Move dielectric material class to a specific file
2019-09-12 10:37:05 +02:00
Jeff Young
95ec2fba02
Fix tabbing in Text Properties dialog.
2019-09-10 12:40:28 +01:00
jean-pierre charras
2a9157ca99
Pcbnew, multiline graphic text dialog: strip extra \r in EOL (\n is enough) on Windows.
...
Fixes: lp:1843279
https://bugs.launchpad.net/kicad/+bug/1843279
2019-09-10 10:57:04 +02:00
jean-pierre charras
c3bd9b7b8f
Stackup manager: better code.
2019-09-09 17:22:17 +02:00
Jeff Young
8dd8740fa3
Performance enhancement for pad drawing.
...
Fixes: lp:1843065
* https://bugs.launchpad.net/kicad/+bug/1843065
2019-09-09 13:45:06 +01:00
Jeff Young
7dc9beaf11
Add type filter to push pad properties.
...
Fixes: lp:1827820
* https://bugs.launchpad.net/kicad/+bug/1827820
2019-09-08 23:50:36 +01:00
Jeff Young
b4a3f4bb41
Sync GAL grid with layer visibility on doc-open.
...
Fixes: lp:1843169
* https://bugs.launchpad.net/kicad/+bug/1843169
2019-09-08 23:08:46 +01:00
Jeff Young
44a1cf9f1b
Implement quiet-mode for selection clearing.
...
Also adds comments for exising quiet-mode calls.
Fixes: lp:1843177
* https://bugs.launchpad.net/kicad/+bug/1843177
2019-09-08 19:45:35 +01:00
jean-pierre charras
37fac7a8f2
Stackup editor: fix crash when trying to calculate dielectric layer thickness if all dielectric layers are locked.
...
Add also more tests to validate values.
Fixes: lp:1843131
https://bugs.launchpad.net/kicad/+bug/1843131
2019-09-08 11:49:04 +02:00
Jeff Young
f491b7fff7
Check for dup layer names in the GUI, not in the internals.
...
Doing so in the internals keeps users from being able to swap layer
names as the dialog does each layer name change individually.
Fixes: lp:1842665
* https://bugs.launchpad.net/kicad/+bug/1842665
2019-09-07 23:54:43 +01:00
Jeff Young
14c4175040
Tighten up the board setup dialog layout a bit.
2019-09-07 13:57:38 +01:00
Jeff Young
e3a525d3c9
See if this fixes the Mojave layout issue.
2019-09-07 13:22:33 +01:00
Jeff Young
83a02e18eb
Mac OSX changes for new board stackup panel.
...
Fixes: lp:1843033
* https://bugs.launchpad.net/kicad/+bug/1843033
2019-09-06 23:43:50 +01:00
Jeff Young
2553dd2942
Bail on our custom dockart provider.
...
It appears that it was causing some crashes, and it was never clear
that it looked better anyway.
2019-09-06 23:38:20 +01:00
Jeff Young
10c25a2290
Update frame type enum to match current class names.
2019-09-06 23:38:20 +01:00
Wayne Stambaugh
24454f5105
Pcbnew: fix size of graphics import warning dialog.
...
Use the HTML_MESSAGE_BOX window to present the warning messages rather
than wxMessageBox which would overflow the display when there were a lot
of graphic items that could not be parsed.
Fixes lp:1839565
https://bugs.launchpad.net/kicad/+bug/1839565
2019-09-06 14:57:04 -04:00
Wayne Stambaugh
2b24c09307
Pcbnew: minor netlist dialog layout fixes.
2019-09-06 11:14:13 -04:00
jean-pierre charras
bd34348068
Pcbnew: allows using filled polygons in zones with no outline thickness.
...
This option was only available if advanced config "ForceThickZones" was set.
2019-09-06 16:13:41 +02:00
jean-pierre charras
cee1873fff
Footprint editor: fix a crash when trying to edit the properties of a footprint not yet in tree (i.e. imported from file)
2019-09-06 15:37:26 +02:00
jean-pierre charras
e0c82fb003
Board stack manager: add a basic reporter to copy the current stackup to the clipboard.
2019-09-06 11:26:27 +02:00
Seth Hillbrand
90b5cd3032
Unify text edit dialog behavior
...
This makes the pcbnew multiline text editor natively accept tabs in the
same manner as eeschema and extracts key handling routines to the shim
to allow undo/redo.
Also allows Ctrl-Y under Linux in addition to other platforms. While
not as popular as Ctrl-Shift-Z, it is utilized for Redo in some contexts
2019-09-05 14:11:02 -07:00
Jeff Young
3bd38ec245
Improve zoom-to-extents for footprints with long text.
...
Fixes: lp:1820540
* https://bugs.launchpad.net/kicad/+bug/1820540
2019-09-05 21:02:29 +01:00
jean-pierre charras
a5c8b5ed41
Stack manager: cosmetic enhancement: replace a text having no meaning by a bitmap
2019-09-05 21:02:11 +02:00
jean-pierre charras
24ea8f970e
Pcbnew: update SEXPR_BOARD_FILE_VERSION to 20190905 (actual commit date for board physical stackup feature)
2019-09-05 20:15:30 +02:00
jean-pierre charras
5cf21789e9
FOOTPRINT_VIEWER_FRAME: minor fix: initialize m_canvasType to the value actually used.
2019-09-05 19:53:47 +02:00
jean-pierre charras
f3f0e20a67
Pcbnew: add a board layer stack manager
...
This is a new feature.
2019-09-05 18:51:18 +02:00
Seth Hillbrand
e7c07501c5
Minor compile warning cleanup
2019-09-05 09:47:52 -07:00
Seth Hillbrand
a4808e0420
pcbnew: Copy hatch zone settings when duplicate
...
Also wrap orientation instead of verifying it. This allows valid angles
that are larger/smaller than the ±180 limit.
Fixes: lp:1842654
* https://bugs.launchpad.net/kicad/+bug/1842654
2019-09-05 09:42:24 -07:00
Jeff Young
6688e80131
Update description in footprint tree when it's edited.
...
Also implements a more useful message panel for Footprint Editor.
Fixes: lp:1842660
* https://bugs.launchpad.net/kicad/+bug/1842660
2019-09-04 17:19:25 +01:00
Seth Hillbrand
c8a6878eb8
pcbnew: Allow tuning length to be longer than INT_MAX
...
The INT_MAX limit for most elements makes sense only for single-segment,
straight line elements. For elements that accumulate lengths, we should
utilize the long long int (64 bits) to allow for greater lengths.
Fixes: lp:1842367
* https://bugs.launchpad.net/kicad/+bug/1842367
2019-09-03 16:41:09 -07:00
Jeff Young
720de6bae1
Cleanup.
2019-09-03 17:16:27 +01:00
Jeff Young
9a6c534e60
Another try at the duplicate-then-move ghosting bug.
...
Fixes: lp:1813038
* https://bugs.launchpad.net/kicad/+bug/1813038
2019-09-03 16:51:00 +01:00
Jeff Young
4c9e4c947c
Fix for move-after-duplicate only needs the extra update once.
...
This version will be quite a bit more performant.
Fixes: lp:1813038
* https://bugs.launchpad.net/kicad/+bug/1813038
2019-09-02 20:46:06 +01:00
Jeff Young
a675b8e3b2
Add specificty for text labels in Dimension Properties dialog.
...
While we're re-using the Text Properties dialog, it really covers all
properties for a Dimension, so it needs to be more clear what's text
and what's not. This changelist uses the Tooltips to store the more
explicit labels so they can still be edited in FormBuilder.
2019-09-02 11:07:05 +01:00
jean-pierre charras
762dabd754
Pcbnew, DIALOG_TEXT_PROPERTIES: make lines thickness editable when editing a dimension.
...
Fixes: lp:1841797
https://bugs.launchpad.net/kicad/+bug/1841797
2019-09-02 09:48:17 +02:00
Ian McInerney
1b3322a538
Make the extension check for graphics import case insensitive
...
The regex for the file extension that matches against all case
possibilities is only built on Linux.
Fixes: lp:1842180
* https://bugs.launchpad.net/kicad/+bug/1842180
2019-09-02 08:33:23 +02:00
Jeff Young
5e353e8967
Fix another case of selection getting out of sync with dragged items.
...
Use a big hammer this time.
Fixes: lp:1839780
* https://bugs.launchpad.net/kicad/+bug/1839780
2019-08-31 20:23:06 +01:00
Jeff Young
e269b5d1b9
Workaround an issue where a throw terminates (even when there's a catch for it).
...
You can trigger it before this fix by running Cvpcb when a .kicad_mod file is
incorrectly set as "Legacy" in your footprint table.
2019-08-31 15:18:27 +01:00
Jeff Young
315a99e0fe
Use Move() instead of SetPosition() so that the second pt gets updated too.
...
Fixes: lp:1841989
* https://bugs.launchpad.net/kicad/+bug/1841989
2019-08-30 23:32:17 +01:00
Seth Hillbrand
69b6052d6f
fpviewer: Second go at preventing focus stealing
...
Fixes: lp:1841565
* https://bugs.launchpad.net/kicad/+bug/1841565
2019-08-30 09:10:45 -07:00
Jeff Young
79d062aefc
Don't allow selection dragging when a picker tool is running.
...
Fixes: lp:1841691
* https://bugs.launchpad.net/kicad/+bug/1841691
2019-08-30 10:33:34 +01:00
Jeff Young
d2cd659471
Be better about cleaning up mouse capture.
...
Fixes: lp:1841996
* https://bugs.launchpad.net/kicad/+bug/1841996
2019-08-29 23:56:16 +01:00
Jeff Young
359cf384de
Import graphics is a one-shot, not a tool.
...
Fixes: lp:1841975
* https://bugs.launchpad.net/kicad/+bug/1841975
2019-08-29 23:56:16 +01:00
Seth Hillbrand
64c012c175
modedit: Enable snapping on anchors
...
The selection of footprint anchor should obey normal snapping paradigm.
2019-08-28 10:38:27 -07:00
Seth Hillbrand
494d0de9b8
Handle active layer overloading
...
Setting the active layer should be tied to the events that are triggered
by the layer change and overloaded for each frame. This ties the hotkey
back to these events.
Fixes: lp:1838244
* https://bugs.launchpad.net/kicad/+bug/1838244
2019-08-27 21:28:51 -07:00
Jeff Young
ebbb12e978
Give empty preference pages the right parent.
...
Fixes: lp:1841665
* https://bugs.launchpad.net/kicad/+bug/1841665
2019-08-27 21:50:52 +01:00
Jeff Young
2fba0a4f61
Register COMMON_CONTROL for help menu actions.
...
Fixes: lp:1841560
* https://bugs.launchpad.net/kicad/+bug/1841560
2019-08-27 19:23:07 +01:00
Jeff Young
559035a7f6
Make sure the menu bar gets activated (ie: don't eat the activate event).
...
Fixes: lp:1841560
* https://bugs.launchpad.net/kicad/+bug/1841560
2019-08-27 19:23:07 +01:00
Jeff Young
a5a237ac32
Improve readability of flag checking.
2019-08-27 19:23:07 +01:00
Seth Hillbrand
ff118c62ec
Cleanup OnCharHook in footprint_viewer_frame
...
This provides a better fix for d0adaf1ef
and handles Tab/Shift-Tab
consistently in the filters
2019-08-27 08:42:43 -07:00
Seth Hillbrand
d0adaf1efd
pcbnew: Update focus in browser
...
When we refresh a scrolled window to get the GTK scrollbars updated, we
can capture the mouse, making key-only scrolling difficult when we want
the window not focused. This resets the active focus after refresh.
Fixes: lp:1841565
* https://bugs.launchpad.net/kicad/+bug/1841565
2019-08-27 08:30:08 -07:00
jean-pierre charras
9dac8534c1
Pcbnew: seriously speedup calculation time when plotting large filled areas.
2019-08-27 13:32:00 +02:00
Seth Hillbrand
48d68f55d7
pcbnew: Two layer boards need both masks
...
Adds the missing default layer to the default board setups for two
layers with parts on single side (either top or bottom)
Fixes: lp:1841294
* https://bugs.launchpad.net/kicad/+bug/1841294
(cherry picked from commit 8b3a2984bf
)
2019-08-26 17:14:35 -07:00
Seth Hillbrand
b3615b36bb
pcbnew: Retain 45° constraint
...
This also finishes the polygon with 45° lines when chosen as a create
option.
Fixes: lp:1833673
* https://bugs.launchpad.net/kicad/+bug/1833673
(cherry picked from commit fccce265aa
)
2019-08-26 14:36:23 -07:00
Jeff Young
bc0e67579c
Change OK/Cancel to MSW order and move some other dialogs to new system.
...
(There's no point in following the OSX OK/Cancel order as you can't
tab to buttons on OSX anyway.)
2019-08-26 18:36:35 +01:00
Jeff Young
6b6e9eddee
Return control of Symbol and Footprint chooser col widths to user.
...
The auto-calculation wasn't working out and even with it some users
wanted control.
Fixes: lp:1796774
* https://bugs.launchpad.net/kicad/+bug/1796774
2019-08-26 18:27:49 +01:00
Jeff Young
67db6c49b5
Buttons which bring up dialogs for more info need a "...".
...
Fixes: lp:1795385
* https://bugs.launchpad.net/kicad/+bug/1795385
2019-08-26 18:27:49 +01:00
Jeff Young
92330b9c93
Sort modules and pads in Footprint Report file.
...
Fixes: lp:1793764
* https://bugs.launchpad.net/kicad/+bug/1793764
2019-08-26 18:27:49 +01:00
Seth Hillbrand
8277aeec7d
eagle: Set module-relative position of ref/val
...
We need to set the footprint local coordinates of the footprint
reference and value fields at instantiation separately from the
TEXT_DIVERS elements.
Fixes: lp:1829727
* https://bugs.launchpad.net/kicad/+bug/1829727
(cherry picked from commit a43a228f78
)
2019-08-26 09:57:17 -07:00
Ian McInerney
1bbd944277
pcbnew: Add ability to reset layer/item colors to defaults
2019-08-26 09:20:08 -04:00
Jeff Young
b109aba663
Add a file browser to the Sheet Properties dialog.
...
Fixes: lp:1840459
* https://bugs.launchpad.net/kicad/+bug/1840459
2019-08-26 00:45:34 +01:00
Jeff Young
19b463ec78
Add option to keep 3DModel info when exchanging footprints.
...
Fixes: lp:1841303
* https://bugs.launchpad.net/kicad/+bug/1841303
2019-08-25 22:49:36 +01:00
Jeff Young
03da721030
Move events to wxFormBuilder and fix the missing hookup.
...
Fixes: lp:1841361
* https://bugs.launchpad.net/kicad/+bug/1841361
2019-08-25 20:48:47 +01:00
Jeff Young
7c85dc6cd7
Clearance should be in mils, not inches.
...
Fixes: lp:1841360
* https://bugs.launchpad.net/kicad/+bug/1841360
2019-08-25 20:48:46 +01:00
Seth Hillbrand
7c37641d83
pcbnew: Partial board stats cleanup
...
Fixes ordering issue and int/double conversion in board area
Moves via casting to internal dyn_cast
2019-08-25 08:48:09 -07:00
jean-pierre charras
a0fec9db57
PCBNew - fix incorrect gerber generation for overlapping zones of the same net and having different draw options.
...
Previously, zones of the same net were merged for plotting,
regardless the fact the outline thickness can be different between the zones,
creating incorrect solid areas.
Fixes: lp:1840695
https://bugs.launchpad.net/kicad/+bug/1840695
2019-08-25 13:16:45 +02:00
Jeff Young
2622f875ee
Simplify the pad tool menus a bit.
2019-08-24 17:13:35 +01:00
Seth Hillbrand
2518a2cc81
pcbnew:Initialize board statistics
...
Uninitialized values can cause odd output values. Also adjust absolute
calc to utilize floating point returns.
Fixes: lp:1838325
* https://bugs.launchpad.net/kicad/+bug/1838325
2019-08-24 08:21:08 -07:00
Seth Hillbrand
820c2d2722
pcbnew: Fix error in connecitivty calculation
...
Point in polygon should test against half the stroke width as the stroke
is performed _on_ the polygon edge.
2019-08-23 10:45:41 -07:00
Seth Hillbrand
18b6bdf5dd
Use cached bbox for connectivity
...
On large boards, connectivity checks are hotspots. We use the cached
bbox to avoid re-computing polygons for pads.
2019-08-23 10:45:41 -07:00
Jeff Young
809a4e3c0e
Improve connectivity tests for pads.
...
We now test N, S, E and W as well as center.
Fixes: lp:1840721
* https://bugs.launchpad.net/kicad/+bug/1840721
2019-08-23 17:44:10 +01:00
Jeff Young
32aa265175
Enable Save As for footprints with no current library.
...
Fixes: lp:1840997
* https://bugs.launchpad.net/kicad/+bug/1840997
2019-08-23 10:56:46 +01:00
Seth Hillbrand
03d5bf0df5
PNS: Check that we are optimizing a pad
...
Vias are also sent to breakout optimizer, so we need to check for the
solid cast before dereference.
Fixes: lp:1841057
* https://bugs.launchpad.net/kicad/+bug/1841057
2019-08-22 08:57:19 -07:00
Jeff Young
a6b7d4f7f6
Support 9 comments in the page setting GUI.
...
Fixes: lp:1793148
* https://bugs.launchpad.net/kicad/+bug/1793148
2019-08-21 20:34:01 +01:00
Seth Hillbrand
8576668eba
pcbnew: Snap items to grouped layers
...
When moving a group of items, the allowed snapping layers should be each
layer in the group, not just the first item's LSET.
Fixes: lp:1830164
* https://bugs.launchpad.net/kicad/+bug/1830164
2019-08-21 12:32:13 -07:00
Seth Hillbrand
22fdc7f51f
pcbnew: Scale line width for import
...
The line width in the import dialog is meant to reflect the resulting
width and not the given width of the file.
Fixes: lp:1831496
* https://bugs.launchpad.net/kicad/+bug/1831496
2019-08-21 10:25:40 -07:00
Jeff Young
d1b2a6ea70
More descriptive labelling and hints for solder paste margins.
...
Fixes: lp:1837220
* https://bugs.launchpad.net/kicad/+bug/1837220
2019-08-21 15:35:03 +01:00
Jeff Young
bfb8806682
Upgrade Cvpcb filtering to use a multi-term combined matcher.
...
Fixes: lp:1827135
* https://bugs.launchpad.net/kicad/+bug/1827135
2019-08-21 15:35:02 +01:00
Seth Hillbrand
06cb21cc47
pcbnew: Optimize pad connection revision
...
This modifies that logic for optimizing pad connections.
1) Custom pads now prefer the connections to their longer side. This is
particularly important to match the behavior in a rectangular pad
2) Costs for straight lines are non-zero. This favors fewer connections
3) Custom pad breakouts are at the polygon boundary rather than offset
by 0.1mm. This also matches the circular and rectangular paradigm.
4) Line Heads contained in the pad itself are not optimized. This
prevents escaping the pad unnecessarily
Fixes: lp:1824182
* https://bugs.launchpad.net/kicad/+bug/1824182
2019-08-20 19:35:26 -07:00
Jeff Young
aaa44b7348
Honor the {0, 0} reference on the clipboard.
...
Fixes: lp:1840819
* https://bugs.launchpad.net/kicad/+bug/1840819
2019-08-20 19:57:36 +01:00
Jeff Young
a25368cc6b
Improve spelling.
...
The groundwork here is thanks to kunda1.
Fixes: lp:1831510
* https://bugs.launchpad.net/kicad/+bug/1831510
2019-08-20 19:14:05 +01:00
Jeff Young
baeb3689b5
Improve SNR (and spelling).
2019-08-20 18:02:28 +01:00
Jeff Young
b219fbc3d2
Implement undo/redo for lock/unlock/toggle lock.
...
Fixes: lp:1840770
* https://bugs.launchpad.net/kicad/+bug/1840770
2019-08-20 16:39:40 +01:00
Jeff Young
fb21077d3a
Fix some alignment issues in dialog and formatting issues in code.
...
Fixes: lp:1840775
* https://bugs.launchpad.net/kicad/+bug/1840775
2019-08-20 16:39:40 +01:00
Jeff Young
375e8a2f97
Only add ref & value to boundingBox if they're visible.
...
Fixes: lp:1746911
* https://bugs.launchpad.net/kicad/+bug/1746911
2019-08-20 16:39:40 +01:00
Jeff Young
054a24c26e
Prevent size events from firing during initialization.
...
Fixes: lp:1840690
* https://bugs.launchpad.net/kicad/+bug/1840690
2019-08-20 16:39:40 +01:00
Jeff Young
1bfefc61ea
Allow mouse drag to initiate a router drag if over a track or via.
...
Fixes: lp:1840694
* https://bugs.launchpad.net/kicad/+bug/1840694
2019-08-19 21:09:44 +01:00
Jeff Young
195fbbaf23
Reduce confusion by putting all dialog pages as leaf nodes.
2019-08-19 17:46:25 +01:00
jean-pierre charras
b25ffc0aa8
Pcbnew, layer manager: fix flicker when loading a file, and incorrect size on start when no file is loaded
...
Fixes: lp:1840591
https://bugs.launchpad.net/kicad/+bug/1840591
2019-08-19 10:42:22 +02:00
Jeff Young
e65569e3b2
Clean up some issues in Footprint Viewer.
2019-08-19 00:06:22 +01:00
jean-pierre charras
8f583008e0
Fix minor compil warnings
2019-08-18 09:13:55 +02:00
Jeff Young
3fefe01d2e
Improve keyboard-only use of Footprint Viewer.
...
Fixes: lp:1465295
* https://bugs.launchpad.net/kicad/+bug/1465295
2019-08-17 12:23:19 +01:00
Seth Hillbrand
99859727e8
pcbnew: Handle edge cuts in footprints for bbox
...
The Board bounding box calculation has two modes: edges only and
everything. While the everything mode works as expected, the edges only
calculation (and everything that depends on it) was seeing only the edge
cuts on the board drawings layer and not the footprint edge cuts.
Fixes: lp:1839768
* https://bugs.launchpad.net/kicad/+bug/1839768
2019-08-16 10:58:45 -07:00
Seth Hillbrand
aa875e5830
PNS: Don't allow routing on hidden layers
...
If the layer is not shown, we should not be allowing it's items to be
selected and chosen as the start/end items in the router.
(cherry picked from commit fc1fb7a590
)
2019-08-15 12:40:05 -07:00
jean-pierre charras
d50dc4ff65
PANEL_SETUP_LAYERS: minor cosmetic change: Fix for commit e2be49a2
.
...
The commit e2be49a2
was sent too early.
2019-08-15 10:26:08 +02:00
jean-pierre charras
e2be49a2f6
PANEL_SETUP_LAYERS: minor cosmetic change.
2019-08-15 09:44:55 +02:00
jean-pierre charras
2f2aba2333
FOOTPRINT_WIZARD_FRAME: fix UI issues (incorrect size of message panel and not selectable first item in param list)
...
Fixes: lp:1840193
https://bugs.launchpad.net/kicad/+bug/1840193
2019-08-15 09:27:28 +02:00
Seth Hillbrand
959a4bdded
pcbnew: Don't stack same tool handler
...
The Get and place tool used to live in selection tool and could activate
the edit tool by stacking calls. Now that it is itself in the edit
tool, we cannot stack another call to the edit tool that runs
immediately, instead we allow the GetAndPlace to finish before beginning
the next tool (Move)
2019-08-14 17:12:00 -07:00
Jeff Young
a0eaff289a
Add filters to footprint viewer.
...
This also allows us to remove button to access the tree dialog
since the only extra it provided was filtering.
Fixes: lp:1465295
* https://bugs.launchpad.net/kicad/+bug/1465295
2019-08-14 21:51:26 +01:00
Ian McInerney
8493daf9ff
Unify menu item creation for closing a window
...
* Push a function into CONDITIONAL_MENU that adds the item
* Modify the tooltip for close and exit items to have the
program name
Fixes: lp:1835454
* https://bugs.launchpad.net/kicad/+bug/1835454
2019-08-14 09:35:15 +01:00
Ian McInerney
e47c9ccc0b
pcbnew: Clean up switch statement in launcher
2019-08-14 09:35:14 +01:00
Jeff Young
045f5f6a61
Move some functions out of SELECTION_TOOL that don't really belong there.
2019-08-13 13:29:18 +01:00
Jeff Young
dd938b02df
New move tool doesn't require GetAndPlace to jump through hoops.
...
And at least one of those hoops leaves the cursor forced.
Fixes: lp:1839877
* https://bugs.launchpad.net/kicad/+bug/1839877
2019-08-13 10:01:47 +01:00
jean-pierre charras
1c295d46a9
Pcbnew plot: fix missing footprint texts on solder mask layers.
...
Fixes: lp:1839892
https://bugs.launchpad.net/kicad/+bug/1839892
2019-08-13 09:43:36 +02:00
Seth Hillbrand
619c78622e
pcbnew: Initialize drag and clear links
...
Drag is used for multiple modes so should be initialized when starting.
The line that we generate however needs to be pristine in drag, so we
clear the links in the duplicate.
Fixes: lp:1839612
* https://bugs.launchpad.net/kicad/+bug/1839612
2019-08-12 15:32:16 -07:00
Jeff Young
ccf18ceb0e
Fix accidental change in default radio button of Update PCB from Schematic.
2019-08-12 22:21:09 +01:00
Jeff Young
f3f0a6899f
Invoke move by ACTION; the EDIT_TOOL does lots of other stuff too.
...
Fixes: lp:1839877
* https://bugs.launchpad.net/kicad/+bug/1839877
2019-08-12 22:21:09 +01:00
Jeff Young
3bf24fae7a
Set selection reference point to top-left item.
...
Fixes: lp:1771016
* https://bugs.launchpad.net/kicad/+bug/1771016
2019-08-12 22:21:09 +01:00
Jeff Young
cc0bd9a171
Even out PCB_EDITOR_CONTROL and PCB_INSPECTION_TOOL.
2019-08-12 22:21:09 +01:00
Ian McInerney
d170243d61
Fix some memory leaks
...
Some elements of modules and boards were not deleted, so memory
was being leaked on some library loads and single-instance
pcbnew usage.
2019-08-12 15:03:25 -04:00
Michael Kavanagh
79b2ff7551
Refactor deleteTool ACTION removing duplicates
2019-08-12 13:49:55 -04:00
Michael Kavanagh
db59c7011b
Unify menubar delete action
2019-08-12 13:49:55 -04:00
jean-pierre charras
10e4bf2a20
Remove dead code
2019-08-11 14:22:58 +02:00
jean-pierre charras
e04436b138
Cleaning code: remove dead code in spread_footprints.cpp.
2019-08-10 20:29:54 +02:00
Jeff Young
c836cc9cf8
Don't use activate to move as the edit tool must activate for other ops.
...
Fixes: lp:1839534
* https://bugs.launchpad.net/kicad/+bug/1839534
2019-08-10 11:58:05 +01:00
Jeff Young
17b5a3750b
Move preferences-lost hack down into EDA_DRAW_FRAME.
...
I've now seen it in Eeschema as well as Pcbnew.
Fixes: lp:1839148
* https://bugs.launchpad.net/kicad/+bug/1839148
2019-08-09 21:22:56 +01:00
Jeff Young
bc07c7da11
Use wxChoice instead of wxComboBox so we get menu highlighting.
2019-08-09 16:01:45 +01:00
Jeff Young
17d015ed5d
Strip illegal chars from 3D filepath and change rotation increment to 90deg.
...
Fixes: lp:1823559
* https://bugs.launchpad.net/kicad/+bug/1823559
2019-08-08 23:02:37 +01:00
Jeff Young
ab283174df
Make sure edit flags get cleared after drawing footprint items.
...
Fixes: lp:1839518
* https://bugs.launchpad.net/kicad/+bug/1839518
2019-08-08 20:51:07 +01:00
Jeff Young
0b87a92ed6
Make Mac-work-around Mac-only.
2019-08-08 16:32:44 +01:00
Jeff Young
4d53ff9811
Grid dropdown doesn't always live in the same toolbar.
...
Also fixes typo in grid properties dialog.
Fixes: lp:1839224
* https://bugs.launchpad.net/kicad/+bug/1839224
2019-08-08 13:51:23 +01:00
Tomasz Włostowski
726bceecfd
router: springback now works for dragging vias in shove mode
...
Fixes: lp:1837766
* https://bugs.launchpad.net/kicad/+bug/1837766
2019-08-07 23:49:57 +02:00
Tomasz Włostowski
88f2318c9c
router: add VIA_HANDLE to refer to VIAs going in/out the SHOVE algorithm without raw pointers
2019-08-07 23:48:28 +02:00
Tomasz Włostowski
45e4387ed1
router: remove unnecessary include
2019-08-07 23:46:32 +02:00
Tomasz Włostowski
5666af4d1d
router: copy m_owner when copying PNS::ITEMs
2019-08-07 23:45:38 +02:00
Tomasz Włostowski
75fcdb3b08
router: disable hole to hole mechanical constraint in P&S until a suitable solution is found (as it is now it breaks springback)
2019-08-07 23:44:43 +02:00
Seth Hillbrand
5151cd0bfe
C++14: Remove unused make_unique.h
...
Also removes header references now that we are in C++14, this is
built-in to the std
2019-08-07 09:27:31 -07:00
Seth Hillbrand
e985e10eec
gerber: Fracture footprint polygons before exporting
...
Footprint polygons can be degenerate and need
to be simplified before exporting
2019-08-06 17:00:27 -07:00
Jeff Young
4399a52ad3
Work around a wxWidgets bug that loses the preferences item from the menu.
...
Fixes: lp:1839148
* https://bugs.launchpad.net/kicad/+bug/1839148
2019-08-06 11:50:19 -06:00
Jeff Young
edc05b5d54
Pad properties dialog needs to edit the local value, not the resultant value.
...
Fixes: lp:1838618
* https://bugs.launchpad.net/kicad/+bug/1838618
2019-08-05 21:38:28 -06:00
Ian McInerney
f59b3a0210
pcbnew: Move layer toolbar icon previous values to struct
...
The static variables posed problems on Linux, and also were
not as portable for multiple instances of PCB_EDIT_FRAME.
2019-08-05 20:47:29 -06:00
Jeff Young
6c0a3b4534
Disable inappropriate values for aperture pads.
...
Fixes: lp:1809010
* https://bugs.launchpad.net/kicad/+bug/1809010
2019-08-05 16:48:18 -06:00
Jeff Young
6069263beb
Add ctrl-W to 3D viewer.
...
Fixes: lp:1835454
* https://bugs.launchpad.net/kicad/+bug/1835454
2019-08-05 16:48:18 -06:00
Wayne Stambaugh
bf5ce3a1ba
Pcbnew: fix minor layout issues in options panel.
2019-08-05 11:29:16 -04:00
Jeff Young
95bfb733ee
Add defensive coding for <enter> processing in Edit Footprint Text dialog.
...
Fixes: lp:1806124
* https://bugs.launchpad.net/kicad/+bug/1806124
2019-08-04 16:25:36 -06:00
jean-pierre charras
120637bd9b
A few I18n minor fixes.
2019-08-04 10:33:54 +02:00
Jeff Young
c60118b6a4
Ativate delete tool so it can display the selection clarification menu when needed.
...
Fixes: lp:1835371
* https://bugs.launchpad.net/kicad/+bug/1835371
2019-08-03 22:17:31 -06:00
Jeff Young
3e8ebe0a2a
Fix formatting.
2019-08-03 22:16:21 -06:00
Jeff Young
373ba5a904
Better tooltip for Match Mode radio buttons.
...
Fixes: lp:1838551
* https://bugs.launchpad.net/kicad/+bug/1838551
2019-08-03 17:20:54 -06:00
Jeff Young
c438686deb
Put selected layer in front of DRC markers.
...
Fixes: lp:1824656
* https://bugs.launchpad.net/kicad/+bug/1824656
2019-08-03 17:20:54 -06:00
jean-pierre charras
7bfbcef942
Make some strings more easily translatable
...
DIALOG_BOARD_STATISTICS: fix some minor issues.
2019-08-03 09:32:10 +02:00
Jeff Young
01e78b04c6
Save last-used-paths in export dialogs.
...
Also fixes the export GenCAD dialog so that browse correctly updates
the textbox.
Fixes: lp:1793761
* https://bugs.launchpad.net/kicad/+bug/1793761
2019-08-02 21:03:48 -06:00
Jeff Young
b8a03be869
Flip block around center instead of first item's anchor.
...
Fixes: lp:1789775
* https://bugs.launchpad.net/kicad/+bug/1789775
2019-08-02 16:07:25 -06:00
Jeff Young
f756af788e
Fix missing CTRL+W in libEdit and modEdit.
...
Fixes: lp:1835454
* https://bugs.launchpad.net/kicad/+bug/1835454
2019-08-02 15:56:29 -06:00
Jeff Young
cc82e59003
Push the Quit/Close menu logic down into common.
2019-08-02 14:32:49 -06:00
Jeff Young
5c85dbaec4
Another attempt to improve tooltips for Update PCB from Schematic dialog.
2019-08-02 14:32:49 -06:00
Seth Hillbrand
76853dfeb2
pcbnew: Fix copy-paste error from 161dc9ce7
...
create_vrml_shell() needed the idxSide check but create_vrml_plane only
had an extra variable that wasn't used and so shouldn't be checked.
(cherry picked from commit c9956def36
)
2019-08-02 13:17:02 -07:00
Jeff Young
937e3c2d48
Make m_Text private so we don't keep getting bugs where m_shown_text fails to get updated.
...
Fixes: lp:1838655
* https://bugs.launchpad.net/kicad/+bug/1838655
2019-08-01 20:36:59 -06:00
Jeff Young
1ea9ad05bc
More explicit text for Update PCB dialog.
...
Fixes: lp:1838551
* https://bugs.launchpad.net/kicad/+bug/1838551
2019-08-01 20:36:59 -06:00
Jeff Young
3f28a1d1cb
Cleanup after cancelled add text dialog.
...
Fixes: lp:1838452
* https://bugs.launchpad.net/kicad/+bug/1838452
2019-07-31 23:10:13 -06:00
Jeff Young
5c80019541
Update comment.
2019-07-31 21:56:53 -06:00
Seth Hillbrand
ff28501d6d
pcbnew: Fix VRML export checking
...
In rare cases, the VRML triangulator may claim to work but return empty
vectors. These cases need to be caught before we dereference the vector
elements.
Fixes: lp:1838448
* https://bugs.launchpad.net/kicad/+bug/1838448
(cherry picked from commit 161dc9ce7e
)
2019-07-31 20:04:41 -07:00
Ian McInerney
6c401ecce7
pcbnew: Fix DXF units in drill map plotting
...
Fixes: lp:1836924
* https://bugs.launchpad.net/kicad/+bug/1836924
2019-07-30 16:17:57 -04:00
Michael Kavanagh
58cfc13649
Fix some lost menubar menu separators
2019-07-30 19:12:34 +02:00
Ian McInerney
b70df18939
pcbnew: Force rebuild of layer pair icon on menu creation
...
Fixes: lp:1838158
* https://bugs.launchpad.net/kicad/+bug/1838158
2019-07-28 17:38:32 -06:00
Jeff Young
b432a718ab
Back out previous fix.
2019-07-28 17:38:27 -06:00
Jeff Young
7b5b807a8c
Another attempt to fix the GTK uninitialized layer pair bitmap.
...
Fixes: lp:1838158
* https://bugs.launchpad.net/kicad/+bug/1838158
2019-07-28 16:19:57 -06:00
Jeff Young
ee1be14b62
Initialize static memory. Only the LLDB compiler does this for you.
...
Fixes: lp:1838158
* https://bugs.launchpad.net/kicad/+bug/1838158
2019-07-28 12:50:22 -06:00
Jeff Young
987642eb8c
Apply selectable logic to delete tool.
...
Fixes: lp:1838191
* https://bugs.launchpad.net/kicad/+bug/1838191
2019-07-28 12:31:18 -06:00
Jeff Young
8334cb9a1c
Don't attempt colinear corner optimization when zones of different nets overlap.
...
Fixes: lp:1838197
* https://bugs.launchpad.net/kicad/+bug/1838197
2019-07-28 10:32:15 -06:00
jean-pierre charras
10fcd8eaef
DIALOG_BOARD_STATISTICS_BASE: fix minor wxWidgets alerts.
2019-07-28 18:24:59 +02:00
Alexander
a6b2a44fd6
DIALOG_BOARD_STATISTICS modifications and fixes - added vias information to dialog - added "save txt report" feature - some code cleanup and readability fixes - fixed issue with dialog moving when checkbox clicked - now dialog saves checkboxes state
2019-07-28 16:17:09 +02:00
jean-pierre charras
dc69cac298
Try to fix UI issues in select layer pair dialog and slect layer dialog.
...
Fixes: lp:1838173
https://bugs.launchpad.net/kicad/+bug/1838173
2019-07-28 12:54:59 +02:00
Jeff Young
d0344aecea
Minor cleanup in dialog layout.
2019-07-27 23:27:21 -06:00
Jeff Young
4e40534d21
Update find history in combobox when history item is selected.
2019-07-26 23:50:51 -06:00
Jeff Young
5347c2ad3d
Clear selection when running drawing tools.
...
Fixes: lp:1837796
* https://bugs.launchpad.net/kicad/+bug/1837796
2019-07-26 23:38:37 -06:00
Jeff Young
3904d7ccfc
Push some search stuff down into EDA_DRAW_FRAME so it can be shared.
...
Also rewrites the PCBNew Find dialog to make use of the above, including:
1) searching in user-defined footprint fields
2) searching in pcb text
3) a history list in the search popup
4) case sensitive searching
5) word sensitive searching
6) the ability to turn wildcard searching on/off
7) better placement of the result when the dialog obscures part of the
window
Fixes: lp:1838006
* https://bugs.launchpad.net/kicad/+bug/1838006
2019-07-26 17:53:32 -06:00
Jeff Young
7314acf053
Renaming.
2019-07-26 13:19:17 -06:00
Jeff Young
77334628c4
Change default tool behaviour to skip unhandled events.
...
The problem is that wxEVT_CHAR_HOOK doesn’t do the key translation
properly. wxEVT_CHAR does, but we only get to that if we skip the
event at the end of the tool’s event processing loop, which most tools
don’t do. (Selection tools, point editors, pickers, and a couple of
others do skip, which is probably why this didn’t get reported earlier.)
I played around with a couple of ways to fix wxEVT_CHAR_HOOK. Most of
them don’t work, and the few egregious hacks I tried weren't cross-
platform.
So I’m changing it so that most tools now skip at the end of their
event loops. I left out a couple that I felt were high risk (length
tuning, for instance). But there’s still enough risk that I’m 100%
sure it will break something, I just haven’t a clue what.
Fixes: lp:1836903
* https://bugs.launchpad.net/kicad/+bug/1836903
2019-07-26 12:21:24 -06:00
Jeff Young
815602d1af
Fix missing AF_ACTIVATE flags on some tools.
...
Fixes: lp:1813659
* https://bugs.launchpad.net/kicad/+bug/1813659
2019-07-26 12:21:24 -06:00
Thomas Pointhuber
5f438b7a85
Fix handling of filled circle in eagle importer (was only partly fixed)
...
Partly fixed in 4fc692f04b
, but missed
that there is a loadPlain where I need to handle this case as well.
2019-07-26 09:55:06 -04:00
Thomas Pointhuber
c68b83e1bb
Add support for hatched zones in eagle import
2019-07-26 09:38:26 -04:00
Jeff Young
460b03372d
Implement preference for immediate actions.
...
Also pushes prefer-selection-to-dragging to common.
2019-07-25 20:41:22 -06:00
jean-pierre charras
3d9c04ecaf
Pcbnew: Fix bug in MODULE::FindPadByName( const wxString& aPadName ).
...
This method was using a case insensitive comparison to find the pad matching aPadName.
But in netlist we are using case sensitive comparisons to attribute a net to a pad.
So if in the netlist there is a pad name that does not match any footprint pad name using case sensitive comparison but if it matches some pads using case insensitive comparison, the net is not set, but the test to detect non existing pads fails.
2019-07-25 17:37:25 +02:00
jean-pierre charras
dd702cd53d
Remove pads not on copper layers (just on tech layers) from connectivity calculation.
...
Pads not on copper layers now do not have a netname, and are no longer taken in account in connectivity.
Especially it avoid creating useless rats-nests for these pads.
2019-07-25 13:08:41 +02:00
Jeff Young
79934a327e
Implement shoving of free vias.
...
Also contains a little bit of cleanup and a lot of commenting.
Fixes: lp:1833216
* https://bugs.launchpad.net/kicad/+bug/1833216
Fixes: lp:1833214
* https://bugs.launchpad.net/kicad/+bug/1833214
2019-07-24 09:33:47 -06:00
Jeff Young
a7c41f0c34
Renaming for clarity. Unqualified "push" could mean push-n-shove, or it could mean push/pop.
2019-07-24 09:33:47 -06:00
Jeff Young
c1fcb1d895
Allow shoving and springback when dragging vias (either connected or free).
...
Fixes: lp:1833216
* https://bugs.launchpad.net/kicad/+bug/1833216
2019-07-24 09:33:47 -06:00
Jeff Young
8c77d31d4d
Simplification in prep for fixing some via dragging issues.
...
There should be no change in logic with this commit.
2019-07-24 09:33:47 -06:00
jean-pierre charras
d208447cba
Zone filler: clamp thermal stub width to the pad minimal size.
...
Setting stub width to a ridiculous large value (for instance 100 times the pad size) creates strange and broken shapes,
and obviously stubs cannot be built.
Ensure also the thermal shape is inside the zone boundary (because the algo adds areas this was previously possible)
Fixes: lp:1837559
https://bugs.launchpad.net/kicad/+bug/1837559
2019-07-23 20:32:38 +02:00
jean-pierre charras
30c724e858
Pcbnew: Mark some strings translatable in menu and/or hotkey list.
2019-07-23 11:53:55 +02:00
Jeff Young
1808d8bd40
Add hole-to-hole-minimum checking to via placement.
...
Courtesy of Frank Severinsen.
Fixes: lp:1833214
* https://bugs.launchpad.net/kicad/+bug/1833214
2019-07-21 21:21:11 -06:00
Jeff Young
2ca379b281
Copy ratsnest flags when exchanging modules.
...
Fixes: lp:1834214
* https://bugs.launchpad.net/kicad/+bug/1834214
2019-07-21 19:49:13 -06:00
Jeff Young
b858fa38c4
Fix crash bugs in picker tools.
2019-07-21 19:06:06 -06:00
Jeff Young
aa4d7682ca
Don't shove stitching vias.
...
Whether or not it's a good idea, the current algorithm doesn't support
it and leaves them on top of each other.
Fixes: lp:1833214
* https://bugs.launchpad.net/kicad/+bug/1833214
2019-07-21 16:38:06 -06:00
Jeff Young
6f44b00b2c
Add support for hole collisions to PNS.
2019-07-21 16:38:06 -06:00
Jeff Young
b79d2d9258
Cleanup.
2019-07-21 16:38:06 -06:00
jean-pierre charras
346495ae31
Fix errors in DIALOG_BOARD_STATISTICS.
...
(some values were not in the right column or row)
2019-07-21 16:45:37 +02:00
jean-pierre charras
88801f46d9
Fix issues in DIALOG_BOARD_STATISTICS:
...
- make it wxWidgets 3.1 compatible.
- internationalize.
- fix minor wxwidgets alert.
- remove settings for fg/bg color: the result is unpredictable:
was black texts on black background on my computer.
2019-07-21 12:01:36 +02:00
Jeff Young
ab7cf4a2b0
A bit of visual cleanup for the new Board Statistics dialog.
2019-07-20 14:39:08 -06:00
Alexander
bb290abe91
added board statistics dialog, which shows info for production and assembly
2019-07-20 14:39:08 -06:00
jean-pierre charras
858db3c104
Synchronize toolbars state with current options after rebuilding them.
...
Previously, for instance after modifying preferences or language,
they were rebuilt but the tools state was not set due to a missing call to SyncToolbars() after rebuilding.
2019-07-20 18:16:35 +02:00
Jeff Young
b5e01ea163
Initialize plot with aux origin checkbox.
...
Fixes: lp:1836923
* https://bugs.launchpad.net/kicad/+bug/1836923
2019-07-20 07:54:40 -06:00
Jeff Young
4a1edf581e
Update DXF units drop-down.
...
Fixes: lp:1836927
* https://bugs.launchpad.net/kicad/+bug/1836927
2019-07-20 07:48:16 -06:00
Jeff Young
d746ba892d
Make sure the postion relative tool gets activated when used.
...
Fixes: lp:1836978
* https://bugs.launchpad.net/kicad/+bug/1836978
2019-07-19 20:14:40 -06:00
Jeff Young
02eb1d2c62
Don't try and run drawing tools in ModEdit with no module selected.
...
Fixes: lp:1836673
* https://bugs.launchpad.net/kicad/+bug/1836673
2019-07-19 15:29:10 -06:00
Jeff Young
0b08e4dcd2
Deactivate other tools when running one based on a PICKER.
...
In particular, if the last one was a PICKER tool, then we're going
to assert on "click-handler-already-set".
Fixes: lp:1836673
* https://bugs.launchpad.net/kicad/+bug/1836673
2019-07-19 15:29:10 -06:00
jean-pierre charras
176b1a0fd5
FP editor: fix crash when trying to save a footprint (Ctrl+S) when no footprint loaded.
2019-07-19 19:06:16 +02:00
jean-pierre charras
b4fc78fc0d
kicad_plugin.cpp: fix incorrect detection of existing footprints in PCB_IO::FootprintExists(), when fp names contain a point.
...
Fixes: lp:1837221
https://bugs.launchpad.net/kicad/+bug/1837221
2019-07-19 18:16:07 +02:00
Seth Hillbrand
bacbe86756
pcbnew: Make clearance translucent
...
This sets the clearance outline to a slightly better opacity to allow
viewing of items behind the routed track clearance. Future work should
include making this a configuration option.
Fixes: lp:1826719
* https://bugs.launchpad.net/kicad/+bug/1826719
(cherry picked from commit e0589d2908
)
2019-07-18 10:47:27 -07:00
jean-pierre charras
f4c1730b7c
Pcbnew, footprint tree selector: make the selected items readable.
...
Previously, the background was highlighted, but not the text.
On Windows, the text was unreadable, until it was selected.
Now the foreground color is also set to the text selected color.
Similar to fix 34e00bdb6d
, but for the fp editor.
2019-07-18 14:54:52 +02:00
Seth Hillbrand
b31212def2
pcbnew: Ensure we don't overflow export
...
\u%4.4 can output between 7-11 bytes, which can overflow and not allow
the null terminator to be represented.
2019-07-17 18:24:25 -07:00
Jeff Young
3de00eef5f
Cleanup.
2019-07-17 21:45:43 +01:00
Jeff Young
d67c2d13c7
Fix re-entrancy problem in cross-probing.
...
Fixes: lp:1836940
* https://bugs.launchpad.net/kicad/+bug/1836940
Fixes: lp:1836937
* https://bugs.launchpad.net/kicad/+bug/1836937
2019-07-17 21:35:28 +01:00
Jeff Young
7c1049d86b
Fix event-loop issue with some pickers.
...
RunAction returns immediately even when called with "run now" flag.
Fixes: lp:1836905
* https://bugs.launchpad.net/kicad/+bug/1836905
2019-07-17 21:35:28 +01:00
Tomasz Wlostowski
5bb06e5ac5
pcbnew: can't return a copy of ptr_vector if items are polymorphic and have no clone() methods. Work it around.
2019-07-17 08:10:47 -04:00
jean-pierre charras
164d40f235
Zone filled, non copper zones: fix missing inflate for non stroked solid areas.
2019-07-17 13:24:21 +02:00
Jeff Young
b9749d361b
Turn of pad mask layers if Eagle file specifies stop="no"
...
Fixes: lp:1835930
* https://bugs.launchpad.net/kicad/+bug/1835930
2019-07-17 01:03:34 +01:00
Jeff Young
ba7ad7ddf4
Fix bug with PCBNEW_PICKER_TOOL not doing a push/pop.
...
PICKER_TOOL got updated but PCBNEW_PICKER_TOOL didn't.
2019-07-16 20:25:25 +01:00