24ac9b7055
Pcbnew: array: repair dialog value init
...
Fully initialise the CREATE_ARRAY_DIALOG_ENTRIES object,
and use these values for the dialog on first open. Currently,
the initial values aren't all initialised, and none are used, as the
valid flag is not set. This means there are poor defaults in some
fields.
Also more declarations and defintions of CREATE_ARRAY_DIALOG_ENTRIES
to the .cpp, as these do not need to be exposed in the header,
even privately.
2019-01-30 15:41:35 -08:00
ffaf99a600
Pcbnew: Enable some numbering options in pcbnew
...
The numbering axis priority (h then v or v then h), and alternate
reversing are not actually numbering parameters, they are part of
the geometry of the array (the items are physically in different
orders).
So enable these options, even when numbering is disabled.
Also fix broken logic about when numbering scheme is enabled
(it still applies even if the numbering offset is fixed.)
2019-01-30 15:41:35 -08:00
5504981d00
Separate ARRAY_OPTIONS to own class in common
...
The geometry and numbering logic is separate to the dialog, and
can be separated for clearer logic and better testability.
Moreover, refactor it to avoid any dependency on pcbnew
classes, so it can be move to common for potential re-use in
eeschema and friends in future.
Also convert all wxPoint logic in these classes to VECTOR2I and
fix some function visibilities.
Add some unit tests of the ARRAY_OPTIONS geometry and numbering.
2019-01-30 15:41:35 -08:00
2dea3a49c8
Fix compile error in std::pow useage.
2019-01-30 16:38:34 +00:00
05483a06c6
pcbnew: Re-attach snap options
...
Snapping to item options were partially disconnected when unifying
framework. This re-attaches the options and adds the additional option
for graphical items.
Fixes: lp:1801377
* https://bugs.launchpad.net/kicad/+bug/1801377
2019-01-29 13:36:17 -08:00
914596fcbb
pcbnew: Allow STEP export tolerancing
...
kicad2step has a tolerance level that sets whether two points are at the
same location or not. This allows KiCad to access these levels to some
degree, permitting a looser interpretation of a closed board outline.
2019-01-29 13:05:23 -08:00
577bb73320
Revert 7d06651a10.
2019-01-28 20:10:13 +00:00
9d99fd188f
Revert "Change top selection drop-down to combobox"
...
This reverts commit 7d06651a10
2019-01-28 10:15:32 -08:00
e850a482d1
Gerber output: fix a potential minor issue in a G04 line comment.
...
In gbr files only ASCII7 chars are allowed.
However, in a comment line a UTF8 string is used. It should not create issues, but it is incorrect.
2019-01-27 10:14:16 +01:00
b8cfabd22e
Fix some issues in I10n strings
...
Fix typo and missing I10n identifier for 2 strings
2019-01-26 09:25:12 +01:00
b13efdb0f2
Initial global footprint library table fixes.
...
Fix bug when pcbnew is launched from a folder containing an existing
fp-lib-table file by using same method as setting the initial global
symbol library table.
Fixes lp:1810169
https://bugs.launchpad.net/kicad/+bug/1810169
Fixes lp:1738871
https://bugs.launchpad.net/kicad/+bug/1738871
2019-01-20 13:51:07 -05:00
9cac0a38cc
DIALOG_GRAPHIC_ITEM_PROPERTIES: better tooltip.
...
minor other code enhancement (does not create any actual change)
2019-01-19 12:35:35 +01:00
9657039af2
pcbnew: multiple fixes concerning track->pad net propagation used by Track/Via properties dialog:
...
- Added ignore netcode option to CONNECTIVITY_DATA::GetConnectedItems()
- PlaceModule() now ensures the module added to the board (and thus to the connectivity database) has correct bounding box necessary for R-trees to work
- Use recursive connected pad search so that the new net is propagated to all pads
Fixes: lp:1787961
* https://bugs.launchpad.net/kicad/+bug/1787961
2019-01-18 02:53:29 +01:00
9458ae8221
pcbnew: Prevent GITHUB plugin from being registered
...
If the user does not build the GITHUB plugin (deprecated), we cannot use
it in our footprint load and should remove the define to ensure
accidental use is caught at compile time.
2019-01-15 12:14:02 -08:00
90ad240660
units: Move common units and add tests
...
Centralizing duplicate code from Eeschema and pcbnew and adding unit
tests
2019-01-08 09:29:32 -08:00
1e5ba6f1b1
Replace DIM() macro
...
The standard DIM() macro was not typesafe as it happily deferred errors
to runtime that can be caught at compile time. Replacing it with a
generic C++11 constexpr allows for typecasting, comparison and compile
time error checking.
2019-01-06 08:43:12 -08:00
db7dba96ad
Fix a few Coverity warnings.
...
Mainly not initialized members, and replace not tested dynamic_cast by static_cast.
2019-01-04 09:49:21 +01:00
7d06651a10
Change top selection drop-down to combobox
...
wxChoice centers the selection on GTK. So when switching from a
mid-list item to an item at the top, the list is always cut off for
choice lists located on the top toolbar. Using a combobox provides a
drop-down that allows easier access to all elements in the box.
Fixes: lp:1808569
* https://bugs.launchpad.net/kicad/+bug/1808569
2019-01-03 14:48:28 -08:00
efbc50b7b8
prevent NULL dereference in dialog_text_properties
2019-01-02 19:40:29 -08:00
b39061855e
pcbnew: Translate scripting test window
2019-01-02 14:49:55 -08:00
dffa399eab
Set mirrored when creating footprint texts on back layer.
2018-12-31 21:50:09 +00:00
061d993448
Warn the user when global track/via edits fail.
2018-12-31 21:50:09 +00:00
4d9b4428fa
It's never a good idea to dereference a freed pointer.
...
Fixes: lp:1809897
* https://bugs.launchpad.net/kicad/+bug/1809897
2018-12-27 13:33:19 +00:00
0c0dda54bf
Close any active editor before rebuilding netclass lists.
...
Fixes: lp:1809555
* https://bugs.launchpad.net/kicad/+bug/1809555
2018-12-24 01:55:02 +00:00
5f3cbff977
Pcbnew, DIALOG_SET_GRID_BASE: A few cosmetic enhancements and fix a wxWidgets minor alert
2018-12-21 10:15:15 +01:00
95dcc30ffb
Load footprint browser with last-selected footprint.
2018-12-16 21:59:42 +00:00
f0c0f04348
Fix ReadNetList and UpdatePCB issues with new footprints.
...
Make sure the view is rebuilt before selecting the new footprints
so that they're shown only in the selection overlay.
Don't start the drag until the dialog is closed so we don't have
a bunch of extraneous mouse warping.
Fixes: lp:1775265
* https://bugs.launchpad.net/kicad/+bug/1775265
2018-12-10 19:48:58 +00:00
7f20c55ed6
Pcbnew, Plot dialog, Gerber format: Enable or disable adding net metadata both in X1 and X2 format. Previously, this option was existing only in X2 format. Should be existing in both formats.
...
A bit of cleaning code related to this option.
2018-12-09 08:38:23 +01:00
6a7ee5b107
Add locale handling for orientation combobox.
...
Fixes: lp:1806851
* https://bugs.launchpad.net/kicad/+bug/1806851
2018-12-05 18:08:50 +00:00
4f5771f79f
Don't nag user about changes they made in a text editor.
...
Fixes: lp:1806748
* https://bugs.launchpad.net/kicad/+bug/1806748
2018-12-04 23:32:55 +00:00
da40def69d
Standardize on "local coordinates" terminology.
2018-12-04 23:32:55 +00:00
26765161c1
drc: Add board outline and edge crossing
...
This adds a check for contiguous board outlines to the DRC. It also
uses the calculated outline to ensure that traces are not crossing the
outlines.
Fixes: lp:1648055
* https://bugs.launchpad.net/kicad/+bug/1648055
2018-12-02 07:54:52 -08:00
5eb5b5ce58
DIALOG_TEXT_PROPERTIES: hide visibility option, because this option exists only for footprint texts, and do nothing for other texts.
...
Texts on board (not on footprints) cannot be invisible, at least in 5.0 and previous versions.
2018-12-02 10:30:48 +01:00
45ee95f5e2
Apply CharHook uniformly as other platforms appear to have issues.
...
Fixes: lp:1806124
* https://bugs.launchpad.net/kicad/+bug/1806124
2018-12-01 11:57:16 +00:00
ff6a3482ec
Remove on-kill-focus-validation.
...
Fixes: lp:1805361
* https://bugs.launchpad.net/kicad/+bug/1805361
2018-11-29 19:00:21 +00:00
558c38b5c5
Very minor enhancement in plot dialog.
...
Inside the layers listbox, the context menu can select all fabrication layers.
The courtyard layers (only used for DRC) are now not selected.
2018-11-24 17:48:05 +01:00
2e1920abad
Add tooltips to library manager dialogs.
...
Fixes: lp:1804930
* https://bugs.launchpad.net/kicad/+bug/1804930
2018-11-24 15:06:21 +00:00
b2db49f4ac
Add browse buttons to Library Manager dialogs.
...
Fixes: lp:1804924
* https://bugs.launchpad.net/kicad/+bug/1804924
2018-11-24 15:06:21 +00:00
647fa6547d
Update grid drop-down when changing user grid.
2018-11-23 23:33:02 +00:00
149c4b55a6
DIALOG_TRACK_VIA_PROPERTIES_BASE: fix a minor wxWidgets alert.
2018-11-23 15:46:54 +01:00
d03e82602e
PANEL_COMMON_SETTINGS: minor fixes, mainly cosmetic.
2018-11-22 17:11:49 +01:00
5a74b55074
Reset delayedFocusPage even if it's already the right page.
...
Fixes: lp:1804315
* https://bugs.launchpad.net/kicad/+bug/1804315
2018-11-21 19:51:04 +00:00
65a967dca1
Fix minor I10n issues.
2018-11-18 14:40:36 +01:00
0de9cb345c
Add shortcuts to setting dialogs for track widths, via sizes and grid sizes.
...
Fixes: lp:1803671
* https://bugs.launchpad.net/kicad/+bug/1803671
2018-11-17 00:35:06 +00:00
3c6adbdf03
Indent layer properties for better comprehension.
2018-11-17 00:35:06 +00:00
b35b1bb644
Fix a few minor I18n issues.
...
Especially remove trailing and leading spaces in sentences, always annoying in translations, and never useful in sources.
2018-11-16 18:12:01 +01:00
4050991d28
Move ERC marker focusing to GAL architecture.
...
Fixes: lp:1802537
* https://bugs.launchpad.net/kicad/+bug/1802537
2018-11-16 10:38:44 +00:00
8c8ccf83e6
Fix a few I18n minor issues.
2018-11-16 09:43:40 +01:00
1f3d5cee0e
Fix a few minor I18n issues.
2018-11-15 09:34:29 +01:00
86273e86b9
Added user and grid origins to Position Relative dialog.
...
Also fixed a refresh bug when doing Position Relative.
Fixes: lp:1792699
* https://bugs.launchpad.net/kicad/+bug/1792699
2018-11-12 23:09:45 +00:00
fdff010199
Fix copy/paste errors in delayedFocusRow stuff.
...
Fixes: lp:1802907
* https://bugs.launchpad.net/kicad/+bug/1802907
2018-11-12 17:08:45 +00:00
6789103961
Save internal values rather than textbox content.
...
Fixes: lp:1802442
* https://bugs.launchpad.net/kicad/+bug/1802442
2018-11-11 20:26:19 +00:00
295013e4a9
Clarify fp reference filter and add fp id filter.
...
Fixes: lp:
* https://bugs.launchpad.net/kicad/+bug/
2018-11-11 20:26:19 +00:00
acfa13c038
Fix typo
2018-11-09 15:46:09 +01:00
5c726744b6
Move Zone Properties dialog to Connect() strategy.
...
If checkboxes don't have individual IDs FormBuilder won't assign
them and the event table ends up connecting each checkbox to all
of the checkbox handlers in the dialog.
Fixes: lp:1801746
* https://bugs.launchpad.net/kicad/+bug/1801746
2018-11-08 21:27:15 +00:00
93d3e4ccf8
dialog_footprint_wizard_list_base.cpp: fix a minor wxWidgets alert.
2018-11-04 15:50:29 +01:00
afda69c9cc
Removed default line width setting from the printing dialog
2018-10-31 19:17:30 +01:00
3d15092643
Fixed loading layer visibility setting for printouts
2018-10-31 19:17:30 +01:00
90b6156448
Store line width setting for printouts
2018-10-31 19:17:30 +01:00
d3ea63e133
Removed a redundant parameter from BOARD_PRINTOUT constructor
2018-10-31 19:17:30 +01:00
dea778842b
Grand printing dialogs refactor
...
Patch introduces a generic printing settings window that is customized by pcbnew and gerbview.
2018-10-31 19:17:30 +01:00
e81c3a59a2
Refactored and unified board editor and footprint editor print dialogs
2018-10-31 19:17:30 +01:00
698a380827
Clear selection before printing
...
Selected objects are hidden in VIEW, that makes them disappear from
printouts.
2018-10-31 19:17:30 +01:00
5b94f20e6f
Adapted printout controllers to the new printing routines
2018-10-31 19:17:30 +01:00
c05ca469ae
Pcbnew, DIALOG_PLOT_BASE: Fix a minor wxWidgets alert.
2018-10-29 17:34:14 +01:00
eabae68ab8
PANEL_SETUP_LAYERS_BASE: cosmetic enhancements.
2018-10-29 15:21:03 +01:00
633bc7f2d5
Pcbnew, DIALOG_TEXT_PROPERTIES_BASE: fix many minor wxASSERTs
2018-10-26 13:09:05 +02:00
adfe2fc267
Make sure user isn't surprised by Match All setting.
...
If they selected the dialog with a footprint selected, they're
probably not expecting Match All.
2018-10-23 20:54:42 +01:00
22e5e52598
Fix warning: 'HAVE_CLOCK_GETTIME' macro redefined
2018-10-19 09:59:06 +02:00
ff992f4a64
Keep track of which nets are currently in use.
...
Fixes: lp:1798006
* https://bugs.launchpad.net/kicad/+bug/1798006
2018-10-18 12:14:23 +01:00
e9a80a5d7f
Some minor dialog layout fixups.
2018-10-17 11:23:02 +01:00
9795a3572d
dialog_pns_length_tuning_settings: fix incorrect dialog size.
...
This was due to the fact sizers recalculate the sizes before initialization of a bitmap.
2018-10-17 11:48:15 +02:00
6e3f226e45
Update texts with %V and %R when values or references is chosen.
...
(This in addition to updating them when other fields is chosen.)
2018-10-16 17:46:01 +01:00
51deb9d562
Fix issue with updating Footprint graphic items.
...
dyn_cast doesn't handle inheritance.
2018-10-16 17:07:59 +01:00
3dcd52021a
Simplify exchange footprints dialog and support wildcards.
2018-10-15 19:59:47 +01:00
0585382986
Allow editing of library footprint from board reference.
2018-10-15 19:59:47 +01:00
0bd0558833
Auto-select reference numbers in PcbNew like we do in Eeschema.
2018-10-14 00:06:41 +01:00
4460313104
pcbnew: Separating connectivity to subdir
2018-10-12 16:31:09 -07:00
609d497870
Remember settings in Global Track & Via Properties dialog.
2018-10-10 19:49:06 +01:00
c5499a6b19
Use ChangeValue() so design rules popup doesn't get cleared.
...
Fixes: lp:1796780
* https://bugs.launchpad.net/kicad/+bug/1796780
2018-10-09 21:33:43 +01:00
42ee4f79e4
Fix assert in Graphic Item Properties.
...
Fixes: lp:1792201
* https://bugs.launchpad.net/kicad/+bug/1792201
2018-10-09 11:08:56 +01:00
e439b17fa1
eeschema-gal: make sure all other Kicad apps compile after eeschema gal hacks
2018-10-09 11:08:52 +01:00
d599a02a90
Fix unused variable warnings
2018-10-09 09:14:51 +02:00
9e828e0d94
Don't default Use Netclass Values to on.
...
Fixes: lp:1795939
* https://bugs.launchpad.net/kicad/+bug/1795939
2018-10-05 15:11:18 +01:00
895e187ca0
Add a bit more space for those using larger fonts.
2018-10-05 14:17:58 +01:00
b49ca04355
Remove max length on layer names.
...
Fixes: lp:1745587
* https://bugs.launchpad.net/kicad/+bug/1745587
2018-09-29 22:07:31 +01:00
19b1ae35ce
Don't assume GetFlags() != 0 means it's being edited.
...
It could just mean it's selected, highlighted or brightened.
Fixes: lp:1794624
* https://bugs.launchpad.net/kicad/+bug/1794624
2018-09-27 22:18:13 +01:00
fac5fcb476
Don't draw the pad preview highlighted.
2018-09-27 17:46:51 +01:00
50b96b406f
More net selector fixes.
2018-09-27 16:58:12 +01:00
1685af8425
dialog_track_via_properties_base.cpp: fix a few wxWidgets alerts.
2018-09-27 13:36:50 +02:00
b487a8c70e
Pcbnew: fix track and via properties dialog control alignment issues.
2018-09-26 09:15:58 -04:00
f68581d463
Pcbnew: fix column width in Nets dialog.
...
Nets dialog (Inspect->List Nets) contains list control
that has very small width for first and last columns.
Changed algorithm for calculating optimal values for
column width.
2018-09-26 04:26:09 -07:00
dfd028a66a
Don't gray out non-enabled layers in layers setup panel.
...
Fixes: lp:1794215
* https://bugs.launchpad.net/kicad/+bug/1794215
2018-09-25 20:47:03 +01:00
682cb3abe1
Pcbnew: make "Swap Layers" title translatable.
2018-09-25 12:18:50 -07:00
282e37b2bf
Pcbnew: change step export dialog action button text.
...
Change "OK" to "Export" so user is not surprised by the fact that the
dialog does not close after the step file is created..
Fixes lp:1784260
https://bugs.launchpad.net/kicad/+bug/1784260
2018-09-24 14:57:02 -04:00
efefbf0fa0
Fix typo for updating library trees.
...
Fixes: lp:1794087
* https://bugs.launchpad.net/kicad/+bug/1794087
2018-09-24 15:46:45 +01:00
f3c6e1fb62
Change Position Relative To to use anchor, not centroid.
...
Fixes: lp:1793984
* https://bugs.launchpad.net/kicad/+bug/1793984
2018-09-24 00:42:56 +01:00
525e26eb82
kicad2step: Provide floats separated
...
Clang++ seems to be in left-field here as it processes a stringstream
1.0X1.0 >> double as a hexadecimal floating point ('X' character) and
throws an error rather than converting 1.0 and stopping when it reaches
a non-numeric character. This causes errors when exporting step on Mac,
which uses clang++ by default.
Adding spaces to the string is more explicit and doesn't break gcc. It
will be sufficient until we get rid of kicad2step as an external
utility.
Fixes: lp:1778564
* https://bugs.launchpad.net/kicad/+bug/1778564
(cherry picked from commit e7a9643b37
2018-09-22 08:52:46 -07:00
a1bcc4ba1e
Don't start dragging until Update PCB dialog has been closed.
...
Fixes: lp:1793828
* https://bugs.launchpad.net/kicad/+bug/1793828
2018-09-22 16:23:13 +01:00
666da3849b
Make esc dismiss net and layer selector popups.
2018-09-22 16:23:13 +01:00
John Beard
Jeff Young
Seth Hillbrand
jean-pierre charras
Wayne Stambaugh
Tomasz Włostowski
Maciej Suminski
Thomas Pointhuber
Baranovskiy Konstantin