jean-pierre charras
cc81d97f78
Opengl DrawArcSegment(): refinements for a better look of control points.
...
Use a segment count multiple of 2, because we have a control point on the
middle of the arc, and the look is better if it is on a segment junction
because there is no arc to segment approx error
2020-10-24 17:26:44 +02:00
jean-pierre charras
6d12a0c95b
OPENGL_GAL, DrawArcSegment(): do not modify the radius of arc.
...
The radius correction does not fix correctly approximation errors,
and creates serious issues for thin arcs:
- control point outside the arc
- HitTest active area outside the arc shown on screen
- Cairo and opengl gives different arc positions.
- the formula used in radius correction is probably incorrect.
2020-10-24 16:29:26 +02:00
Marek Roszko
1c848622d7
Remove junctions as auto wire targets
...
Fix #6100
2020-10-24 10:09:42 -04:00
Wayne Stambaugh
4ac4cc14ee
Eeschema: fix new sheet page number bug.
...
Msys2 builds on windows still don't support the %z printf specifier so
convert to integer and use %d.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6142
2020-10-24 09:08:56 -04:00
Marek Roszko
81a7afc76e
Use kicad_algo directly rather than common.h
2020-10-24 08:53:11 -04:00
Marek Roszko
68484e9b38
Nix some global richio.h
2020-10-24 08:44:03 -04:00
Marek Roszko
8d7feb3d72
Nip some common.h from headers
2020-10-24 08:28:03 -04:00
Marek Roszko
77ece552f7
Remove macros.h from files that don't need it
2020-10-24 08:28:02 -04:00
jean-pierre charras
442f40fa66
ConvertOutlineToPolygon() fix another issue for arcs found inside a outline
2020-10-24 10:04:15 +02:00
Marek Roszko
c173ea14b7
Quiet MSVC warning about bool OR int
2020-10-24 00:50:37 -04:00
Marek Roszko
1c0700fbc4
Quiet gcc warning about assignment
2020-10-24 00:50:02 -04:00
Marek Roszko
fde4e247d8
Add missing include
2020-10-24 00:44:25 -04:00
Marek Roszko
eeac3cb4d5
Nix some more common.h includes
2020-10-24 00:38:25 -04:00
Marek Roszko
64484f5fc4
Split KIID out of common.h
2020-10-24 00:17:08 -04:00
Marek Roszko
4d5796fb9a
Extract swig binding macros to their own header
2020-10-24 00:17:07 -04:00
Marek Roszko
304e5faf36
Move wxStringSplit to kicad_string
2020-10-24 00:17:07 -04:00
Seth Hillbrand
b7f115bf5f
Don't write translated strings
...
Even though the translation isn't used, the choice of locale can create
unwanted diffs
2020-10-23 19:53:25 -07:00
Marek Roszko
1d559108c8
Move LOCALE_IO out of common.h
2020-10-23 21:49:42 -04:00
Marek Roszko
472ea039dd
Remove common.h from bitmap.cpp
2020-10-23 21:49:42 -04:00
Marek Roszko
c027398df3
common.h not needed in advanced_config.cpp
2020-10-23 21:49:41 -04:00
Marek Roszko
4d6e4bd622
Remove common.h from env_vars.cpp
2020-10-23 21:49:41 -04:00
Jon Evans
50cff57b9a
Explicit bools for MS
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6146
2020-10-23 21:35:23 -04:00
Jeff Young
59f3fefd17
When polygonizing arcs don't use synthesized center and angle.
...
Start, mid and end are the "real" properties and come with less
error.
Also collapses two arc polygonization routines into one.
Also fixes DRC checks to be cognizant of arc approximation error.
Fixes https://gitlab.com/kicad/code/kicad/issues/6039
2020-10-23 23:55:45 +01:00
Jeff Young
b683871d93
Commit file missing from earlier commit.
2020-10-23 23:55:45 +01:00
Jeff Young
1cb7fbaab1
Fix errors in arc polygonization and test case.
...
1) Tests can't expect accuracies around 1 to work. PCBNew defaults
to 5000.
2) Tests shouldn't artifically expand tolerance just to match the
results.
3) Tests should guarantee that end point is on arc, not just close
to it.
4) Standard polygonization of a circle is inside so splitting the
error needs to increase radius, not decrease.
5) Special-case first and last points so that they're exact.
2020-10-23 23:55:45 +01:00
Jeff Young
c5a86126d2
Be more clever about making sheet names unique.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6123
2020-10-23 23:55:45 +01:00
Seth Hillbrand
cce11e40a1
Remove errant printf
2020-10-23 12:36:53 -07:00
Seth Hillbrand
19bf594aa0
Remove unused point in polygon test
...
There can be only one.
2020-10-23 12:13:09 -07:00
jean-pierre charras
fdf6547f5f
Pcbnew: Select/Expand connection (U) does not propagate with fillet tracks
...
Fixes #6136
https://gitlab.com/kicad/code/kicad/issues/6136
2020-10-23 18:51:05 +02:00
Jeff Young
01ce881340
Honour NOT_IN_SCHEMATIC setting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6137
2020-10-23 17:27:18 +01:00
Marco Ciampa
713515907a
Fixed single language translation update
2020-10-23 16:02:48 +00:00
jean-pierre charras
db66e16f71
SymbolEditor: Ask to save local edits in schematic on symbol editor window closure
...
Previously, Asking for save, cancel... was made for a symbol coming from lib
but not when the symbol come from the schematic editor.
Fixes #6132
https://gitlab.com/kicad/code/kicad/issues/6132
2020-10-23 17:56:15 +02:00
Thomas Pointhuber
b7c2d64333
altium: Correctly parse multiunit symbols
...
Followup to https://gitlab.com/kicad/code/kicad/-/issues/6055
2020-10-23 17:20:07 +02:00
Thomas Pointhuber
adfc74f93a
altium: Add initial support for multiunit symbols
...
Fix: https://gitlab.com/kicad/code/kicad/-/issues/6055
2020-10-23 17:04:59 +02:00
Thomas Pointhuber
0d3d3e0d7c
altium: parse symbol description, remove dependency on legacy plugin
2020-10-23 17:04:59 +02:00
Jeff Young
1cdb8b5584
Make sure local zone clearances are factored into worstClearance.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6128
2020-10-23 14:27:36 +01:00
Jeff Young
58c006bc45
Register properties for ARC elements so we can get their netclass.
...
Also improves GAL arc drawing and polygonization.
Fixes https://gitlab.com/kicad/code/kicad/issues/6039
2020-10-23 14:27:36 +01:00
Thomas Pointhuber
47786fa976
altium: Correctly handle symbol names containing invalid chars
...
Fix: https://gitlab.com/kicad/code/kicad/-/issues/6082
2020-10-23 14:30:29 +02:00
jean-pierre charras
51be98428d
fix a few issues in ConvertOutlineToPolygon().
...
Fixes #6130
https://gitlab.com/kicad/code/kicad/issues/6130
Fixes #6129
https://gitlab.com/kicad/code/kicad/issues/6129
2020-10-23 11:23:45 +02:00
jean-pierre charras
15369915cc
Minor code cleanup: move "extern" declarations to convert_drawsegment_list_to_polygon.h
2020-10-23 08:48:52 +02:00
Wayne Stambaugh
d8ffea881e
Improve dialog static sizer box consistency.
...
Remove colons from the end of static sizer box labels from a few dialogs so
they are consistent with all dialogs.
2020-10-22 22:00:04 -04:00
Jon Evans
922304f980
Guard against missing theme in DIALOG_PLOT_SCHEMATIC
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6124
2020-10-22 21:21:27 -04:00
Jon Evans
7fcef7268b
Handle read-only settings files better
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5688
2020-10-22 20:31:04 -04:00
Tomasz Wlostowski
30830d9127
qa/kimath: trivial test case for POLY_GRID_PARTITION
2020-10-23 01:18:07 +02:00
Tomasz Wlostowski
5b4f463c38
kimath: SHAPE_POLY_SET::Format() outputs C++-like code now, like other shapes
2020-10-23 01:18:01 +02:00
Tomasz Wlostowski
a8074ed37d
kimath: POLY_GRID_PARTITION now uses safer degeneracy (overlapping edges/'slits') handling mechanism. Also added some explanation of the algorithm used.
2020-10-23 01:17:54 +02:00
Jeff Young
82ede1d767
Fix a couple more instances of "auxilary origin".
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5394
2020-10-22 22:31:07 +01:00
Jeff Young
d75f97161f
Focus on center of board for board-related DRC markers.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6119
2020-10-22 21:50:46 +01:00
Jeff Young
27e156917e
Fix tooltip.
2020-10-22 21:47:23 +01:00
Jeff Young
cce557b9ad
Redo the board-edge-building logic to return better error reports.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6119
2020-10-22 21:29:04 +01:00