5ce22d9673
Symbol editor: fix incorrect position of fields when loading a symbol from schematic.
...
In symbol editor, symbols are always shown not mirrored, not rotated.
So if the loaded symbol from schematic was rotated/mirrored, the position
of fields must be recalculated for the rotation 0, no mirror.
2023-03-15 17:55:18 +01:00
c266913ec7
Swap pins for undo.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14100
2023-03-14 11:52:23 +00:00
37b0a5a504
Add quick DRC action for Diff Footprints.
...
Also makes the strings match the GUI better so people will know where
to find them later.
And fixes a couple of ERC items that referred to Board Setup (oops).
2023-03-14 11:52:23 +00:00
66f6168163
Fix mode-less dialog issues.
...
Don't assume the dialog is mode-less and call Destroy() from within a
dialog method. This will most assuredly crash if the dialog is shown
modally or quasi-modally.
Don't leak memory for mode-less dialogs created on the stack. Make sure
when the parent frame window is closed that all mode-less dialog memory
is cleaned up. Dialogs are not child windows like controls and toolbars
so their memory does not automatically get cleaned up when the parent
window is destroyed.
Do not directly access frame parent window's pointer in dialog destructors.
Apparently the tear down order when destroying mode-less dialogs is not
guaranteed so the parent window may get deleted before the dialog causing
a crash when accessing the parent window pointer from the dialog dtor.
Do not close mode-less dialogs in the parent frame's destructor. This
doesn't guarantee that the dialog(s) will be destroyed before the parent
but it may reduce some careless mode-less dialog event handling in the
future.
2023-03-13 12:04:01 -04:00
dc78797274
Support SHEET_PATH when printing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14233
2023-03-12 22:24:06 +00:00
c4ef08bead
Exercise more caution with user filenames.
...
In particular, don't assume "1" is an extension in "Schematic_1.1".
Fixes https://gitlab.com/kicad/code/kicad/issues/14263
2023-03-12 15:52:45 +00:00
74f064d3aa
Don't keep smart pointers to wxWindows, particularly modeless ones.
...
wxWindows have their own lifecycle management.
2023-03-11 19:36:01 +00:00
c9351dfd67
Drawing improvements for symbol & footprint diffs.
...
Moves forced-transparency setting down into VIEW_ITEM so that it can
be used to place forced-transparent objects in a different target.
This keeps EnableDepthTest() from equalizing the alpha values between
the two symbols (or two footprints).
2023-03-11 12:45:16 +00:00
5041bddc3b
Union workbook sim commands with any defined on schematic.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14215
2023-03-10 21:33:06 +00:00
6d29088668
Add missing command to SPICE directives list.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14215
2023-03-10 21:33:06 +00:00
3bc5e3dd8a
Added PSPICE/LTSPICE JFET model parameters.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12425
2023-03-10 21:33:06 +00:00
9546a40662
Correct usage of elipses after menu items.
...
(They should only be used when we collect more info before performing
the command. If the command is something like showing the simulator,
then there should be no elipsis as we don't collect more info before
showing the window.)
Also improves a few of the menu tooltips.
2023-03-10 21:33:06 +00:00
b32ba16da4
UI: Add Numpad Enter as "Return" equivalent in missing places
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14244
2023-03-10 16:25:17 -05:00
357427d803
Graphical diff for board vs library footprints.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13736
2023-03-10 17:16:40 +00:00
56b7d570f9
Remove uses of climits header/defines
...
2 of the 3 includes never used it, and the other could be switched to
the C++ numeric_limits class.
2023-03-10 17:08:56 +00:00
a6ebd60c3b
CMake: Modernize Boost import to use imported targets
2023-03-10 16:38:35 +00:00
ade29c8577
Schematic Sheet Variables: more SCH_SHEET_PATH plumbing
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14239
2023-03-10 09:16:53 -05:00
bc0d59801a
Graphical diff for schematic vs library symbols.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13736
2023-03-09 18:04:52 +00:00
2d6ab62da4
ADDED: schematic/library diff for symbols.
2023-03-09 18:04:52 +00:00
b96f3d085c
Eeschema: save worksheet filename in project file.
...
The call to saveProjectSettings() was missing.
Fixes #14219
https://gitlab.com/kicad/code/kicad/issues/14219
2023-03-09 15:56:19 +01:00
e738750dff
Schematic: sheet pins need to use their parent to resolve text variables
...
Otherwise the current sheet will be searched, which is one layer too far
down the hierarchy.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13998
2023-03-08 11:52:43 -05:00
1bc4fc256a
Sheets: check for duplicates using shown names
...
Otherwise sheet names using sheet variables may collide
2023-03-08 11:52:43 -05:00
bf59f1246b
Schematic: correctly resolve label nets using sheet variables
2023-03-08 11:52:43 -05:00
c8fdac7abe
Schematic: correctly resolve global power nets using sheet variables
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/7445
2023-03-08 11:52:43 -05:00
6343147bb3
Fix Coverity warnings.
2023-03-08 11:37:56 +01:00
13de3c0656
Use constants for the names of the built-in colors
...
- Avoid repetition and errors from typos
- Allow simple changes
- Simpler data type handling, the constants are wxString
(Cherry-picked from f135881bd6
2023-03-07 10:34:42 +00:00
39e56485fc
Consolidated ERC fixes
...
- Consistent calculation of IsStacked() for pins across ERC checks
- Correct placement of ERC marker for unresolved field variables
- Add sheet-specific paths to two ERC check results
2023-03-07 00:37:33 +00:00
6838de962b
Make SPICE netlist title explicit.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14183
2023-03-06 22:50:17 +00:00
98d7b14dbc
A better solution to keep SPICE netlist from being entirely selected.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14177
2023-03-06 18:46:01 +00:00
b5060d2951
Support both wxWidgets APIs for excluded characters.
...
(Sadly they're mutually incompatible.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14153
2023-03-06 14:14:16 +00:00
a1fb8e1b1d
Coverity fixes and code cleaning.
2023-03-06 07:12:18 -05:00
7547e550aa
Use name (even for fallback models) *if* it's specified in dropdown.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12425
2023-03-06 11:17:39 +00:00
630ff02369
Fix bone-headed logic.
...
(Else clause never gets called because 3 is always > 2.)
2023-03-06 10:26:59 +00:00
90b5dba5ac
Altium Importer: add note that Parameter Set import is not yet supported
2023-03-06 02:13:40 +00:00
7b3fd2113c
Improve sheet rendering performance
...
- Cache font markup parsing
- Cache SCH_SYMBOL::GetOrientation
- Don't construct new strings each time in GetDefaultFieldName
2023-03-05 17:41:46 -05:00
5b43dc4e7b
Simulator: Fix diode ibv unit
2023-03-05 19:23:33 +02:00
d2bd7e33b9
Remove extra canvas redraws when changing sheets.
2023-03-05 04:33:07 +03:00
c1f4911d7e
bom_csv_grouped_extra: use field-specific methods for data.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14129
2023-03-05 03:23:51 +03:00
610e787ada
Move to requiring explicit action to save project settings
2023-03-04 14:25:07 -05:00
4e99812145
Coverity fixes and code cleaning.
2023-03-04 13:02:05 -05:00
d714ff8549
Don't commit changes on paint events or updateUI events.
...
Also use std::numeric_limits::epsilon for comparing doubles.
Fixes https://gitlab.com/kicad/code/kicad/issues/13851
2023-03-04 00:10:01 +00:00
d1b7fa6b0f
Slight improvement to property grid col widths in SME.
2023-03-04 00:10:01 +00:00
b6d0b65261
Naming conventions and commenting. No functional changes.
2023-03-04 00:10:01 +00:00
48740dd3f8
Clean exposure of CONNECTION_SUBGRAPH
...
Removes internals from public consumption.
2023-03-03 14:07:17 -08:00
d545216432
Prefer Clamp() to std::min( std::max() ).
2023-03-03 21:29:37 +00:00
bfc3e2d29b
Fix bitmap scaling when reading legacy schematic as well.
2023-03-04 00:11:09 +03:00
59fc62e898
Correct parent symbol for lib_text
...
The edited symbol should be pulled from the parent window when there is
not an existing text object
2023-03-03 12:39:07 -08:00
14f1f3ec79
Convert inline models in Sim.Params fields to SPICE syntax.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14157
2023-03-03 18:18:03 +00:00
2fb24347ad
Use resolved fields when generating LIB_TREE info.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13737
2023-03-03 17:22:50 +00:00
be18413a90
Fix typo.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14073
2023-03-03 17:05:07 +00:00
2973d292d9
Handle alternate pin definitions when printing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14122
2023-03-03 10:57:37 +00:00
5849458476
The screen for undo is the screen that *owns* the SCH_SHEET...
...
... not the screen the SCH_SHEET owns.
Fixes https://gitlab.com/kicad/code/kicad/issues/14099
2023-03-03 00:23:06 +00:00
f41f04b301
Hook up AddField handler to GRID_TRICKS for SCH dialogs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/git/14153
2023-03-02 18:17:41 +00:00
789bf6455a
Coverity fixes and code cleaning.
2023-03-02 09:04:47 -05:00
dcba555d44
Make SME prop-grid hack Mac-only.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13852
2023-03-02 10:42:13 +00:00
63a545ebfd
We don't need "(gain)" or "(phase)" in names any more.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14140
2023-03-02 00:38:39 +00:00
190ee58ccf
Don't deliver pedantic error messages to user.
2023-03-02 00:38:39 +00:00
db2780090c
Simulator: Fix RLGC c unit
2023-03-01 23:03:54 +00:00
9c68d4792f
Fix bungle from earlier merge.
2023-03-01 13:43:46 +00:00
f5edcf82f2
Move only-write-model-if-it-contains-overrides up to base class.
...
It's necessary to keep us from writing out model lines for included
models and fall-backs of included models.
2023-03-01 13:31:57 +00:00
4a761179d0
Simulator: Fix some cases with initial conditions
2023-02-28 21:31:04 +00:00
3207d1386e
Avoid forcing all units
...
When the enduser is not allowed to change the status of "common to all
units", then it should be disabled
Fixes https://gitlab.com/kicad/code/kicad/issues/14084
2023-02-28 13:25:32 -08:00
cc110399ea
Fix column offset in BOM script
...
Debugged by @svk28
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14128
2023-02-28 19:10:56 +00:00
a1ceb585c7
Always highlight children when they're selected on their own.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13876
2023-02-28 13:39:07 +00:00
281fde71b9
Make SIM_MODEL_SPICE_FALLBACK act more like the model it's a fallback for.
...
In particular, install/show the parameters, and keep the existing name
field.
Fixes https://gitlab.com/kicad/code/kicad/issues/14102
2023-02-28 12:26:04 +00:00
b03366c9e8
Fix CADSTAR importer memory leaks
...
We were leaking the xml tree when throwing exceptions
2023-02-27 23:57:39 +01:00
766b1a1ca8
Continue rationalisation of vector, trace and signal names.
...
Also add a little bit more code so user-defined signals can be edited
without resetting their properties.
Fixes https://gitlab.com/kicad/code/kicad/issues/14072
2023-02-27 21:11:31 +00:00
45e67950fd
Schematic: fix global labels overriding wrong power symbols
...
Need to check pin netname now that we support changing the value of the
power symbol.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14076
2023-02-27 09:25:05 -05:00
5b2784f418
sim - switches: open <-> closed in description
2023-02-27 09:54:14 +00:00
79f13ea9c7
Don't eval empty string.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13756
2023-02-26 23:14:09 +00:00
bcdb979128
CADSTAR SCH: Use screen grid instead of working grid when centering the design
2023-02-26 19:50:18 +01:00
698d0b7e92
CADSTAR Sch: Fix loading of graphical arc shapes
...
Correctly load arc shapes as real arcs instead of approximating now that
v7 supports graphical arcs in the schematic.
Also fix calculation of arc geometry for ccw arcs.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14101
2023-02-26 19:46:34 +01:00
beb177fa79
Try and sort out the mess that is trace names and trace titles.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14016
2023-02-26 18:08:42 +00:00
51d46c0e73
plotters rework: add plot fct to use TEXT_ATTRIBUTES class to pass text settings
...
Old PLOTTER::Text is not (yet) removed, but it use negative text size
to mirrored text, which is not really compatible with some plotters (especially PDF).
Using TEXT_ATTRIBUTES is much easy and much better,
so PLOTTER::PlotText() is added.
Note: "old" PLOTTER::Text() is not removed yet.
2023-02-26 14:44:53 +01:00
551773bf17
Save plot prefs (legend, grid, and dotted-secondary).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13940
2023-02-26 11:57:49 +00:00
c06cea2fe9
Fix units for ":power" operating points.
2023-02-25 23:30:01 +00:00
23c1a23faf
Provide power axis for DC-sweep analyses.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14087
2023-02-25 23:11:29 +00:00
8c8c5e1824
Provide a default xaxis for DC-sweep so we can add traces before sim is run.
2023-02-25 22:42:52 +00:00
1fdc81e68d
Make substrate and thermal junction nodes optional.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14083
2023-02-25 20:36:30 +00:00
2a79a453ec
Get rid of m_sortedSymbolPinList in favour of a properly scoped variable.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14083
2023-02-25 20:36:11 +00:00
77ed53ab25
Nullptr safety.
2023-02-25 18:33:32 +00:00
49a9fe38a0
Fix a compil warning
2023-02-25 19:06:46 +01:00
4b427b2d0c
Add second instance of "don't mess up user formatting" fix.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13989
2023-02-25 16:31:16 +00:00
2e5bf0210a
Clear model name when switching to internal model.
...
Also fixes a bug to ensure that a modelLine gets written when using
an internal model.
Fixes https://gitlab.com/kicad/code/kicad/issues/14083
2023-02-25 15:22:20 +00:00
9a0aeb4344
Adjust AC-small-signal plot names when saving placeholders.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14016
2023-02-25 13:26:33 +00:00
ee956673b1
Respect readOnly cells in GRID_TRICKS.
...
Also fixes setting colors in the signals grid as it allows us to make
it editable again.
Fixes https://gitlab.com/kicad/code/kicad/issues/14079
2023-02-25 11:02:12 +00:00
9dca70a773
Eeschema netlist output: Propagate NC across hierarchical schematics
...
Fixes #12580
Additionally does not export no_connect netlist annotation on pins
which are both connected to another pin and a NC item, unless all
connected pins are stacked at the symbol level.
Adds testing of pin types to netlist QA unit tests.
2023-02-25 00:02:46 +00:00
2b96161d0e
Log new undo record at the start of Change Symbols.
...
Also fixes a bug where the "screen" variable was used with stale
data.
Fixes https://gitlab.com/kicad/code/kicad/issues/14061
2023-02-24 22:41:46 +00:00
5a12e5ee76
Only write included models if they have overridden parameters.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13953
2023-02-24 20:31:35 +00:00
c188318174
Change strategy for committing values from SIM_MODEL propGrid.
...
Note that the PCB editor's propGrid doesn't seem to need this workaround,
but I haven't yet figured out what's different between it and the sim model
propGrid.
Fixes https://gitlab.com/kicad/code/kicad/issues/13852
2023-02-24 14:22:00 +00:00
200a06a677
Cleanup some dead code, and add a potentially needed fix for non-Mac.
...
(The Mac bug is fixed in 4e5b1da81fce7cd9ffedaec878ed07bfcfff4fe2 in
our wxWidgets fork.)
2023-02-24 12:44:55 +00:00
8059edff0e
Don't mess up user formatting if eval'ing didn't actually change value.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13989
2023-02-24 12:44:55 +00:00
71df3f9edb
Don't allow extra text in Sim.* fields.
...
(In particular, the field name.)
Fixes https://gitlab.com/kicad/code/kicad/issues/13996
2023-02-24 12:44:55 +00:00
be54ab396e
Move selection shadows to overlay.
...
This change doesn't appear to have any effect, but I think it's
correct.
2023-02-24 12:44:55 +00:00
ddf8d115c4
Handle de-highlighting items outside selection when selection changes.
...
Also adds selection cleared event to handled events.
And a small performance boost to not scan items for selection changes
when find is not seleciton-based.
2023-02-24 12:44:55 +00:00
2b3eb0b522
fix minor compil warnings
2023-02-23 09:50:28 +01:00
4917abe655
Make sure whitespace at end of command doesn't mess up detection.
...
(Fixes the failing test case.)
2023-02-22 23:29:13 +00:00
22bca5c2a0
Disable link maps by default and fix compile issue with lld linker
...
The link maps were actually disabled by default before
912f1d5cechttps://github.com/llvm/llvm-project/issues/60932
Co-authored-by: aris-kimi <aris_kimi@hotmail.com>
Co-authored-by: Ian McInerney <ian.s.mcinerney@ieee.org>
2023-02-22 23:18:36 +00:00
04165b22d1
Altium Schematic Import: add note that blanket's are not yet supported
2023-02-22 23:10:40 +00:00
cdbb868198
sim - allow users to delete several measurements at once
2023-02-22 19:27:20 +01:00
9006f38e70
sim - Don't allow user to delete the type-in measure entry
2023-02-22 19:27:20 +01:00
1170fb2e18
sim - don't create measurement duplicates
2023-02-22 19:27:20 +01:00
aa006e9b91
sim - allow to add several measurements at once.
2023-02-22 19:27:20 +01:00
959a19a461
Power Symbols: automatically fix mismatched legacy symbols, add tests
...
Has netlist generation test for legacy power symbols, and test for
fixing legacy mismatched power symbol text fields and invisible pin names.
2023-02-22 18:01:47 +00:00
5995e0e516
Power Symbols: make value editable, use as netname
...
QA: update tests for editable power symbol values
2023-02-22 18:01:47 +00:00
ca5004b1d2
Power Symbols: rename IsPowerConnection to IsGlobalPower
...
It's kind of confusing because we have power type pins, and pins that
make global power nets as part of power symbols.
2023-02-22 18:01:47 +00:00
dd461d6ad6
Power Symbols: drop requirement for invisible pins
2023-02-22 18:01:47 +00:00
6fcae34f6b
Clear operating points on all sim types.
...
(We'll fill them back in if we have data.)
Also improves handling when a plot tab is closed.
Also fixes dirtying of the view for op changes.
Fixes https://gitlab.com/kicad/code/kicad/issues/13990
2023-02-22 15:54:18 +00:00
fe2679d965
Implement default levels for JFETs, MOSFETs and MESFETs.
2023-02-22 15:54:18 +00:00
ae3a5c1c5f
sim - set the dialog list as read only
2023-02-22 15:54:49 +01:00
f2419e9e9b
sim - Fix power graphs
2023-02-22 13:18:12 +01:00
cb71ea872b
Don't allow 0 field text size.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13987
2023-02-22 11:40:49 +00:00
e24ddd0be4
ADDED: Measurement on power signals and integrals
...
Fixes #14028
2023-02-22 12:11:09 +01:00
f828d50cb0
Better processing of single-empty-row rule for measurements grid.
2023-02-22 10:45:27 +00:00
5fa7be0320
Update signals after running a sim.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14016
2023-02-22 10:45:27 +00:00
a126d961d8
More dead code removal and a bit of formatting and const& for strings.
2023-02-22 10:45:27 +00:00
68fe146861
Remove most of SIM_VALUE in favour of good old wxString.
...
This allows us to save the user's intent, including units, formatting,
and crucially variable references.
2023-02-22 10:45:27 +00:00
29f21cdde6
Terminology and more dead code.
2023-02-22 10:45:27 +00:00
90adc26b73
Remove dead and redundant code.
2023-02-22 10:45:27 +00:00
80b55f5980
Symbol editor: simpler creation of a new derived symbol
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13407
2023-02-22 01:49:46 +00:00
912f1d5cec
Modernize setting link map linker flags
2023-02-22 01:44:06 +00:00
bcb93e9aa7
Modernize setting of compiler definitions in CMake
...
add_compile_definitions was added in 3.12, and our minimum is now
greater than that.
2023-02-22 01:44:06 +00:00
39e69a3d29
Fix up handling of font names available in multiple names
...
ttf fonts can declare multiple language names. Many by default opt to just declare one and not tag it any particular language.
However, there are CJK languages that typically leverage this function the most. They'll tag both a "en" and a cjk lang family name in CJK characters.
To be as user friendly as possible, we need to display said fonts in the CJK languages if KiCad to set to such a locale.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14011
2023-02-21 20:26:41 -05:00
543a3317b4
Fix typo
2023-02-21 18:01:13 +00:00
761b59da90
Read and write user-defined signals and measurements to workbook file.
2023-02-21 13:32:01 +00:00
7fd707952b
Easier editing of new sim measurements.
2023-02-21 13:32:01 +00:00
6fcb95b24e
ADDED user-defined signals.
2023-02-21 13:32:01 +00:00
f6fcae479c
Don't generate error messages fetching sim data we know isn't there.
2023-02-21 13:32:01 +00:00
b05b33a9ff
Fix a compil issue with gcc12.2 and Coverity warnings.
2023-02-21 11:54:38 +01:00
3751b250c6
sim - fix a QA case for XSPICE
2023-02-20 19:40:59 +01:00
869447fedd
sim - ngspice does not support .probe p(Adevice)
...
Fixes #13979
2023-02-20 19:30:45 +01:00
2a3b70b7eb
sim - Remember the option to save powers
...
Fixes #13978
2023-02-20 19:30:45 +01:00
31be74b8b3
Fix a few Coverity warnings
2023-02-20 09:25:01 +01:00
d55e2049e5
Silence some warnings with static_casts
2023-02-18 23:36:50 -05:00
aacc9746e3
Yeet the last of wxSize/wxPoint to stop leaking gdicmn everywhere
2023-02-18 22:57:18 -05:00
dffd2da8c8
Fix the shared_lock added and micro-opt the reindex
2023-02-18 11:28:19 -05:00
facd50f4fd
sim - missing assignment
2023-02-18 15:36:47 +00:00
07f79208b9
Minor fixes: Coverity and compil minor warnings.
2023-02-18 13:04:43 +01:00
5482bc2905
sim - Check FindParam() results before using them
2023-02-18 12:54:55 +01:00
f5902dad28
sim - don't write dc parameter twice
2023-02-18 10:07:29 +00:00
fa0cc09917
sim - allow sources that are both AC and TRAN
2023-02-18 02:17:48 +00:00
39a1b14a0f
sim: VSIN - allow user to specify a phase
...
TD is not the same as PHASE.
TD is the delay before the source turns on.
PHASE is ... the phase
If only TD is set, the signal starts later, but the phase is still 0 when compared to the t=0 of the simulation.
2023-02-18 00:38:46 +00:00
2975f53647
PCM: auto reload global libs after dialog is run
...
This adds Reset() method to KIFACE to reload global libs stored in
global static vars.
Also refactors some lib reload code in various frames to have
common MAIL_RELOAD_LIB handler.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12500
2023-02-17 17:24:32 +00:00
fc68b8d71a
Make selected background layers translucent
...
We can't render them underneath other objects, but we can at least
make it possible to see other objects through them.
2023-02-16 22:45:29 -05:00
bd4758e4df
Keep image sizes when loading/saving 7.0- schematic file formats.
...
Previously, images were assumed to have 300 PPI density when loading from
schematic, but not after initial placement.
2023-02-17 03:53:44 +03:00
ecb28ddf1c
Prevent ghost image after canceling bitmap placement.
2023-02-17 03:53:44 +03:00
8b1318c92f
Update associated data structures after changing trace colour.
...
Also removes likely benign but never-the-less useless grid even processing
during rebuilding of the grids.
Fixes https://gitlab.com/kicad/code/kicad/issues/13956
2023-02-17 00:47:01 +00:00
614755f24e
Dialogs autocompletion with backspace support.
2023-02-16 23:28:27 +00:00
053d20e13d
Fix selection overlay being wiped when changing sheets
2023-02-16 17:14:08 -05:00
d5e50b70bb
Display a generic "Value" column label when there are no cursors.
2023-02-16 16:55:26 +00:00
f50d114b27
Push gain & phase for .probe statements in AC analysis.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13941
2023-02-16 16:14:25 +00:00
ec2fc161e1
Handle another case where schematic view was being cleared
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13944
2023-02-16 08:25:18 -05:00
5967ab9a4d
Don't allow SCH_LABEL_LOCATE_ANY_T to steal SCH_LABEL_LOCATE_WIRE_T's items.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13936
2023-02-16 13:21:00 +00:00
955a5a13eb
Symbol editor: stop removing overlay from view
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13944
2023-02-16 08:17:12 -05:00
95232edd0d
Do a better job of looking for .probe commands in directives.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13941
2023-02-16 12:42:54 +00:00
d8a4f9821e
Smarten regex to accept ':' in signal names.
...
(In fact, just accept anything up to the closing paren.)
Fixes https://gitlab.com/kicad/code/kicad/issues/13942
2023-02-16 12:20:55 +00:00
0f18a36f8f
Fix handling of selection overlay in schematic editor
...
We weren't actually using the overlay group at all
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11142
2023-02-15 21:16:58 -05:00
a761b0e860
Force DNP X to foreground
2023-02-15 11:35:24 -08:00
c618bb7046
Correctly netlist a voltage source with both AC and DC values.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13912
2023-02-15 14:50:31 +00:00
e8a88411ea
Set PPI properly in schematic bitmaps, too
2023-02-14 21:37:00 -05:00
64f1808d60
Don't use the just-in-time model resolver when updating the dialog.
...
If it changes in the middle it will leave you in a world of hurt.
Also don't update the library after a loss-of-focus unless the path
really changed.
Fixes https://gitlab.com/kicad/code/kicad/issues/13869
Fixes https://gitlab.com/kicad/code/kicad/issues/13854
2023-02-15 00:31:04 +00:00
29c4482bc8
Symbol chooser: save UI settings even when canceled
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13903
2023-02-14 18:26:29 -05:00
0913552f84
Handle custom columns in symbol tree synchronizing adapter
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13907
2023-02-14 18:26:29 -05:00
dca1281263
Fix some typos
2023-02-14 23:47:05 +02:00
18df4442bc
Schematic: Find and Replace on Selection
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9293
2023-02-14 14:04:59 -05:00
9f8b25a0b0
Don't desaturate the selection shadow
...
Selection shadows are helpful when showing which elements are selected
and there is no benefit (and some downside) to having their color
removed.
Fixes https://gitlab.com/kicad/code/kicad/issues/13878
2023-02-14 10:22:05 -08:00
50eaba4211
Performance fix for switching pages.
2023-02-14 17:14:31 +00:00
03484aedbc
Workaround wxWidgets enforced min pen width by using transparent pen.
...
Also fixes some bugs in our shape printing code when a border is not
specified but a fill is.
Fixes https://gitlab.com/kicad/code/kicad/issues/13891
2023-02-14 14:44:04 +00:00
76fb598ac2
Annotate: cleanup to use enum values instead of numbers
2023-02-14 08:21:43 -05:00
4b07e3e413
Common Actions: Find Previous
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8968
2023-02-14 08:21:37 -05:00
3e715c99c8
Swap: take S key now that it's available
2023-02-14 07:42:06 -05:00
9ce18dffdd
Better startup experience for simulator.
...
Pre-load signals list (and plot panel if there is an schText simulation
command).
Also fixes a bug where the workbook was getting dirtied on open because
the events would fire after the dirty flag had been cleared.
2023-02-14 11:59:17 +00:00
be0a9e2738
Handle SPICE prefixes for operating point data.
...
Also adjusts the min-pin lenght as some symbols have very short pins.
2023-02-13 18:38:43 +00:00
b53e0a85b8
Don't display OP overlay when we have no data.
...
Also fixes a copy-pasta bug with settings (and adds a fixup for those
already bitten by it).
Fixes https://gitlab.com/kicad/code/kicad/issues/13881
2023-02-13 18:08:53 +00:00
8bab429c7d
Account for border when calculating text margin for text boxes.
...
Also fixes some unnoticed issues with the textbox dialogs (probably
dating from the move to wxWidgets 3.2).
Fixes https://gitlab.com/kicad/code/kicad/issues/13877
2023-02-13 17:08:29 +00:00
d6bef19811
Don't confuse .OP with .OPTIONS.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13849
2023-02-13 13:33:26 +00:00
e6d45e27e8
Fix layout issue in IBIS fields.
2023-02-13 12:43:32 +00:00
df00585a55
ReadDataFields must be a separate step from Create.
...
Create() is done without execption processing, while ReadDataFields
should have exception processing.
(This also fixes a case where exception processing on ReadDataFields
was missing.)
Also fixes a bug where the pinSelect menu wasn't checked for -1 before
fetching.
Fixes https://gitlab.com/kicad/code/kicad/issues/13856
2023-02-13 12:43:25 +00:00
2cc3d8e9bc
Prevent a crash when a spice SW_I lacks two pin net names
...
Fixes KICAD-5D
2023-02-12 22:26:19 -05:00
74eb587291
Better sorting within sections (voltage, current, power).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13846
2023-02-12 23:16:45 +00:00
4665823089
Turn on and fix MSVC compliance mode issues
...
We want /permissive- to enable debug performance improvements in MSVC 17.5+.
This flag is also default under C++20 so we'll have to deal with these compile issues anyway at some point in the future.
In particular, MSVC becomes pedantic about ternary types.
See https://learn.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170#ambiguous-conditional-operator-arguments
MSFT cites https://cplusplus.github.io/CWG/issues/1805.html
2023-02-12 16:30:37 -05:00
6af3dadaee
Fix SPICE pins for BJTs and MESFETs
...
- MESFETs don't have a substrate/bulk pin
- BJTs have a substrate pin, and HICUM/VBIC have TJ
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13848
2023-02-12 21:20:02 +00:00
a22964a977
Prepend correct SPICE prefix when necessary for plotting currents.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13850
2023-02-12 21:17:45 +00:00
1e756dbdd8
Save cursor positions in sim workbook.
2023-02-12 20:40:23 +00:00
83dd06e5d1
Allow opening of workbook when simulation frame is opened.
...
This involved splitting creation of traces from setting of trace
data.
Also renamed SIM_WORKBOOK to SIM_NOTEBOOK. This class is a subclass
of wxAiuNotebook and represents the collection of simulation plot tabs.
It is NOT the same thing as a simulation workbook, which contains other
stuff such as measurements, plotted signals, colours, etc.
This also removes a bunch of "friend" declarations.
2023-02-12 20:40:23 +00:00
78746b77c6
Save trace colors and cursor value formatting in sim workbook.
2023-02-12 20:40:23 +00:00
84c72b087c
Simplify (and fix) logic for starting new simulations.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13853
2023-02-12 20:40:23 +00:00
1fb2d138b4
Fix a compil issue.
2023-02-12 09:16:42 +01:00
9d3a3d705d
ADDED simulation measurements.
2023-02-11 21:11:07 +00:00
e5176ff4d6
ADDED power dissipation plotting and cursors.
...
Also fixes a bug so that voltages, currents and power dissipations are
only probed if the flag is set -- this keeps ngspice from throwing an
error if you probe something twice (for instance, if you have .probe
commands in text and turn off the auto-probing).
2023-02-11 21:11:07 +00:00
bc108023b3
ADDED operating point overlay for SCH_EDIT_FRAME.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-11 21:11:07 +00:00
2a5bb71fbd
ADDED operating point text variables for labels and symbols.
...
ADDED formatting for cursors and operationg points
Also fixes a bunch of bugs to make the new cursors work with .ac sims.
Fixes https://gitlab.com/kicad/code/kicad/issues/11253
Fixes https://gitlab.com/kicad/code/kicad/issues/6965
2023-02-11 21:11:07 +00:00
b3ffbd6258
Don't include unconnected nets in signals list.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4961
2023-02-11 21:11:07 +00:00
7e6c68b1d1
Remove (probably) redundant code.
2023-02-11 21:11:07 +00:00
39d35a8bec
Better cursor feedback for plot window.
2023-02-11 21:11:07 +00:00
9a99106981
Cleanup.
2023-02-11 21:11:07 +00:00
f0bd25b397
ADDED use-settable simulation trace colors.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2536
2023-02-11 21:11:07 +00:00
09822c7f18
ADDED direct access to signals & cursors.
...
ADDED differential cursors.
Fixes https://gitlab.com/kicad/code/kicad/issues/4447
Fixes https://gitlab.com/kicad/code/kicad/issues/6221
2023-02-11 21:11:07 +00:00
95fb3825bd
Fix some strings from V7's string freeze.
2023-02-11 21:11:07 +00:00
6bc89ee180
Don't disable run when there's no command: just ask for a command.
2023-02-11 21:11:07 +00:00
7d7a48070e
Separate error messages when sim model and project paths are the same.
2023-02-11 21:11:07 +00:00
a1a1a49729
On-the-fly language updates for simulator window.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13357
2023-02-11 21:11:07 +00:00
b000d68def
Move simulator to tool framework.
2023-02-11 21:11:07 +00:00
02e14b45ee
Better predictability and error reporting for running external SPICE.
2023-02-11 21:11:07 +00:00
946e0a4b98
ADDED support for e-series based tuning.
2023-02-11 21:11:07 +00:00
7bc79c17d4
Make sure screen RTrees are updated when changing bounding boxes.
2023-02-11 20:43:00 +00:00
9ce5978c3d
Bug fixes for LIB_PIN boundbox generation.
2023-02-11 20:43:00 +00:00
2e9ed67e05
Don't dirty connectivity when moving non-reference SCH_FIELD.
2023-02-11 20:43:00 +00:00
a6776edc26
Try to resolve worksheet filename before saving it
...
The new code was added to handle saving imported worksheets,
but it is possible to specify relative paths to worksheets
not only to the project folder but also to the global
templates directories.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13834
2023-02-11 10:33:23 -05:00
93020cf78f
Set select_pin_selects_symbol to false by default.
2023-02-11 16:51:55 +03:00
81a55c42a1
Fix unintentional string change in IBIS parser.
2023-02-11 02:19:06 +03:00
06e3e63b96
Eeschema: text properties: reference field autocomplete ignores first char.
2023-02-10 21:56:03 +00:00
c22fb390ec
Set the text proeprties grid bag to avoid reserving space for hidden cells
2023-02-09 23:04:51 -05:00
d4ca54a798
Handle global label offset when plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13301
2023-02-09 18:02:21 +00:00
3d23d0e16a
Fix compatibility with wxWidgets 3.0.5
...
Fixes #13808
https://gitlab.com/kicad/code/kicad/issues/13808
2023-02-07 21:09:03 +01:00
77d4704b45
Don't return a lib-tree symbol if the lib-tree is hidden.
2023-02-07 15:53:14 +00:00
e14f0848fa
SCH_EDITOR_CONTROL::Paste() - Adjust refdes behavior to match when creating new symbols
...
Pass 'false' as aStartAtCurrent to ReannotateByOptions(). Causes Pasing() symbols to start at the first available refdes after the currently
configured annotate start number, m_annotateStartNum.
Fixes #13342
2023-02-06 14:05:04 +00:00
4065e413ea
Ibis parser: do not report activity when there are no errors.
...
The dialog to add a library expects no message when there are no error.
Fixes #13794
https://gitlab.com/kicad/code/kicad/issues/13794
2023-02-06 12:55:52 +01:00
92724ff09f
Coding style fix.
2023-02-06 07:59:17 +01:00
3ecd6ec186
Fix variable updating in SCH_FIELDs (which are not directly in the view).
2023-02-05 20:51:03 +00:00
fb225acefc
Eeschema, ExportSymbolsToLibrary(): fix not working replace library.
...
When exporting symbols of the schematic to a new library, if this library
exists the dialog ask for overwriting it, but it did not work.
Fixed now.
2023-02-05 18:41:58 +01:00
baeeeec492
Fix broken update symbol from library.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13782
2023-02-05 10:36:18 -05:00
d1f6ba77e8
Better error reporting, and don't infer models with library references.
2023-02-04 20:55:52 +00:00
9be872a85a
Better bounds checking for DIALOG_SIM_MODEL::curModel().
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13767
2023-02-04 20:16:50 +00:00
56a1cdb4dc
Allow a limited set of un-braced expressions in SPICE model values.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13768
2023-02-04 19:49:48 +00:00
f588da2bef
Bounds checking for DIALOG_SIM_MODEL::curModel().
2023-02-04 19:17:13 +00:00
52b07b8bac
Fix duplicate symbol value fields when importing Eagle schematic.
...
Don't use the value field when adding Eagle part attributes to a symbol.
This issue was cause by using a mandatory symbol field ID instead of
using the next available field ID when adding new fields to as symbol.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13468
2023-02-04 12:37:41 -05:00
6b5eeeb861
Preferences dialog: try to reduce its width, in non English languages.
...
Remove some useless spacers, and do not force some widgets to have a to
large size (by removing empty areas).
Work in progress: one panel is still too big.
2023-02-04 14:36:14 +01:00
e8397a33bb
Refrain from copying SPICE_INFO.
2023-02-04 00:05:50 +00:00
a51dc8c9de
HiSIM_HV MOSFET models are *not* the default type
...
The ngspice manual does not indicate that there is any default
model type. This change ensures we get a `level=xy` written out to the
.model line when we select a HiSIM_HV model.
2023-02-04 00:03:25 +00:00
5abe1a201b
spice: generate .model lines for all device types
...
- generate .model lines in spice netlist for all device types that need
one
- add "level=<n>" to .model line for non-default model levels. This is
necessary to allow more sophisticated models to be used, and some
devices *always* need a level specified (e.g. JFETs)
- add "version=<n>" to .model line for models that have multiple
versions available (AFAIK only affects HiSIM_HV MOSFET models)
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13775
2023-02-04 00:03:25 +00:00
41c4ee2245
ngspice requires J prefix for JFETs in netlist
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13774
2023-02-04 00:03:25 +00:00
ed5fb2769f
Allow more characters (in particular '_') in code model names.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13769
2023-02-03 23:49:53 +00:00
71b8a2112c
Coverty fixes.
2023-02-03 15:09:24 +00:00
a94d8a7e78
Use references instead of copies in map pair for loops.
2023-02-03 10:00:09 -05:00
9e03a71b44
Fix broken value and footprint field text values.
...
Only update value and footprint fields from instance data if it's not
empty. These fields were not always stored in the instance data so
loading them from instance data that does not contain them will clear
the fields.
https://gitlab.com/kicad/code/kicad/-/issues/13735
2023-02-03 09:48:18 -05:00
8ce0a84ca7
Fix compatibility with older wxWidgets versions.
...
Fix also a compil warning
2023-02-03 08:24:38 +01:00
9b9ebebb2d
Add missing autocomplete for FILENAME, PROJECTNAME
2023-02-03 00:10:55 +00:00
c88c4e1200
Fix schematic update library symbols issues.
...
Rather than update library symbols one at a time, queue them up by
schematic symbol to prevent multiple updates to the same symbol in
complex hierarchies. This also removes all of the library symbols
first which will clear out all of the library symbol variants that
were created by modifying library symbols in place and/or changes to
the symbol in the library.
Don't add new variant library symbol if an equivalent variant already
exists in the schematic local cache. This prevents duplicate library
symbols from being added to the local cache when the first variant in
the cache does not match that of the symbol being added.
2023-02-02 15:54:24 -05:00
8b03c093f9
Move potentiometer pin model to r0, wiper, r1, and remove flipping code.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13741
2023-02-02 16:22:13 +00:00
ab0c4dd292
Must do pin swap in model pins, not item pins.
...
Item pins might not be in the same order.
Fixes https://gitlab.com/kicad/code/kicad/issues/13741
2023-02-02 12:44:55 +00:00
71002dce28
Eeschema: Fix export symbols to new library
...
Exporting symbols to new library now saves the library and forces
update of symbol links
Fixes #13494
2023-02-02 11:31:18 +00:00
4a0a5f2265
Fix backwards display of ${DNP}
...
${DNP} displayed "DNP" when DNP was cleared, and "" when DNP was set
2023-02-01 22:40:58 +00:00
5b9b555fdf
eeschema: fix sheet symbol pins changing side when resizing
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13719
2023-02-01 15:53:59 +00:00
ab954456ee
Symbol Fields Table: don't leave Qty editable on error
2023-02-01 10:19:23 -05:00
4c18dfebb9
Add Show Name column to FormBuilder files.
2023-02-01 12:36:27 +00:00
b4a75cd1d5
Write out a diode .model for built-in diodes.
2023-02-01 12:36:27 +00:00
29fd1b45d6
Ensure the DATASHEET field value only is used to know the datasheet URL.
...
previously, if the field option "show name" is set, the field name was
added to the URL, that broke it.
Fixes #13729
https://gitlab.com/kicad/code/kicad/issues/13729
2023-02-01 11:37:07 +01:00
56f900b14f
Remove errant wxTextCtrl style flags.
2023-02-01 06:22:32 +03:00
29a4e2c7fe
Schematic: fix reversed tooltips for navigation buttons
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13707
2023-01-31 13:05:37 -05:00
jean-pierre charras
Jeff Young
Wayne Stambaugh
Mike Williams
Ian McInerney
Salvador E. Tropea
James J
Stefan
Jon Evans
aris-kimi
Alex
Seth Hillbrand
Graham Keeth
Roberto Fernandez Bautista
Fabien Corona
Chris Morgan
Ian McInerney
Marek Roszko
qu1ck
Paweł Płóciennik
vinsfortunato